Select::withDisabled() - Code Metrics - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Select::withDisabled() A
last analyzed 2017-04-08 20:23 UTC

↳ Parent: Select

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Set\ElementSet;
use RoyallTheFourth\HtmlDocument\Tag\Standard;

/**
 * Class Select
 * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
 */
final class Select extends AbstractElement implements ParentElementInterface

{
    public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
    {
        $this->attributes = $attributes ?? new AttributeSet();
        $this->children = $children ?? new ElementSet();
        $this->tag = new Standard('select', $attributes, $children);
    }

    public function withAttribute(string $name, string $value = null): Select
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Select($this->attributes->add($attribute), $this->children);
    }

    public function withChild(ElementInterface $element): Select
    {
        return new Select($this->attributes, $this->children->add($element));
    }

    public function withAutoFocus(): Select
    {
        return $this->withAttribute('autofocus');
    }

    public function withDisabled(): Select
    {
        return $this->withAttribute('disabled');
    }

    public function withForm(string $id): Select
    {
        return $this->withAttribute('form', $id);
    }

    public function withMultiple(): Select
    {
        return $this->withAttribute('multiple');
    }

    public function withName(string $name): Select
    {
        return $this->withAttribute('name', $name);
    }

    public function withRequired(): Select
    {
        return $this->withAttribute('required');
    }

    public function withSelected(): Select
    {
        return $this->withAttribute('selected');
    }

    public function withSize(int $rows): Select
    {
        return $this->withAttribute('size', $rows);
    }
}


1		<?php
2
3		namespace RoyallTheFourth\HtmlDocument\Element;
4
5		use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6		use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7		use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8		use RoyallTheFourth\HtmlDocument\Set\ElementSet;
9		use RoyallTheFourth\HtmlDocument\Tag\Standard;
10
11		/**
12		* Class Select
13		* @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
14		*/
15	View Code Duplication	final class Select extends AbstractElement implements ParentElementInterface
		0 ignored issues – show Duplication introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		public function __construct(AttributeSet $attributes = null, ElementSet $children = null)
18		{
19		$this->attributes = $attributes ?? new AttributeSet();
20		$this->children = $children ?? new ElementSet();
21		$this->tag = new Standard('select', $attributes, $children);
22		}
23
24		public function withAttribute(string $name, string $value = null): Select
25		{
26		if ($value) {
		0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
27		$attribute = new StandardAttribute($name, $value);
28		} else {
29		$attribute = new BooleanAttribute($name);
30		}
31
32		return new Select($this->attributes->add($attribute), $this->children);
33		}
34
35		public function withChild(ElementInterface $element): Select
36		{
37		return new Select($this->attributes, $this->children->add($element));
38		}
39
40		public function withAutoFocus(): Select
41		{
42		return $this->withAttribute('autofocus');
43		}
44
45		public function withDisabled(): Select
46		{
47		return $this->withAttribute('disabled');
48		}
49
50		public function withForm(string $id): Select
51		{
52		return $this->withAttribute('form', $id);
53		}
54
55		public function withMultiple(): Select
56		{
57		return $this->withAttribute('multiple');
58		}
59
60		public function withName(string $name): Select
61		{
62		return $this->withAttribute('name', $name);
63		}
64
65		public function withRequired(): Select
66		{
67		return $this->withAttribute('required');
68		}
69
70		public function withSelected(): Select
71		{
72		return $this->withAttribute('selected');
73		}
74
75		public function withSize(int $rows): Select
76		{
77		return $this->withAttribute('size', $rows);
78		}
79		}
80

royallthefourth / html-document

Select::withDisabled() A last analyzed 2017-04-08 20:23 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Select::withDisabled() A
last analyzed 2017-04-08 20:23 UTC