Parameter::withAttribute() - Code Metrics - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Parameter::withAttribute() A
last analyzed 2017-04-08 20:23 UTC

↳ Parent: Parameter

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	6
nc	2
nop	2

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Tag\EmptyTag;

/**
 * Class Parameter
 * @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/param
 */
final class Parameter extends AbstractElement
{
    public function __construct(AttributeSet $attributes = null)
    {
        $this->attributes = $attributes ?? new AttributeSet();
        $this->tag = new EmptyTag('param', $attributes);
    }

    public function withAttribute(string $name, string $value = null): Parameter
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Parameter($this->attributes->add($attribute));
    }

    public function withName(string $name): Parameter
    {
        return $this->withAttribute('name', $name);
    }

    public function withValue(string $value): Parameter
    {
        return $this->withAttribute('value', $value);
    }
}


1			<?php
2
3			namespace RoyallTheFourth\HtmlDocument\Element;
4
5			use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6			use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7			use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8			use RoyallTheFourth\HtmlDocument\Tag\EmptyTag;
9
10			/**
11			* Class Parameter
12			* @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/param
13			*/
14			final class Parameter extends AbstractElement
15			{
16			public function __construct(AttributeSet $attributes = null)
17			{
18			$this->attributes = $attributes ?? new AttributeSet();
19			$this->tag = new EmptyTag('param', $attributes);
20			}
21
22			public function withAttribute(string $name, string $value = null): Parameter
23			{
24			if ($value) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
25			$attribute = new StandardAttribute($name, $value);
26			} else {
27			$attribute = new BooleanAttribute($name);
28			}
29
30			return new Parameter($this->attributes->add($attribute));
31			}
32
33			public function withName(string $name): Parameter
34			{
35			return $this->withAttribute('name', $name);
36			}
37
38			public function withValue(string $value): Parameter
39			{
40			return $this->withAttribute('value', $value);
41			}
42			}
43

royallthefourth / html-document

Parameter::withAttribute() A last analyzed 2017-04-08 20:23 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Parameter::withAttribute() A
last analyzed 2017-04-08 20:23 UTC