Arbitrary::withAttribute() - Code Metrics - royallthefourth/html-document - Measure and Improve Code Quality continuously with Scrutinizer

Arbitrary::withAttribute() A
last analyzed 2017-04-08 20:23 UTC

↳ Parent: Arbitrary

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

namespace RoyallTheFourth\HtmlDocument\Element;

use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
use RoyallTheFourth\HtmlDocument\Set\ElementSet;
use RoyallTheFourth\HtmlDocument\Tag\Standard;

/**
 * Class Arbitrary
 * Any type of tag with a matching close tag.
 */
final class Arbitrary extends AbstractElement
{
    private $name;

    public function __construct(string $name, AttributeSet $attributes = null, ElementSet $children = null)
    {
        $this->tag = new Standard($name, $attributes, $children);
        $this->attributes = $attributes ?? new AttributeSet();
        $this->children = $children ?? new ElementSet();
    }

    public function withAttribute(string $name, string $value = null): Arbitrary
    {
        if ($value) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attribute = new StandardAttribute($name, $value);
        } else {
            $attribute = new BooleanAttribute($name);
        }

        return new Arbitrary($this->name, $this->attributes->add($attribute), $this->children);
    }

    public function withChild(ElementInterface $element): Arbitrary
    {
        return new Arbitrary($this->name, $this->attributes, $this->children->add($element));
    }
}


1			<?php
2
3			namespace RoyallTheFourth\HtmlDocument\Element;
4
5			use RoyallTheFourth\HtmlDocument\Attribute\BooleanAttribute;
6			use RoyallTheFourth\HtmlDocument\Attribute\StandardAttribute;
7			use RoyallTheFourth\HtmlDocument\Set\AttributeSet;
8			use RoyallTheFourth\HtmlDocument\Set\ElementSet;
9			use RoyallTheFourth\HtmlDocument\Tag\Standard;
10
11			/**
12			* Class Arbitrary
13			* Any type of tag with a matching close tag.
14			*/
15			final class Arbitrary extends AbstractElement
16			{
17			private $name;
18
19			public function __construct(string $name, AttributeSet $attributes = null, ElementSet $children = null)
20			{
21			$this->tag = new Standard($name, $attributes, $children);
22			$this->attributes = $attributes ?? new AttributeSet();
23			$this->children = $children ?? new ElementSet();
24			}
25
26			public function withAttribute(string $name, string $value = null): Arbitrary
27			{
28			if ($value) {
			0 ignored issues – show Bug Best Practice introduced 2016-11-21 21:38 UTC by Report Bug Copy Issue Report The expression `$value` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
29			$attribute = new StandardAttribute($name, $value);
30			} else {
31			$attribute = new BooleanAttribute($name);
32			}
33
34			return new Arbitrary($this->name, $this->attributes->add($attribute), $this->children);
35			}
36
37			public function withChild(ElementInterface $element): Arbitrary
38			{
39			return new Arbitrary($this->name, $this->attributes, $this->children->add($element));
40			}
41			}
42

royallthefourth / html-document

Arbitrary::withAttribute() A last analyzed 2017-04-08 20:23 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Arbitrary::withAttribute() A
last analyzed 2017-04-08 20:23 UTC