dict_property() - Code Metrics - Inspection of "Move Python SDK V1 to alpha" - route4me/route4me-python-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — v1 (#16)

by Maksim

created 2017-09-04 09:18 UTC

dict_property() F

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	60
Ratio	84.51 %

Code Coverage

Tests	28
CRAP Score	12.7405

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	11
dl	60
loc	71
ccs	28
cts	37
cp	0.7568
crap	12.7405
rs	3.5526
c	2
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	decorator_other()	31	31	5
B	decorator_str()	29	29	4

How to fix Long Method Complexity

# -*- coding: utf-8 -*-

import six
import logging

import pydash

log = logging.getLogger(__name__)


def _handle_auto_doc_for_property(doc, typename):
	if doc is None:
		doc = '<AUTO>'

	if '<AUTO>' in doc:
		subst = (
			':getter: Get\n'
			'{pref}:setter: Set\n'
			'{pref}:rtype: {typename}'
		).format(
			typename=typename,
			pref='\t\t',
		)
		doc = doc.replace('<AUTO>', subst)

	return doc


def dict_enum_property(path, enumtype):
	def decorator(fn):

		def _get(self):
			v = pydash.get(self.raw, path)

			if v is None:
				return None

			return enumtype(v)

		def _set(self, value):
			if isinstance(value, enumtype):
				value = value.value
			value = fn(self, value)
			pydash.set_(self.raw, path, value)

			return enumtype(value)

		doc = _handle_auto_doc_for_property(
			fn.__doc__,
			'~{mod}.{nm}'.format(
				mod=enumtype.__module__,
				nm=enumtype.__name__,
			)
		)

		p = property(_get, _set, None, doc)
		return p
	return decorator


# TODO: test over unicode in python 2
def dict_property(path, anytype):
	"""
	Creates new strict-typed PROPERTY for classes inherited from :class:`dict`
	"""

	def decorator_str(fn):


		def _get(self):
			v = pydash.get(self.raw, path)

			if v is None:
				return None

			return six.text_type(v)

		def _set(self, value):
			v = six.text_type(value)
			v = fn(self, v)
			pydash.set_(self.raw, path, v)

			return v

		doc = fn.__doc__

		typename = type(six.text_type('')).__name__

		doc = _handle_auto_doc_for_property(
			fn.__doc__,
			typename
		)

		p = property(_get, _set, None, doc)

		return p

	def decorator_other(fn):


		def _get(self):
			v = pydash.get(self.raw, path)

			if v is None:
				return None

			return anytype(v)

		def _set(self, value):
			v = fn(self, value)
			pydash.set_(self.raw, path, v)

			return v

		doc = fn.__doc__

		if doc is None:
			doc = '<AUTO>'

		typename = anytype.__name__

		doc = _handle_auto_doc_for_property(
			fn.__doc__,
			typename
		)

		p = property(_get, _set, None, doc)

		return p

	if anytype == str:
		return decorator_str

	return decorator_other


1			# -- coding: utf-8 --
2
3	1		import six
4	1		import logging
5
6	1		import pydash
7
8	1		log = logging.getLogger(__name__)
9
10
11	1		def _handle_auto_doc_for_property(doc, typename):
12	1		if doc is None:
13			doc = '<AUTO>'
14
15	1		if '<AUTO>' in doc:
16	1		subst = (
17			':getter: Get\n'
18			'{pref}:setter: Set\n'
19			'{pref}:rtype: {typename}'
20			).format(
21			typename=typename,
22			pref='\t\t',
23			)
24	1		doc = doc.replace('<AUTO>', subst)
25
26	1		return doc
27
28
29	1		def dict_enum_property(path, enumtype):
30	1		def decorator(fn):
31
32	1		def _get(self):
33	1		v = pydash.get(self.raw, path)
34
35	1		if v is None:
36			return None
37
38	1		return enumtype(v)
39
40	1		def _set(self, value):
41	1		if isinstance(value, enumtype):
42	1		value = value.value
43	1		value = fn(self, value)
44	1		pydash.set_(self.raw, path, value)
45
46	1		return enumtype(value)
47
48	1		doc = _handle_auto_doc_for_property(
49			fn.__doc__,
50			'~{mod}.{nm}'.format(
51			mod=enumtype.__module__,
52			nm=enumtype.__name__,
53			)
54			)
55
56	1		p = property(_get, _set, None, doc)
57	1		return p
58	1		return decorator
59
60
61			# TODO: test over unicode in python 2
62	1		def dict_property(path, anytype):
63			"""
64			Creates new strict-typed PROPERTY for classes inherited from :class:`dict`
65			"""
66
67	1	View Code Duplication	def decorator_str(fn):
			0 ignored issues – show Duplication introduced 2017-09-04 09:22 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
68
69	1		def _get(self):
70	1		v = pydash.get(self.raw, path)
71
72	1		if v is None:
73	1		return None
74
75	1		return six.text_type(v)
76
77	1		def _set(self, value):
78			v = six.text_type(value)
79			v = fn(self, v)
80			pydash.set_(self.raw, path, v)
81
82			return v
83
84	1		doc = fn.__doc__
85
86	1		typename = type(six.text_type('')).__name__
87
88	1		doc = _handle_auto_doc_for_property(
89			fn.__doc__,
90			typename
91			)
92
93	1		p = property(_get, _set, None, doc)
94
95	1		return p
96
97	1	View Code Duplication	def decorator_other(fn):
			0 ignored issues – show Duplication introduced 2017-09-04 09:22 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
98
99	1		def _get(self):
100	1		v = pydash.get(self.raw, path)
101
102	1		if v is None:
103			return None
104
105	1		return anytype(v)
106
107	1		def _set(self, value):
108			v = fn(self, value)
109			pydash.set_(self.raw, path, v)
110
111			return v
112
113	1		doc = fn.__doc__
114
115	1		if doc is None:
116			doc = '<AUTO>'
117
118	1		typename = anytype.__name__
119
120	1		doc = _handle_auto_doc_for_property(
121			fn.__doc__,
122			typename
123			)
124
125	1		p = property(_get, _set, None, doc)
126
127	1		return p
128
129	1		if anytype == str:
130	1		return decorator_str
131
132			return decorator_other
133

route4me / route4me-python-sdk

GitHub Access Token became invalid

Pull Request — v1 (#16)

dict_property() F

Complexity

Size

Duplication

Code Coverage

Importance

2 Methods

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like