Inspection of "created Teleamtics Vendors class and examples" - route4me/route4me-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d70a9b...6b18d7 )

by Oleg

created 2019-06-14 13:50 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,8 +34,8 @@
 block discarded – undo
 
 // Update existing configuration key data
 $params = Member::fromArray(array (
-    "config_key"   => $randomKey,
-    "config_value" => $randomValue." Updated"
+	"config_key"   => $randomKey,
+	"config_value" => $randomValue." Updated"
 ));
 
 $response = $member->updateMemberConfigKey($params);

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 $member = new Member();
 
 // Get a random member config key
-$randomParams = Member::fromArray(array ( ));
+$randomParams = Member::fromArray(array( ));
 
 $response = $member->getMemberConfigData($randomParams);
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 echo "Random key -> $randomKey,  random value -> $randomValue <br><br>";
 
 // Update existing configuration key data
-$params = Member::fromArray(array (
+$params = Member::fromArray(array(
     "config_key"   => $randomKey,
     "config_value" => $randomValue." Updated"
 ));

Please login to merge, or discard this patch.

examples/MemberConfiguration/get_specific_account_config_key_data.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -32,15 +32,15 @@
 block discarded – undo
 echo "randomKey -> $randomKey <br><br>";
 
 $params = Member::fromArray(array (
-    "config_key"  => $randomKey
+	"config_key"  => $randomKey
 ));
 
 $response = $member->getMemberConfigData($params);
 
 foreach ($response as $key => $value) {
-    if (is_array($value)) {
-        Route4Me::simplePrint($value);
-    } else {
-        echo "$key => $value <br>";
-    }
+	if (is_array($value)) {
+		Route4Me::simplePrint($value);
+	} else {
+		echo "$key => $value <br>";
+	}
 }

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -18,7 +18,7 @@  discard block
 block discarded – undo
 $member = new Member();
 
 // Get a random member config key
-$randomParams = Member::fromArray(array ( ));
+$randomParams = Member::fromArray(array( ));
 
 $response = $member->getMemberConfigData($randomParams);
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 // Get a specified single configuration key data
 echo "randomKey -> $randomKey <br><br>";
 
-$params = Member::fromArray(array (
+$params = Member::fromArray(array(
     "config_key"  => $randomKey
 ));
 

Please login to merge, or discard this patch.

examples/Routes/DeleteRoutes.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 namespace Route4Me;
 
-$root=realpath(dirname(__FILE__).'/../../');
+$root = realpath(dirname(__FILE__).'/../../');
 require $root.'/vendor/autoload.php';
 
 use Route4Me\Route4Me;

Please login to merge, or discard this patch.

examples/Routes/MergeRoutes.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 namespace Route4Me;
 
-$root=realpath(dirname(__FILE__).'/../../');
+$root = realpath(dirname(__FILE__).'/../../');
 require $root.'/vendor/autoload.php';
 
 use Route4Me\Route4Me;

Please login to merge, or discard this patch.

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -25,13 +25,13 @@  discard block
 block discarded – undo
 $count = 0; 
 
 while ($route_id1==$route_id2) {
-    $route_id2 = $route->getRandomRouteId(0, 20);
+	$route_id2 = $route->getRandomRouteId(0, 20);
     
-    $count++;
+	$count++;
     
-    if ($count>5) {
-        break;
-    }
+	if ($count>5) {
+		break;
+	}
 }
 
 echo "Route ID 1 -> $route_id1 <br> Route ID 2 -> $route_id2 <br>";
@@ -43,21 +43,21 @@  discard block
 block discarded – undo
 $depot = null;
 
 foreach ($addresses as $address) {
-    if (isset($address->is_depot)) {
-        if ($address->is_depot==true) {
-            $depot = $address;
-            break;
-        }
-    }
+	if (isset($address->is_depot)) {
+		if ($address->is_depot==true) {
+			$depot = $address;
+			break;
+		}
+	}
 }
 
 // Merge the selected routes
 $params = array(
-    "route_ids"      => $route_id1.",".$route_id2,
-    "depot_address"  =>  $depot->address,
-    "remove_origin"  =>  false,
-    "depot_lat"      =>  $depot->lat,
-    "depot_lat"      =>  $depot->lng
+	"route_ids"      => $route_id1.",".$route_id2,
+	"depot_address"  =>  $depot->address,
+	"remove_origin"  =>  false,
+	"depot_lat"      =>  $depot->lat,
+	"depot_lat"      =>  $depot->lng
 );
 
 $result = $route->mergeRoutes($params);

Please login to merge, or discard this patch.

examples/Territories/DeleteTerritory.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -18,14 +18,14 @@
 block discarded – undo
 
 $territoryParams['type'] = TerritoryTypes::CIRCLE;
 $territoryParams['data'] = array(
-    "37.569752822786455,-77.47833251953125",
-    "5000"
+	"37.569752822786455,-77.47833251953125",
+	"5000"
 );
 
 $TerritoryParameters = Territory::fromArray(array(
-    "territory_name"   => "Test Territory ".strval(rand(10000, 99999)),
-    "territory_color"  => "ff7700",
-    "territory"        => $territoryParams
+	"territory_name"   => "Test Territory ".strval(rand(10000, 99999)),
+	"territory_color"  => "ff7700",
+	"territory"        => $territoryParams
 ));
 
 $territory = new Territory();

Please login to merge, or discard this patch.

examples/Territories/CreateRectangularTerritory.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -16,14 +16,14 @@
 block discarded – undo
 
 $territoryParams['type'] = TerritoryTypes::RECT;
 $territoryParams['data'] = array(
-    "43.51668853502909,-109.3798828125",
-    "46.98025235521883,-101.865234375"
+	"43.51668853502909,-109.3798828125",
+	"46.98025235521883,-101.865234375"
 );
 
 $TerritoryParameters = Territory::fromArray(array(
-    "territory_name"   => "Test Rectangular Territory ".strval(rand(10000, 99999)),
-    "territory_color"  => "ff7700",
-    "territory"        => $territoryParams
+	"territory_name"   => "Test Rectangular Territory ".strval(rand(10000, 99999)),
+	"territory_color"  => "ff7700",
+	"territory"        => $territoryParams
 ));
 
 $territory = new Territory();

Please login to merge, or discard this patch.

examples/Territories/UpdateTerritory.php 2 patches

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -18,14 +18,14 @@  discard block
 block discarded – undo
 
 $territoryParams['type'] = TerritoryTypes::CIRCLE;
 $territoryParams['data'] = array(
-    "37.569752822786455,-77.47833251953125",
-    "5000"
+	"37.569752822786455,-77.47833251953125",
+	"5000"
 );
 
 $TerritoryParameters = Territory::fromArray(array(
-    "territory_name"  => "Test Territory ".strval(rand(10000, 99999)),
-    "territory_color" => "ff7700",
-    "territory"       => $territoryParams
+	"territory_name"  => "Test Territory ".strval(rand(10000, 99999)),
+	"territory_color" => "ff7700",
+	"territory"       => $territoryParams
 ));
 
 $result = (array)$territory->addTerritory($TerritoryParameters);
@@ -38,18 +38,18 @@  discard block
 block discarded – undo
 
 // Update territory
 $territoryParameters = array (
-    "type" => TerritoryTypes::RECT,
-    "data" => array(
-        "29.6600127358956,-95.6593322753906",
-        "29.8966150753098,-95.3146362304688"
-       )
+	"type" => TerritoryTypes::RECT,
+	"data" => array(
+		"29.6600127358956,-95.6593322753906",
+		"29.8966150753098,-95.3146362304688"
+	   )
    );
 
 $TerritoryParameters = Territory::fromArray(array(
-    "territory_id"     => $territory_id,
-    "territory_name"   => "Test Territory Updated as rectangle",
-    "territory_color"  => "ff5500",
-    "territory"        => $territoryParameters
+	"territory_id"     => $territory_id,
+	"territory_name"   => "Test Territory Updated as rectangle",
+	"territory_color"  => "ff5500",
+	"territory"        => $territoryParameters
 ));
 
 $result1 = $territory->updateTerritory($TerritoryParameters);

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -37,7 +37,7 @@
		block discarded – undo
37	37	echo "---------------------------------------------------------------<br><br>";
38	38
39	39	// Update territory
40		-$territoryParameters = array (
	40	+$territoryParameters = array(
41	41	"type" => TerritoryTypes::RECT,
42	42	"data" => array(
43	43	"29.6600127358956,-95.6593322753906",

Please login to merge, or discard this patch.

examples/Territories/CreatePolygonianTerritory.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

		@@ -16,21 +16,21 @@
		block discarded – undo
16	16
17	17	$territoryParams['type'] = TerritoryTypes::POLY;
18	18	$territoryParams['data'] = array(
19		- "37.769752822786455,-77.67833251953125",
20		- "37.75886716305343,-77.68974800109863",
21		- "37.74763966054455,-77.6917221069336",
22		- "37.74655084306813,-77.68863220214844",
23		- "37.7502255383101,-77.68125076293945",
24		- "37.74797991274437,-77.67498512268066",
25		- "37.73327960206065,-77.6411678314209",
26		- "37.74430510679532,-77.63172645568848",
27		- "37.76641925847049,-77.66846199035645"
	19	+ "37.769752822786455,-77.67833251953125",
	20	+ "37.75886716305343,-77.68974800109863",
	21	+ "37.74763966054455,-77.6917221069336",
	22	+ "37.74655084306813,-77.68863220214844",
	23	+ "37.7502255383101,-77.68125076293945",
	24	+ "37.74797991274437,-77.67498512268066",
	25	+ "37.73327960206065,-77.6411678314209",
	26	+ "37.74430510679532,-77.63172645568848",
	27	+ "37.76641925847049,-77.66846199035645"
28	28	);
29	29
30	30	$TerritoryParameters = Territory::fromArray(array(
31		- "territory_name" => "Test Polygonian Territory ".strval(rand(10000, 99999)),
32		- "territory_color" => "ff7700",
33		- "territory" => $territoryParams
	31	+ "territory_name" => "Test Polygonian Territory ".strval(rand(10000, 99999)),
	32	+ "territory_color" => "ff7700",
	33	+ "territory" => $territoryParams
34	34	));
35	35
36	36	$territory = new Territory();

Please login to merge, or discard this patch.

examples/Territories/GetTerritory.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -18,14 +18,14 @@  discard block
 block discarded – undo
 
 $territoryParams['type'] = TerritoryTypes::CIRCLE;
 $territoryParams['data'] = array(
-    "37.569752822786455,-77.47833251953125",
-    "5000"
+	"37.569752822786455,-77.47833251953125",
+	"5000"
 );
 
 $TerritoryParameters = Territory::fromArray(array(
-    "territory_name"   => "Test Territory ".strval(rand(10000, 99999)),
-    "territory_color"  => "ff7700",
-    "territory"        => $territoryParams
+	"territory_name"   => "Test Territory ".strval(rand(10000, 99999)),
+	"territory_color"  => "ff7700",
+	"territory"        => $territoryParams
 ));
 
 $territory = new Territory();
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 echo "---------------------------------------------------------------<br><br>";
 
 $params = array(
-    "territory_id" => $territory_id
+	"territory_id" => $territory_id
 );
 
 $result1 = $territory->getTerritory($params);

Please login to merge, or discard this patch.

GitHub Access Token became invalid

Push — master ( d70a9b...6b18d7 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

		@@ -34,8 +34,8 @@
		block discarded – undo
34	34
35	35	// Update existing configuration key data
36	36	$params = Member::fromArray(array (
37		- "config_key" => $randomKey,
38		- "config_value" => $randomValue." Updated"
	37	+ "config_key" => $randomKey,
	38	+ "config_value" => $randomValue." Updated"
39	39	));
40	40
41	41	$response = $member->updateMemberConfigKey($params);

		@@ -18,7 +18,7 @@ discard block
		block discarded – undo
18	18	$member = new Member();
19	19
20	20	// Get a random member config key
21		-$randomParams = Member::fromArray(array ( ));
	21	+$randomParams = Member::fromArray(array( ));
22	22
23	23	$response = $member->getMemberConfigData($randomParams);
24	24
		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	echo "Random key -> $randomKey, random value -> $randomValue <br><br>";
34	34
35	35	// Update existing configuration key data
36		-$params = Member::fromArray(array (
	36	+$params = Member::fromArray(array(
37	37	"config_key" => $randomKey,
38	38	"config_value" => $randomValue." Updated"
39	39	));

		@@ -32,15 +32,15 @@
		block discarded – undo
32	32	echo "randomKey -> $randomKey <br><br>";
33	33
34	34	$params = Member::fromArray(array (
35		- "config_key" => $randomKey
	35	+ "config_key" => $randomKey
36	36	));
37	37
38	38	$response = $member->getMemberConfigData($params);
39	39
40	40	foreach ($response as $key => $value) {
41		- if (is_array($value)) {
42		- Route4Me::simplePrint($value);
43		- } else {
44		- echo "$key => $value <br>";
45		- }
	41	+ if (is_array($value)) {
	42	+ Route4Me::simplePrint($value);
	43	+ } else {
	44	+ echo "$key => $value <br>";
	45	+ }
46	46	}

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2	namespace Route4Me;
3	3
4		-$root=realpath(dirname(__FILE__).'/../../');
	4	+$root = realpath(dirname(__FILE__).'/../../');
5	5	require $root.'/vendor/autoload.php';
6	6
7	7	use Route4Me\Route4Me;

		@@ -25,13 +25,13 @@ discard block
		block discarded – undo
25	25	$count = 0;
26	26
27	27	while ($route_id1==$route_id2) {
28		- $route_id2 = $route->getRandomRouteId(0, 20);
	28	+ $route_id2 = $route->getRandomRouteId(0, 20);
29	29
30		- $count++;
	30	+ $count++;
31	31
32		- if ($count>5) {
33		- break;
34		- }
	32	+ if ($count>5) {
	33	+ break;
	34	+ }
35	35	}
36	36
37	37	echo "Route ID 1 -> $route_id1 <br> Route ID 2 -> $route_id2 <br>";
		@@ -43,21 +43,21 @@ discard block
		block discarded – undo
43	43	$depot = null;
44	44
45	45	foreach ($addresses as $address) {
46		- if (isset($address->is_depot)) {
47		- if ($address->is_depot==true) {
48		- $depot = $address;
49		- break;
50		- }
51		- }
	46	+ if (isset($address->is_depot)) {
	47	+ if ($address->is_depot==true) {
	48	+ $depot = $address;
	49	+ break;
	50	+ }
	51	+ }
52	52	}
53	53
54	54	// Merge the selected routes
55	55	$params = array(
56		- "route_ids" => $route_id1.",".$route_id2,
57		- "depot_address" => $depot->address,
58		- "remove_origin" => false,
59		- "depot_lat" => $depot->lat,
60		- "depot_lat" => $depot->lng
	56	+ "route_ids" => $route_id1.",".$route_id2,
	57	+ "depot_address" => $depot->address,
	58	+ "remove_origin" => false,
	59	+ "depot_lat" => $depot->lat,
	60	+ "depot_lat" => $depot->lng
61	61	);
62	62
63	63	$result = $route->mergeRoutes($params);

		@@ -18,14 +18,14 @@
		block discarded – undo
18	18
19	19	$territoryParams['type'] = TerritoryTypes::CIRCLE;
20	20	$territoryParams['data'] = array(
21		- "37.569752822786455,-77.47833251953125",
22		- "5000"
	21	+ "37.569752822786455,-77.47833251953125",
	22	+ "5000"
23	23	);
24	24
25	25	$TerritoryParameters = Territory::fromArray(array(
26		- "territory_name" => "Test Territory ".strval(rand(10000, 99999)),
27		- "territory_color" => "ff7700",
28		- "territory" => $territoryParams
	26	+ "territory_name" => "Test Territory ".strval(rand(10000, 99999)),
	27	+ "territory_color" => "ff7700",
	28	+ "territory" => $territoryParams
29	29	));
30	30
31	31	$territory = new Territory();

		@@ -16,14 +16,14 @@
		block discarded – undo
16	16
17	17	$territoryParams['type'] = TerritoryTypes::RECT;
18	18	$territoryParams['data'] = array(
19		- "43.51668853502909,-109.3798828125",
20		- "46.98025235521883,-101.865234375"
	19	+ "43.51668853502909,-109.3798828125",
	20	+ "46.98025235521883,-101.865234375"
21	21	);
22	22
23	23	$TerritoryParameters = Territory::fromArray(array(
24		- "territory_name" => "Test Rectangular Territory ".strval(rand(10000, 99999)),
25		- "territory_color" => "ff7700",
26		- "territory" => $territoryParams
	24	+ "territory_name" => "Test Rectangular Territory ".strval(rand(10000, 99999)),
	25	+ "territory_color" => "ff7700",
	26	+ "territory" => $territoryParams
27	27	));
28	28
29	29	$territory = new Territory();

		@@ -18,14 +18,14 @@ discard block
		block discarded – undo
18	18
19	19	$territoryParams['type'] = TerritoryTypes::CIRCLE;
20	20	$territoryParams['data'] = array(
21		- "37.569752822786455,-77.47833251953125",
22		- "5000"
	21	+ "37.569752822786455,-77.47833251953125",
	22	+ "5000"
23	23	);
24	24
25	25	$TerritoryParameters = Territory::fromArray(array(
26		- "territory_name" => "Test Territory ".strval(rand(10000, 99999)),
27		- "territory_color" => "ff7700",
28		- "territory" => $territoryParams
	26	+ "territory_name" => "Test Territory ".strval(rand(10000, 99999)),
	27	+ "territory_color" => "ff7700",
	28	+ "territory" => $territoryParams
29	29	));
30	30
31	31	$result = (array)$territory->addTerritory($TerritoryParameters);
		@@ -38,18 +38,18 @@ discard block
		block discarded – undo
38	38
39	39	// Update territory
40	40	$territoryParameters = array (
41		- "type" => TerritoryTypes::RECT,
42		- "data" => array(
43		- "29.6600127358956,-95.6593322753906",
44		- "29.8966150753098,-95.3146362304688"
45		- )
	41	+ "type" => TerritoryTypes::RECT,
	42	+ "data" => array(
	43	+ "29.6600127358956,-95.6593322753906",
	44	+ "29.8966150753098,-95.3146362304688"
	45	+ )
46	46	);
47	47
48	48	$TerritoryParameters = Territory::fromArray(array(
49		- "territory_id" => $territory_id,
50		- "territory_name" => "Test Territory Updated as rectangle",
51		- "territory_color" => "ff5500",
52		- "territory" => $territoryParameters
	49	+ "territory_id" => $territory_id,
	50	+ "territory_name" => "Test Territory Updated as rectangle",
	51	+ "territory_color" => "ff5500",
	52	+ "territory" => $territoryParameters
53	53	));
54	54
55	55	$result1 = $territory->updateTerritory($TerritoryParameters);

route4me / route4me-php-sdk

GitHub Access Token became invalid

Push — master ( d70a9b...6b18d7 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch