Issues in number.php (master) - Issues in master - rousnay/lighthouse - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1378)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/acf/fields/number.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
*  ACF Number Field Class
*
*  All the logic for this field type
*
*  @class 		acf_field_number
*  @extends		acf_field
*  @package		ACF
*  @subpackage	Fields
*/

if( ! class_exists('acf_field_number') ) :

class acf_field_number extends acf_field {
	
	
	/*
	*  __construct
	*
	*  This function will setup the field type data
	*
	*  @type	function
	*  @date	5/03/2014
	*  @since	5.0.0
	*
	*  @param	n/a
	*  @return	n/a
	*/

	
	function __construct() {

		
		// vars
		$this->name = 'number';
		$this->label = __("Number",'acf');
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->defaults = array(
			'default_value'	=> '',
			'min'			=> '',
			'max'			=> '',
			'step'			=> '',
			'placeholder'	=> '',
			'prepend'		=> '',
			'append'		=> '',
			'readonly'		=> 0,
			'disabled'		=> 0,
		);
		
		
		// do not delete!
    	parent::__construct();
	}
		
	
	/*
	*  render_field()
	*
	*  Create the HTML interface for your field
	*
	*  @param	$field - an array holding all the field's data
	*
	*  @type	action
	*  @since	3.6
	*  @date	23/01/13
	*/
	
	function render_field( $field ) {

		
		// vars
		$o = array( 'type', 'id', 'class', 'min', 'max', 'step', 'name', 'value', 'placeholder' );
		$e = '';
		
		
		// step
		if( !$field['step'] ) {
		
			$field['step'] = 'any';
			
		}
		
		
		// prepend
		if( $field['prepend'] !== "" ) {

		
			$field['class'] .= ' acf-is-prepended';
			$e .= '<div class="acf-input-prepend">' . $field['prepend'] . '</div>';
			
		}
		
		
		// append
		if( $field['append'] !== "" ) {

		
			$field['class'] .= ' acf-is-appended';
			$e .= '<div class="acf-input-append">' . $field['append'] . '</div>';
			
		}
		
		
		// populate atts
		$atts = array();
		foreach( $o as $k ) {
		
			$atts[ $k ] = $field[ $k ];	
			
		}
		
		
		// special atts
		foreach( array( 'readonly', 'disabled' ) as $k ) {

		
			if( $field[ $k ] ) {
			
				$atts[ $k ] = $k;
				
			}
			
		}
		
		
		// render
		$e .= '<div class="acf-input-wrap">';
		$e .= '<input ' . acf_esc_attr( $atts ) . ' />';
		$e .= '</div>';
		
		
		// return
		echo $e;
		
	}
	
	
	/*
	*  render_field_settings()
	*
	*  Create extra options for your field. This is rendered when editing a field.
	*  The value of $field['name'] can be used (like bellow) to save extra data to the $field
	*
	*  @type	action
	*  @since	3.6
	*  @date	23/01/13
	*
	*  @param	$field	- an array holding all the field's data
	*/
	
	function render_field_settings( $field ) {

		
		// default_value
		acf_render_field_setting( $field, array(
			'label'			=> __('Default Value','acf'),
			'instructions'	=> __('Appears when creating a new post','acf'),
			'type'			=> 'text',
			'name'			=> 'default_value',
		));
		
		
		// placeholder
		acf_render_field_setting( $field, array(
			'label'			=> __('Placeholder Text','acf'),
			'instructions'	=> __('Appears within the input','acf'),
			'type'			=> 'text',
			'name'			=> 'placeholder',
		));
		
		
		// prepend
		acf_render_field_setting( $field, array(
			'label'			=> __('Prepend','acf'),
			'instructions'	=> __('Appears before the input','acf'),
			'type'			=> 'text',
			'name'			=> 'prepend',
		));
		
		
		// append
		acf_render_field_setting( $field, array(
			'label'			=> __('Append','acf'),
			'instructions'	=> __('Appears after the input','acf'),
			'type'			=> 'text',
			'name'			=> 'append',
		));
		
		
		// min
		acf_render_field_setting( $field, array(
			'label'			=> __('Minimum Value','acf'),
			'instructions'	=> '',
			'type'			=> 'number',
			'name'			=> 'min',
		));
		
		
		// max
		acf_render_field_setting( $field, array(
			'label'			=> __('Maximum Value','acf'),
			'instructions'	=> '',
			'type'			=> 'number',
			'name'			=> 'max',
		));
		
		
		// max
		acf_render_field_setting( $field, array(
			'label'			=> __('Step Size','acf'),
			'instructions'	=> '',
			'type'			=> 'number',
			'name'			=> 'step',
		));
		
	}
	
	
	/*
	*  validate_value
	*
	*  description
	*
	*  @type	function
	*  @date	11/02/2014
	*  @since	5.0.0
	*
	*  @param	$post_id (int)
	*  @return	$post_id (int)
	*/

	
	function validate_value( $valid, $value, $field, $input ){

		
		// remove ','
		if( acf_str_exists(',', $value) ) {
			
			$value = str_replace(',', '', $value);
			
		}
				
		
		// if value is not numeric...
		if( !is_numeric($value) ) {
			
			// allow blank to be saved
			if( !empty($value) ) {
				
				$valid = __('Value must be a number', 'acf');
				
			}
			
			
			// return early
			return $valid;
			
		}
		
		
		// convert
		$value = floatval($value);
		
		
		// min
		if( is_numeric($field['min']) && $value < floatval($field['min'])) {

			
			$valid = sprintf(__('Value must be equal to or higher than %d', 'acf'), $field['min'] );
			
		}
		
		
		// max
		if( is_numeric($field['max']) && $value > floatval($field['max']) ) {

			
			$valid = sprintf(__('Value must be equal to or lower than %d', 'acf'), $field['max'] );
			
		}
		
		
		// return		
		return $valid;
		
	}
	
	
	/*
	*  update_value()
	*
	*  This filter is appied to the $value before it is updated in the db
	*
	*  @type	filter
	*  @since	3.6
	*  @date	23/01/13
	*
	*  @param	$value - the value which will be saved in the database
	*  @param	$field - the field array holding all the field options
	*  @param	$post_id - the $post_id of which the value will be saved
	*
	*  @return	$value - the modified value
	*/

	
	function update_value( $value, $post_id, $field ) {

		
		// no formatting needed for empty value
		if( empty($value) ) {
			
			return $value;
			
		}
		
		
		// remove ','
		if( acf_str_exists(',', $value) ) {
			
			$value = str_replace(',', '', $value);
			
		}
		
		
		// return
		return $value;
	}
	
	
}

new acf_field_number();

endif;

?>



1		<?php
2
3		/*
4		* ACF Number Field Class
5		*
6		* All the logic for this field type
7		*
8		* @class acf_field_number
9		* @extends acf_field
10		* @package ACF
11		* @subpackage Fields
12		*/
13
14		if( ! class_exists('acf_field_number') ) :
15
16		class acf_field_number extends acf_field {
17
18
19		/*
20		* __construct
21		*
22		* This function will setup the field type data
23		*
24		* @type function
25		* @date 5/03/2014
26		* @since 5.0.0
27		*
28		* @param n/a
29		* @return n/a
30		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `n/a` could not be parsed: Unknown type name "n/a" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
31
32		function __construct() {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
33
34		// vars
35		$this->name = 'number';
36		$this->label = __("Number",'acf');
		0 ignored issues – show Bug introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `label` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37		$this->defaults = array(
38		'default_value' => '',
39		'min' => '',
40		'max' => '',
41		'step' => '',
42		'placeholder' => '',
43		'prepend' => '',
44		'append' => '',
45		'readonly' => 0,
46		'disabled' => 0,
47		);
48
49
50		// do not delete!
51		parent::__construct();
52		}
53
54
55		/*
56		* render_field()
57		*
58		* Create the HTML interface for your field
59		*
60		* @param $field - an array holding all the field's data
61		*
62		* @type action
63		* @since 3.6
64		* @date 23/01/13
65		*/
66
67		function render_field( $field ) {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
68
69		// vars
70		$o = array( 'type', 'id', 'class', 'min', 'max', 'step', 'name', 'value', 'placeholder' );
71		$e = '';
72
73
74		// step
75		if( !$field['step'] ) {
76
77		$field['step'] = 'any';
78
79		}
80
81
82		// prepend
83	View Code Duplication	if( $field['prepend'] !== "" ) {
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84
85		$field['class'] .= ' acf-is-prepended';
86		$e .= '<div class="acf-input-prepend">' . $field['prepend'] . '</div>';
87
88		}
89
90
91		// append
92	View Code Duplication	if( $field['append'] !== "" ) {
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93
94		$field['class'] .= ' acf-is-appended';
95		$e .= '<div class="acf-input-append">' . $field['append'] . '</div>';
96
97		}
98
99
100		// populate atts
101		$atts = array();
102		foreach( $o as $k ) {
103
104		$atts[ $k ] = $field[ $k ];
105
106		}
107
108
109		// special atts
110	View Code Duplication	foreach( array( 'readonly', 'disabled' ) as $k ) {
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111
112		if( $field[ $k ] ) {
113
114		$atts[ $k ] = $k;
115
116		}
117
118		}
119
120
121		// render
122		$e .= '<div class="acf-input-wrap">';
123		$e .= '<input ' . acf_esc_attr( $atts ) . ' />';
124		$e .= '</div>';
125
126
127		// return
128		echo $e;
129
130		}
131
132
133		/*
134		* render_field_settings()
135		*
136		* Create extra options for your field. This is rendered when editing a field.
137		* The value of $field['name'] can be used (like bellow) to save extra data to the $field
138		*
139		* @type action
140		* @since 3.6
141		* @date 23/01/13
142		*
143		* @param $field - an array holding all the field's data
144		*/
145
146		function render_field_settings( $field ) {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
147
148		// default_value
149		acf_render_field_setting( $field, array(
150		'label' => __('Default Value','acf'),
151		'instructions' => __('Appears when creating a new post','acf'),
152		'type' => 'text',
153		'name' => 'default_value',
154		));
155
156
157		// placeholder
158		acf_render_field_setting( $field, array(
159		'label' => __('Placeholder Text','acf'),
160		'instructions' => __('Appears within the input','acf'),
161		'type' => 'text',
162		'name' => 'placeholder',
163		));
164
165
166		// prepend
167		acf_render_field_setting( $field, array(
168		'label' => __('Prepend','acf'),
169		'instructions' => __('Appears before the input','acf'),
170		'type' => 'text',
171		'name' => 'prepend',
172		));
173
174
175		// append
176		acf_render_field_setting( $field, array(
177		'label' => __('Append','acf'),
178		'instructions' => __('Appears after the input','acf'),
179		'type' => 'text',
180		'name' => 'append',
181		));
182
183
184		// min
185		acf_render_field_setting( $field, array(
186		'label' => __('Minimum Value','acf'),
187		'instructions' => '',
188		'type' => 'number',
189		'name' => 'min',
190		));
191
192
193		// max
194		acf_render_field_setting( $field, array(
195		'label' => __('Maximum Value','acf'),
196		'instructions' => '',
197		'type' => 'number',
198		'name' => 'max',
199		));
200
201
202		// max
203		acf_render_field_setting( $field, array(
204		'label' => __('Step Size','acf'),
205		'instructions' => '',
206		'type' => 'number',
207		'name' => 'step',
208		));
209
210		}
211
212
213		/*
214		* validate_value
215		*
216		* description
217		*
218		* @type function
219		* @date 11/02/2014
220		* @since 5.0.0
221		*
222		* @param $post_id (int)
223		* @return $post_id (int)
224		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `$post_id` could not be parsed: Unknown type name "$post_id" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
225
226		function validate_value( $valid, $value, $field, $input ){
		0 ignored issues – show Unused Code introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$input` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
227
228		// remove ','
229		if( acf_str_exists(',', $value) ) {
230
231		$value = str_replace(',', '', $value);
232
233		}
234
235
236		// if value is not numeric...
237		if( !is_numeric($value) ) {
238
239		// allow blank to be saved
240		if( !empty($value) ) {
241
242		$valid = __('Value must be a number', 'acf');
243
244		}
245
246
247		// return early
248		return $valid;
249
250		}
251
252
253		// convert
254		$value = floatval($value);
255
256
257		// min
258	View Code Duplication	if( is_numeric($field['min']) && $value < floatval($field['min'])) {
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
259
260		$valid = sprintf(__('Value must be equal to or higher than %d', 'acf'), $field['min'] );
261
262		}
263
264
265		// max
266	View Code Duplication	if( is_numeric($field['max']) && $value > floatval($field['max']) ) {
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
267
268		$valid = sprintf(__('Value must be equal to or lower than %d', 'acf'), $field['max'] );
269
270		}
271
272
273		// return
274		return $valid;
275
276		}
277
278
279		/*
280		* update_value()
281		*
282		* This filter is appied to the $value before it is updated in the db
283		*
284		* @type filter
285		* @since 3.6
286		* @date 23/01/13
287		*
288		* @param $value - the value which will be saved in the database
289		* @param $field - the field array holding all the field options
290		* @param $post_id - the $post_id of which the value will be saved
291		*
292		* @return $value - the modified value
293		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `$value` could not be parsed: Unknown type name "$value" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
294
295		function update_value( $value, $post_id, $field ) {
		0 ignored issues – show Unused Code introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$post_id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$field` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
296
297		// no formatting needed for empty value
298		if( empty($value) ) {
299
300		return $value;
301
302		}
303
304
305		// remove ','
306		if( acf_str_exists(',', $value) ) {
307
308		$value = str_replace(',', '', $value);
309
310		}
311
312
313		// return
314		return $value;
315		}
316
317
318		}
319
320		new acf_field_number();
321
322		endif;
323
324		?>
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
325

rousnay / lighthouse

Issues (1378)

Security Analysis not enabled

includes/acf/fields/number.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like