Inspection of "Footer widgets and styles improved" - rousnay/lighthouse - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a3d2e0...534616 )

by Md. Mozahidur

created 2015-12-24 15:56 UTC

Status

Braces +4 added lines, -2 removed lines patch added patch discarded remove patch

@@ -62,8 +62,10 @@
 block discarded – undo
  
                 $tax_links = join( " ", str_replace(' ', '-', $links));          
                 $tax = strtolower($tax_links);
-            else :  
-          $tax = '';          
+            else {
+            	:  
+          $tax = '';
+            }
             endif; ?>
  
         <div class="all blog-item <?php echo $tax; ?>">

Please login to merge, or discard this patch.

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@  discard block
 block discarded – undo
 <?php
 /**
- * Template Name: Blog
- *
- * @package Lighthouse
- */
+		 * Template Name: Blog
+		 *
+		 * @package Lighthouse
+		 */
 get_header(); ?>
     <div class="title-area">
     <h1 class="page-title">Blog</h1>
@@ -41,37 +41,37 @@  discard block
 block discarded – undo
                 }
             }
             echo '<li><a href="javascript:void(0)" title="" data-filter=".all" class="active">All</a></li>';
-        **/ ?>
+		 **/ ?>
     </ul>
 
 
 <div id="blogContent">
               <?php 
-       $args = array( 'post_type' => 'post', 'posts_per_page' => -1 );
-       $loop = new WP_Query( $args );
-         while ( $loop->have_posts() ) : $loop->the_post(); 
+	   $args = array( 'post_type' => 'post', 'posts_per_page' => -1 );
+	   $loop = new WP_Query( $args );
+		 while ( $loop->have_posts() ) : $loop->the_post(); 
  
-       $terms = get_the_terms( $post->ID, 'category' );           
-            if ( $terms && ! is_wp_error( $terms ) ) : 
+	   $terms = get_the_terms( $post->ID, 'category' );           
+			if ( $terms && ! is_wp_error( $terms ) ) : 
  
-                $links = array();
+				$links = array();
  
-                foreach ( $terms as $term ) {
-                    $links[] = $term->name;
-                }
+				foreach ( $terms as $term ) {
+					$links[] = $term->name;
+				}
  
-                $tax_links = join( " ", str_replace(' ', '-', $links));          
-                $tax = strtolower($tax_links);
-            else :  
-          $tax = '';          
-            endif; ?>
+				$tax_links = join( " ", str_replace(' ', '-', $links));          
+				$tax = strtolower($tax_links);
+			else :  
+		  $tax = '';          
+			endif; ?>
  
         <div class="all blog-item <?php echo $tax; ?>">
         <a href="<?php the_permalink() ?>" title="<?php  the_title_attribute() ?>">
           <?php
-          $thumb = wp_get_attachment_image_src( get_post_thumbnail_id(), 'blog-listing');
-          $url = $thumb[0];
-          ?>
+		  $thumb = wp_get_attachment_image_src( get_post_thumbnail_id(), 'blog-listing');
+		  $url = $thumb[0];
+		  ?>
         <div class="thumbnail blog-item-img load-fadeInUp" style="background-image:url('<?php echo $url; ?>'); background-color:<?php the_field('post_background_color'); ?>">
           <img class="img-responsive" src="<?php echo $url; ?>">
         </div>

Please login to merge, or discard this patch.

header.php 2 patches

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -29,8 +29,11 @@
 block discarded – undo
 			<?php
 			if ( is_front_page() && is_home() ) : ?>
 				<h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
-			<?php else : ?>
-				<p class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></p>
+			<?php else {
+	: ?>
+				<p class="site-title"><a href="<?php echo esc_url( home_url( '/' ) );
+}
+?>" rel="home"><?php bloginfo( 'name' ); ?></a></p>
 			<?php
 			endif;
 

Please login to merge, or discard this patch.

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * The header for our theme.
- *
- * This is the template that displays all of the <head> section and everything up until <div id="content">
- *
- * @link https://developer.wordpress.org/themes/basics/template-files/#template-partials
- *
- * @package Lighthouse
- */
+					 * The header for our theme.
+					 *
+					 * This is the template that displays all of the <head> section and everything up until <div id="content">
+					 *
+					 * @link https://developer.wordpress.org/themes/basics/template-files/#template-partials
+					 *
+					 * @package Lighthouse
+					 */
 
 ?><!DOCTYPE html>
 <html <?php language_attributes(); ?>>

Please login to merge, or discard this patch.

template-parts/content-none.php 1 patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -26,9 +26,12 @@
 block discarded – undo
 			<?php
 				get_search_form();
 
-		else : ?>
+		else {
+			: ?>
 
-			<p><?php esc_html_e( 'It seems we can&rsquo;t find what you&rsquo;re looking for. Perhaps searching can help.', 'lighthouse' ); ?></p>
+			<p><?php esc_html_e( 'It seems we can&rsquo;t find what you&rsquo;re looking for. Perhaps searching can help.', 'lighthouse' );
+		}
+		?></p>
 			<?php
 				get_search_form();
 

Please login to merge, or discard this patch.

template-parts/content-search.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * Template part for displaying results in search pages.
- *
- * @link https://codex.wordpress.org/Template_Hierarchy
- *
- * @package Lighthouse
- */
+		 * Template part for displaying results in search pages.
+		 *
+		 * @link https://codex.wordpress.org/Template_Hierarchy
+		 *
+		 * @package Lighthouse
+		 */
 
 ?>
 

Please login to merge, or discard this patch.

comments.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * The template for displaying comments.
- *
- * This is the template that displays the area of the page that contains both the current comments
- * and the comment form.
- *
- * @link https://codex.wordpress.org/Template_Hierarchy
- *
- * @package Lighthouse
- */
+		 * The template for displaying comments.
+		 *
+		 * This is the template that displays the area of the page that contains both the current comments
+		 * and the comment form.
+		 *
+		 * @link https://codex.wordpress.org/Template_Hierarchy
+		 *
+		 * @package Lighthouse
+		 */
 
 /*
  * If the current post is protected by a password and

Please login to merge, or discard this patch.

inc/customizer.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,9 +1,9 @@
 block discarded – undo
 <?php
 /**
- * Lighthouse Theme Customizer.
- *
- * @package Lighthouse
- */
+	 * Lighthouse Theme Customizer.
+	 *
+	 * @package Lighthouse
+	 */
 
 /**
  * Add postMessage support for site title and description for the Theme Customizer.

Please login to merge, or discard this patch.

inc/jetpack.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * Jetpack Compatibility File.
- *
- * @link https://jetpack.me/
- *
- * @package Lighthouse
- */
+	 * Jetpack Compatibility File.
+	 *
+	 * @link https://jetpack.me/
+	 *
+	 * @package Lighthouse
+	 */
 
 /**
  * Jetpack setup function.
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
 	while ( have_posts() ) {
 		the_post();
 		if ( is_search() ) :
-		    get_template_part( 'template-parts/content', 'search' );
+			get_template_part( 'template-parts/content', 'search' );
 		else :
-		    get_template_part( 'template-parts/content', get_post_format() );
+			get_template_part( 'template-parts/content', get_post_format() );
 		endif;
 	}
 }

Please login to merge, or discard this patch.

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,8 +34,10 @@
 block discarded – undo
 		the_post();
 		if ( is_search() ) :
 		    get_template_part( 'template-parts/content', 'search' );
-		else :
+		else {
+			:
 		    get_template_part( 'template-parts/content', get_post_format() );
+		}
 		endif;
 	}
 }

Please login to merge, or discard this patch.

inc/custom-header.php 2 patches

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,19 +1,19 @@
 block discarded – undo
 <?php
 /**
- * Sample implementation of the Custom Header feature.
- *
- * You can add an optional custom header image to header.php like so ...
- *
+	 * Sample implementation of the Custom Header feature.
+	 *
+	 * You can add an optional custom header image to header.php like so ...
+	 *
 	<?php if ( get_header_image() ) : ?>
 	<a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home">
 		<img src="<?php header_image(); ?>" width="<?php echo esc_attr( get_custom_header()->width ); ?>" height="<?php echo esc_attr( get_custom_header()->height ); ?>" alt="">
 	</a>
 	<?php endif; // End header image check. ?>
- *
- * @link https://developer.wordpress.org/themes/functionality/custom-headers/
- *
- * @package Lighthouse
- */
+	 *
+	 * @link https://developer.wordpress.org/themes/functionality/custom-headers/
+	 *
+	 * @package Lighthouse
+	 */
 
 /**
  * Set up the WordPress core custom header feature.

Please login to merge, or discard this patch.

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -63,11 +63,14 @@
 block discarded – undo
 		}
 	<?php
 		// If the user has set a custom color for the text use that.
-		else :
+		else {
+			:
 	?>
 		.site-title a,
 		.site-description {
-			color: #<?php echo esc_attr( $header_text_color ); ?>;
+			color: #<?php echo esc_attr( $header_text_color );
+		}
+		?>;
 		}
 	<?php endif; ?>
 	</style>

Please login to merge, or discard this patch.

functions.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- * Lighthouse functions and definitions.
- *
- * @link https://developer.wordpress.org/themes/basics/theme-functions/
- *
- * @package Lighthouse
- */
+	 * Lighthouse functions and definitions.
+	 *
+	 * @link https://developer.wordpress.org/themes/basics/theme-functions/
+	 *
+	 * @package Lighthouse
+	 */
 
 if ( ! function_exists( 'lighthouse_setup' ) ) :
 /**

Please login to merge, or discard this patch.

		@@ -63,11 +63,14 @@
		block discarded – undo
63	63	}
64	64	<?php
65	65	// If the user has set a custom color for the text use that.
66		- else :
	66	+ else {
	67	+ :
67	68	?>
68	69	.site-title a,
69	70	.site-description {
70		- color: #<?php echo esc_attr( $header_text_color ); ?>;
	71	+ color: #<?php echo esc_attr( $header_text_color );
	72	+ }
	73	+ ?>;
71	74	}
72	75	<?php endif; ?>
73	76	</style>

		@@ -62,8 +62,10 @@
		block discarded – undo
62	62
63	63	$tax_links = join( " ", str_replace(' ', '-', $links));
64	64	$tax = strtolower($tax_links);
65		- else :
66		- $tax = '';
	65	+ else {
	66	+ :
	67	+ $tax = '';
	68	+ }
67	69	endif; ?>
68	70
69	71	<div class="all blog-item <?php echo $tax; ?>">

		@@ -1,9 +1,9 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Template Name: Blog
4		- *
5		- * @package Lighthouse
6		- */
	3	+ * Template Name: Blog
	4	+ *
	5	+ * @package Lighthouse
	6	+ */
7	7	get_header(); ?>
8	8	<div class="title-area">
9	9	<h1 class="page-title">Blog</h1>
		@@ -41,37 +41,37 @@ discard block
		block discarded – undo
41	41	}
42	42	}
43	43	echo '<li><a href="javascript:void(0)" title="" data-filter=".all" class="active">All</a></li>';
44		- **/ ?>
	44	+ **/ ?>
45	45	</ul>
46	46
47	47
48	48	<div id="blogContent">
49	49	<?php
50		- $args = array( 'post_type' => 'post', 'posts_per_page' => -1 );
51		- $loop = new WP_Query( $args );
52		- while ( $loop->have_posts() ) : $loop->the_post();
	50	+ $args = array( 'post_type' => 'post', 'posts_per_page' => -1 );
	51	+ $loop = new WP_Query( $args );
	52	+ while ( $loop->have_posts() ) : $loop->the_post();
53	53
54		- $terms = get_the_terms( $post->ID, 'category' );
55		- if ( $terms && ! is_wp_error( $terms ) ) :
	54	+ $terms = get_the_terms( $post->ID, 'category' );
	55	+ if ( $terms && ! is_wp_error( $terms ) ) :
56	56
57		- $links = array();
	57	+ $links = array();
58	58
59		- foreach ( $terms as $term ) {
60		- $links[] = $term->name;
61		- }
	59	+ foreach ( $terms as $term ) {
	60	+ $links[] = $term->name;
	61	+ }
62	62
63		- $tax_links = join( " ", str_replace(' ', '-', $links));
64		- $tax = strtolower($tax_links);
65		- else :
66		- $tax = '';
67		- endif; ?>
	63	+ $tax_links = join( " ", str_replace(' ', '-', $links));
	64	+ $tax = strtolower($tax_links);
	65	+ else :
	66	+ $tax = '';
	67	+ endif; ?>
68	68
69	69	<div class="all blog-item <?php echo $tax; ?>">
70	70	<a href="<?php the_permalink() ?>" title="<?php the_title_attribute() ?>">
71	71	<?php
72		- $thumb = wp_get_attachment_image_src( get_post_thumbnail_id(), 'blog-listing');
73		- $url = $thumb[0];
74		- ?>
	72	+ $thumb = wp_get_attachment_image_src( get_post_thumbnail_id(), 'blog-listing');
	73	+ $url = $thumb[0];
	74	+ ?>
75	75	<div class="thumbnail blog-item-img load-fadeInUp" style="background-image:url('<?php echo $url; ?>'); background-color:<?php the_field('post_background_color'); ?>">
76	76	<img class="img-responsive" src="<?php echo $url; ?>">
77	77	</div>

		@@ -29,8 +29,11 @@
		block discarded – undo
29	29	<?php
30	30	if ( is_front_page() && is_home() ) : ?>
31	31	<h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
32		- <?php else : ?>
33		- <p class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></p>
	32	+ <?php else {
	33	+ : ?>
	34	+ <p class="site-title"><a href="<?php echo esc_url( home_url( '/' ) );
	35	+}
	36	+?>" rel="home"><?php bloginfo( 'name' ); ?></a></p>
34	37	<?php
35	38	endif;
36	39

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * The header for our theme.
4		- *
5		- * This is the template that displays all of the <head> section and everything up until <div id="content">
6		- *
7		- * @link https://developer.wordpress.org/themes/basics/template-files/#template-partials
8		- *
9		- * @package Lighthouse
10		- */
	3	+ * The header for our theme.
	4	+ *
	5	+ * This is the template that displays all of the <head> section and everything up until <div id="content">
	6	+ *
	7	+ * @link https://developer.wordpress.org/themes/basics/template-files/#template-partials
	8	+ *
	9	+ * @package Lighthouse
	10	+ */
11	11
12	12	?><!DOCTYPE html>
13	13	<html <?php language_attributes(); ?>>

		@@ -26,9 +26,12 @@
		block discarded – undo
26	26	<?php
27	27	get_search_form();
28	28
29		- else : ?>
	29	+ else {
	30	+ : ?>
30	31
31		- <p><?php esc_html_e( 'It seems we can’t find what you’re looking for. Perhaps searching can help.', 'lighthouse' ); ?></p>
	32	+ <p><?php esc_html_e( 'It seems we can’t find what you’re looking for. Perhaps searching can help.', 'lighthouse' );
	33	+ }
	34	+ ?></p>
32	35	<?php
33	36	get_search_form();
34	37

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Template part for displaying results in search pages.
4		- *
5		- * @link https://codex.wordpress.org/Template_Hierarchy
6		- *
7		- * @package Lighthouse
8		- */
	3	+ * Template part for displaying results in search pages.
	4	+ *
	5	+ * @link https://codex.wordpress.org/Template_Hierarchy
	6	+ *
	7	+ * @package Lighthouse
	8	+ */
9	9
10	10	?>
11	11

		@@ -1,14 +1,14 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * The template for displaying comments.
4		- *
5		- * This is the template that displays the area of the page that contains both the current comments
6		- * and the comment form.
7		- *
8		- * @link https://codex.wordpress.org/Template_Hierarchy
9		- *
10		- * @package Lighthouse
11		- */
	3	+ * The template for displaying comments.
	4	+ *
	5	+ * This is the template that displays the area of the page that contains both the current comments
	6	+ * and the comment form.
	7	+ *
	8	+ * @link https://codex.wordpress.org/Template_Hierarchy
	9	+ *
	10	+ * @package Lighthouse
	11	+ */
12	12
13	13	/*
14	14	* If the current post is protected by a password and

		@@ -1,9 +1,9 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Lighthouse Theme Customizer.
4		- *
5		- * @package Lighthouse
6		- */
	3	+ * Lighthouse Theme Customizer.
	4	+ *
	5	+ * @package Lighthouse
	6	+ */
7	7
8	8	/**
9	9	* Add postMessage support for site title and description for the Theme Customizer.

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Jetpack Compatibility File.
4		- *
5		- * @link https://jetpack.me/
6		- *
7		- * @package Lighthouse
8		- */
	3	+ * Jetpack Compatibility File.
	4	+ *
	5	+ * @link https://jetpack.me/
	6	+ *
	7	+ * @package Lighthouse
	8	+ */
9	9
10	10	/**
11	11	* Jetpack setup function.
		@@ -33,9 +33,9 @@ discard block
		block discarded – undo
33	33	while ( have_posts() ) {
34	34	the_post();
35	35	if ( is_search() ) :
36		- get_template_part( 'template-parts/content', 'search' );
	36	+ get_template_part( 'template-parts/content', 'search' );
37	37	else :
38		- get_template_part( 'template-parts/content', get_post_format() );
	38	+ get_template_part( 'template-parts/content', get_post_format() );
39	39	endif;
40	40	}
41	41	}

		@@ -34,8 +34,10 @@
		block discarded – undo
34	34	the_post();
35	35	if ( is_search() ) :
36	36	get_template_part( 'template-parts/content', 'search' );
37		- else :
	37	+ else {
	38	+ :
38	39	get_template_part( 'template-parts/content', get_post_format() );
	40	+ }
39	41	endif;
40	42	}
41	43	}

		@@ -1,19 +1,19 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Sample implementation of the Custom Header feature.
4		- *
5		- * You can add an optional custom header image to header.php like so ...
6		- *
	3	+ * Sample implementation of the Custom Header feature.
	4	+ *
	5	+ * You can add an optional custom header image to header.php like so ...
	6	+ *
7	7	<?php if ( get_header_image() ) : ?>
8	8	<a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home">
9	9	<img src="<?php header_image(); ?>" width="<?php echo esc_attr( get_custom_header()->width ); ?>" height="<?php echo esc_attr( get_custom_header()->height ); ?>" alt="">
10	10	</a>
11	11	<?php endif; // End header image check. ?>
12		- *
13		- * @link https://developer.wordpress.org/themes/functionality/custom-headers/
14		- *
15		- * @package Lighthouse
16		- */
	12	+ *
	13	+ * @link https://developer.wordpress.org/themes/functionality/custom-headers/
	14	+ *
	15	+ * @package Lighthouse
	16	+ */
17	17
18	18	/**
19	19	* Set up the WordPress core custom header feature.

rousnay / lighthouse

Push — master ( a3d2e0...534616 )

Status

Category

Braces +4 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch