theme-settings.php ➔ pagination() - Code Metrics - Inspection of "Fix for new VC: contact" - rousnay/lighthouse - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af0f5c...e208fb )

by Md. Mozahidur

created 2016-05-28 17:19 UTC

theme-settings.php ➔ pagination() F

↳ Parent: Project

Complexity

Conditions	21
Paths	294

Size

Total Lines	36
Code Lines	19

Duplication

Lines	2
Ratio	5.56 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	21
eloc	19
c	1
b	0
f	0
nc	294
nop	2
dl	2
loc	36
rs	3.6155

How to fix Complexity

<?php 


/**
 * Read More button in excerpt
 */
function new_excerpt_more( $more ) {

	return '... <a class="readmore" href="' . get_permalink() . ' ">Read more <i class="fa fa-external-link"></i></a>';
}

add_filter( 'excerpt_more', 'new_excerpt_more' );

/**
 * Custome Lenght of excerpt
 */
// function custom_excerpt_length( $length ) {

//     return 50;
// }
// add_filter( 'excerpt_length', 'custom_excerpt_length', 999 );


/**
 * Numbered Pagination
 */
function pagination($pages = '', $range = 4)
{  
	$showitems = ($range * 2)+1;  

	global $paged;
function myFunction($a, $b) {
    // Do something
}
	if(empty($paged)) $paged = 1;

	if($pages == '')
	{
		global $wp_query;
function myFunction($a, $b) {
    // Do something
}
		$pages = $wp_query->max_num_pages;
		if(!$pages)
		{
			$pages = 1;
		}
	}   

	if(1 != $pages)
	{
		echo "<div class=\"pagination\"><span>Page ".$paged." of ".$pages."</span>";
		if($paged > 2 && $paged > $range+1 && $showitems < $pages) echo "<a href='".get_pagenum_link(1)."'>&laquo; First</a>";
		if($paged > 1 && $showitems < $pages) echo "<a href='".get_pagenum_link($paged - 1)."'>&lsaquo; Previous</a>";


		for ($i=1; $i <= $pages; $i++)
		{
			if (1 != $pages &&( !($i >= $paged+$range+1 || $i <= $paged-$range-1) || $pages <= $showitems ))
			{
				echo ($paged == $i)? "<span class=\"current\">".$i."</span>":"<a href='".get_pagenum_link($i)."' class=\"inactive\">".$i."</a>";
			}
		}

		if ($paged < $pages && $showitems < $pages) echo "<a href=\"".get_pagenum_link($paged + 1)."\">Next &rsaquo;</a>";  

		if ($paged < $pages-1 &&  $paged+$range-1 < $pages && $showitems < $pages) echo "<a href='".get_pagenum_link($pages)."'>Last &raquo;</a>";
		echo "</div>\n";
	}
}


/**
 * stop wp removing div tags
 */
function tinymce_settings( $settings ) {

    // html elements being stripped
	$settings['extended_valid_elements'] = 'div[*],article[*]';

    // only html elements to keep
    //$settings['valid_elements'] = 'a,strong/b,div,h1,h2,h3,section';


	// paste elements to keep
	//$opts = '*[*]';

	//$settings['paste_word_valid_elements'] = $opts;


    // don't remove line breaks
	//$settings['remove_linebreaks'] = false;


	$settings['allow_html_in_named_anchor'] = true;

    // convert newline characters to BR
	//$settings['convert_newlines_to_brs'] = true;


    // don't remove redundant BR
	//$settings['remove_redundant_brs'] = false;


	// only html elements to keep
	//$settings['wpautop'] = false;


    // pass back to wordpress

	return $settings;
}

add_filter( 'tiny_mce_before_init', 'tinymce_settings' );

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 6 and the first side effect is on line 10. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		/**
4		* Read More button in excerpt
5		*/
6		function new_excerpt_more( $more ) {
		0 ignored issues – show Unused Code introduced 2015-12-31 17:13 UTC by Report Bug Copy Issue Report The parameter `$more` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
7		return '... <a class="readmore" href="' . get_permalink() . ' ">Read more <i class="fa fa-external-link"></i></a>';
8		}
9
10		add_filter( 'excerpt_more', 'new_excerpt_more' );
11
12		/**
13		* Custome Lenght of excerpt
14		*/
15		// function custom_excerpt_length( $length ) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report `49%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16		// return 50;
17		// }
18		// add_filter( 'excerpt_length', 'custom_excerpt_length', 999 );
19
20
21		/**
22		* Numbered Pagination
23		*/
24		function pagination($pages = '', $range = 4)
25		{
26		$showitems = ($range * 2)+1;
27
28		global $paged;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-24 19:13 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
29		if(empty($paged)) $paged = 1;
30
31		if($pages == '')
32		{
33		global $wp_query;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-24 19:13 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
34		$pages = $wp_query->max_num_pages;
35		if(!$pages)
36		{
37		$pages = 1;
38		}
39		}
40
41		if(1 != $pages)
42		{
43		echo "<div class=\"pagination\"><span>Page ".$paged." of ".$pages."</span>";
44		if($paged > 2 && $paged > $range+1 && $showitems < $pages) echo "<a href='".get_pagenum_link(1)."'>« First</a>";
45	View Code Duplication	if($paged > 1 && $showitems < $pages) echo "<a href='".get_pagenum_link($paged - 1)."'>&lsaquo; Previous</a>";
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46
47		for ($i=1; $i <= $pages; $i++)
48		{
49		if (1 != $pages &&( !($i >= $paged+$range+1 \|\| $i <= $paged-$range-1) \|\| $pages <= $showitems ))
50		{
51		echo ($paged == $i)? "<span class=\"current\">".$i."</span>":"<a href='".get_pagenum_link($i)."' class=\"inactive\">".$i."</a>";
52		}
53		}
54
55	View Code Duplication	if ($paged < $pages && $showitems < $pages) echo "<a href=\"".get_pagenum_link($paged + 1)."\">Next &rsaquo;</a>";
		0 ignored issues – show Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		if ($paged < $pages-1 && $paged+$range-1 < $pages && $showitems < $pages) echo "<a href='".get_pagenum_link($pages)."'>Last »</a>";
57		echo "</div>\n";
58		}
59		}
60
61
62		/**
63		* stop wp removing div tags
64		*/
65		function tinymce_settings( $settings ) {
66
67		// html elements being stripped
68		$settings['extended_valid_elements'] = 'div[],article[]';
69
70		// only html elements to keep
71		//$settings['valid_elements'] = 'a,strong/b,div,h1,h2,h3,section';
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
72
73		// paste elements to keep
74		//$opts = '[]';
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
75		//$settings['paste_word_valid_elements'] = $opts;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
76
77		// don't remove line breaks
78		//$settings['remove_linebreaks'] = false;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-12 21:55 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79
80		$settings['allow_html_in_named_anchor'] = true;
81
82		// convert newline characters to BR
83		//$settings['convert_newlines_to_brs'] = true;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-12 21:55 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
84
85		// don't remove redundant BR
86		//$settings['remove_redundant_brs'] = false;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-12 21:55 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
87
88		// only html elements to keep
89		//$settings['wpautop'] = false;
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
90
91		// pass back to wordpress
92
93		return $settings;
94		}
95
96		add_filter( 'tiny_mce_before_init', 'tinymce_settings' );

rousnay / lighthouse

Push — master ( af0f5c...e208fb )

theme-settings.php ➔ pagination() F

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like