acf_settings_addons - Code Metrics - rousnay/lighthouse - Measure and Improve Code Quality continuously with Scrutinizer

acf_settings_addons A
last analyzed 2019-07-26 18:21 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	115
Duplicated Lines	14.78 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	17
loc	115
rs	10
c	0
b	0
f	0
wmc	7
lcom	1
cbo	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	admin_menu()	17	17	2
A	load()	0	22	3
A	html()	0	6	1

How to fix Duplicated Code

<?php

class acf_settings_addons {

	var $view;


	/*
	*  __construct
	*
	*  Initialize filters, action, variables and includes
	*
	*  @type	function
	*  @date	23/06/12
	*  @since	5.0.0
	*
	*  @param	n/a
	*  @return	n/a
	*/


	function __construct() {


		// actions
		add_action( 'admin_menu', 				array( $this, 'admin_menu' ) );
	}


	/*
	*  admin_menu
	*
	*  This function will add the ACF menu item to the WP admin
	*
	*  @type	action (admin_menu)
	*  @date	28/09/13
	*  @since	5.0.0
	*
	*  @param	n/a
	*  @return	n/a
	*/


	function admin_menu() {


		// bail early if no show_admin
		if( !acf_get_setting('show_admin') )
		{
			return;
		}


		// add page
		$page = add_submenu_page('edit.php?post_type=acf-field-group', __('Add-ons','acf'), __('Add-ons','acf'), acf_get_setting('capability'),'acf-settings-addons', array($this,'html') );


		// actions
		add_action('load-' . $page, array($this,'load'));

	}


	/*
	*  load
	*
	*  description
	*
	*  @type	function
	*  @date	7/01/2014
	*  @since	5.0.0
	*
	*  @param	$post_id (int)
	*  @return	$post_id (int)
	*/


	function load() {


		// vars
		$this->view = array(
			'json'		=> array(),
		);


		// load json
        $request = wp_remote_post( 'http://assets.advancedcustomfields.com/add-ons/add-ons.json' );

        // validate
        if( is_wp_error($request) || wp_remote_retrieve_response_code($request) != 200)
        {
        	acf_add_admin_notice(__('<b>Error</b>. Could not load add-ons list', 'acf'), 'error');
        }
        else
        {
	        $this->view['json'] = json_decode( $request['body'], true );
        }

	}


	/*
	*  html
	*
	*  description
	*
	*  @type	function
	*  @date	7/01/2014
	*  @since	5.0.0
	*
	*  @param	$post_id (int)
	*  @return	$post_id (int)
	*/


	function html() {


		// load view
		acf_get_view('settings-addons', $this->view);

	}

}


// initialize
new acf_settings_addons();

?>



1		<?php
2
3		class acf_settings_addons {
4
5		var $view;
6
7
8		/*
9		* __construct
10		*
11		* Initialize filters, action, variables and includes
12		*
13		* @type function
14		* @date 23/06/12
15		* @since 5.0.0
16		*
17		* @param n/a
18		* @return n/a
19		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report The doc-type `n/a` could not be parsed: Unknown type name "n/a" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
20
21		function __construct() {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
22
23		// actions
24		add_action( 'admin_menu', array( $this, 'admin_menu' ) );
25		}
26
27
28		/*
29		* admin_menu
30		*
31		* This function will add the ACF menu item to the WP admin
32		*
33		* @type action (admin_menu)
34		* @date 28/09/13
35		* @since 5.0.0
36		*
37		* @param n/a
38		* @return n/a
39		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report The doc-type `n/a` could not be parsed: Unknown type name "n/a" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
40
41	View Code Duplication	function admin_menu() {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Duplication introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42
43		// bail early if no show_admin
44		if( !acf_get_setting('show_admin') )
45		{
46		return;
47		}
48
49
50		// add page
51		$page = add_submenu_page('edit.php?post_type=acf-field-group', __('Add-ons','acf'), __('Add-ons','acf'), acf_get_setting('capability'),'acf-settings-addons', array($this,'html') );
52
53
54		// actions
55		add_action('load-' . $page, array($this,'load'));
56
57		}
58
59
60		/*
61		* load
62		*
63		* description
64		*
65		* @type function
66		* @date 7/01/2014
67		* @since 5.0.0
68		*
69		* @param $post_id (int)
70		* @return $post_id (int)
71		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report The doc-type `$post_id` could not be parsed: Unknown type name "$post_id" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
72
73		function load() {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
74
75		// vars
76		$this->view = array(
77		'json' => array(),
78		);
79
80
81		// load json
82		$request = wp_remote_post( 'http://assets.advancedcustomfields.com/add-ons/add-ons.json' );
83
84		// validate
85		if( is_wp_error($request) \|\| wp_remote_retrieve_response_code($request) != 200)
86		{
87		acf_add_admin_notice(__('<b>Error</b>. Could not load add-ons list', 'acf'), 'error');
88		}
89		else
90		{
91		$this->view['json'] = json_decode( $request['body'], true );
92		}
93
94		}
95
96
97		/*
98		* html
99		*
100		* description
101		*
102		* @type function
103		* @date 7/01/2014
104		* @since 5.0.0
105		*
106		* @param $post_id (int)
107		* @return $post_id (int)
108		*/
		0 ignored issues – show Documentation introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report The doc-type `$post_id` could not be parsed: Unknown type name "$post_id" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
109
110		function html() {
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
111
112		// load view
113		acf_get_view('settings-addons', $this->view);
114
115		}
116
117		}
118
119
120		// initialize
121		new acf_settings_addons();
122
123		?>
		0 ignored issues – show Best Practice introduced 2016-02-10 19:57 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
124

rousnay / lighthouse

acf_settings_addons A last analyzed 2019-07-26 18:21 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

acf_settings_addons A
last analyzed 2019-07-26 18:21 UTC