SQLiteDriver::setProperties() - Code Metrics - Inspection of "Improve code quality" - rougin/describe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Rougin

created 2016-11-10 06:52 UTC

SQLiteDriver::setProperties() A

↳ Parent: SQLiteDriver

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	11
ccs	9
cts	9
cp	1
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	6
nc	4
nop	2
crap	3

<?php

namespace Rougin\Describe\Driver;

use Rougin\Describe\Column;

/**
 * SQLite Driver
 *
 * A database driver extension for SQLite.
 *
 * @package  Describe
 * @category Driver
 * @author   Rougin Royce Gutib <[email protected]>
 */
class SQLiteDriver implements DriverInterface
{
    /**
     * @var \PDO
     */
    protected $pdo;

    /**
     * @param PDO $pdo
     */
    public function __construct(\PDO $pdo)
    {
        $this->pdo = $pdo;
    }

    /**
     * Returns the result.
     *
     * @return array
     */
    public function getTable($table)
    {
        $columns = [];

        // Gets list of columns
        $query = 'PRAGMA table_info("' . $table . '");';
        $information = $this->pdo->prepare($query);

        $information->execute();
        $information->setFetchMode(\PDO::FETCH_OBJ);

        while ($row = $information->fetch()) {
            $column = new Column;

            $this->setProperties($row, $column);

            $column->setDefaultValue($row->dflt_value);
            $column->setField($row->name);
            $column->setDataType(strtolower($row->type));

            array_push($columns, $column);
        }

        // Gets list of foreign keys, if any
        $query = 'PRAGMA foreign_key_list("' . $table . '");';
        $foreignTable = $this->pdo->prepare($query);

        $foreignTable->execute();
        $foreignTable->setFetchMode(\PDO::FETCH_OBJ);

        return $this->setForeignColumns($foreignTable, $columns, $column);;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * Shows the list of tables.
     *
     * @return array
     */
    public function showTables()
    {
        $tables = [];

        // Gets list of columns
        $query = 'SELECT name FROM sqlite_master WHERE type = "table";';
        $information = $this->pdo->prepare($query);

        $information->execute();
        $information->setFetchMode(\PDO::FETCH_OBJ);

        while ($row = $information->fetch()) {
            if ($row->name != 'sqlite_sequence') {
                array_push($tables, $row->name);
            }
        }

        return $tables;
    }

    /**
     * Sets the properties of the specified column.
     *
     * @param  \PDOStatement $foreignTable
     * @param  array         $columns
     * @return void
     */
    protected function setForeignColumns($foreignTable, array $columns)
    {
        while ($row = $foreignTable->fetch()) {
            foreach ($columns as $column) {
                if ($column->getField() == $row->from) {
                    $column->setForeign(true);

                    $column->setReferencedField($row->to);
                    $column->setReferencedTable($row->table);
                }
            }
        }

        return $columns;
    }

    /**
     * Sets the properties of the specified column.
     *
     * @param  mixed                   $row
     * @param  \Rougin\Describe\Column &$column
     * @return void
     */
    protected function setProperties($row, Column &$column)
    {
        if (! $row->notnull) {
            $column->setNull(true);
        }

        if ($row->pk) {
            $column->setPrimary(true);
            $column->setAutoIncrement(true);
        }
    }
}


1		<?php
2
3		namespace Rougin\Describe\Driver;
4
5		use Rougin\Describe\Column;
6
7		/**
8		* SQLite Driver
9		*
10		* A database driver extension for SQLite.
11		*
12		* @package Describe
13		* @category Driver
14		* @author Rougin Royce Gutib <[email protected]>
15		*/
16		class SQLiteDriver implements DriverInterface
17		{
18		/**
19		* @var \PDO
20		*/
21		protected $pdo;
22
23		/**
24		* @param PDO $pdo
25		*/
26	18	public function __construct(\PDO $pdo)
27		{
28	18	$this->pdo = $pdo;
29	18	}
30
31		/**
32		* Returns the result.
33		*
34		* @return array
35		*/
36	12	public function getTable($table)
37		{
38	12	$columns = [];
39
40		// Gets list of columns
41	12	$query = 'PRAGMA table_info("' . $table . '");';
42	12	$information = $this->pdo->prepare($query);
43
44	12	$information->execute();
45	12	$information->setFetchMode(\PDO::FETCH_OBJ);
46
47	12	while ($row = $information->fetch()) {
48	12	$column = new Column;
49
50	12	$this->setProperties($row, $column);
51
52	12	$column->setDefaultValue($row->dflt_value);
53	12	$column->setField($row->name);
54	12	$column->setDataType(strtolower($row->type));
55
56	12	array_push($columns, $column);
57	12	}
58
59		// Gets list of foreign keys, if any
60	12	$query = 'PRAGMA foreign_key_list("' . $table . '");';
61	12	$foreignTable = $this->pdo->prepare($query);
62
63	12	$foreignTable->execute();
64	12	$foreignTable->setFetchMode(\PDO::FETCH_OBJ);
65
66	12	return $this->setForeignColumns($foreignTable, $columns, $column);;
		0 ignored issues – show Bug introduced 2016-11-10 06:56 UTC by Report Bug Copy Issue Report The variable `$column` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Unused Code introduced 2016-11-10 06:56 UTC by Report Bug Copy Issue Report The call to `SQLiteDriver::setForeignColumns()` has too many arguments starting with `$column`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
67		}
68
69		/**
70		* Shows the list of tables.
71		*
72		* @return array
73		*/
74	6	public function showTables()
75		{
76	6	$tables = [];
77
78		// Gets list of columns
79	6	$query = 'SELECT name FROM sqlite_master WHERE type = "table";';
80	6	$information = $this->pdo->prepare($query);
81
82	6	$information->execute();
83	6	$information->setFetchMode(\PDO::FETCH_OBJ);
84
85	6	while ($row = $information->fetch()) {
86	6	if ($row->name != 'sqlite_sequence') {
87	6	array_push($tables, $row->name);
88	6	}
89	6	}
90
91	6	return $tables;
92		}
93
94		/**
95		* Sets the properties of the specified column.
96		*
97		* @param \PDOStatement $foreignTable
98		* @param array $columns
99		* @return void
100		*/
101	12	protected function setForeignColumns($foreignTable, array $columns)
102		{
103	12	while ($row = $foreignTable->fetch()) {
104	12	foreach ($columns as $column) {
105	12	if ($column->getField() == $row->from) {
106	12	$column->setForeign(true);
107
108	12	$column->setReferencedField($row->to);
109	12	$column->setReferencedTable($row->table);
110	12	}
111	12	}
112	12	}
113
114	12	return $columns;
115		}
116
117		/**
118		* Sets the properties of the specified column.
119		*
120		* @param mixed $row
121		* @param \Rougin\Describe\Column &$column
122		* @return void
123		*/
124	12	protected function setProperties($row, Column &$column)
125		{
126	12	if (! $row->notnull) {
127	12	$column->setNull(true);
128	12	}
129
130	12	if ($row->pk) {
131	12	$column->setPrimary(true);
132	12	$column->setAutoIncrement(true);
133	12	}
134	12	}
135		}
136

rougin / describe

Pull Request — master (#1)

SQLiteDriver::setProperties() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like