MySQLDriver::setForeignColumns() - Code Metrics - Inspection of "Improve code quality" - rougin/describe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Rougin

created 2016-11-10 06:00 UTC

MySQLDriver::setForeignColumns() A

↳ Parent: MySQLDriver

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	0
cts	10
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	3
crap	12

<?php

namespace Rougin\Describe\Driver;

use Rougin\Describe\Column;

/**
 * MySQL Driver
 *
 * A database driver extension for MySQL.
 *
 * @package  Describe
 * @category Driver
 * @author   Rougin Royce Gutib <[email protected]>
 */
class MySQLDriver implements DriverInterface
{
    /**
     * @var array
     */
    protected $columns = [];

    /**
     * @var string
     */
    protected $database;

    /**
     * @var \PDO
     */
    protected $pdo;

    /**
     * @param PDO    $pdo
     * @param string $database
     */
    public function __construct(\PDO $pdo, $database)
    {
        $this->database = $database;
        $this->pdo = $pdo;
    }

    /**
     * Returns the result.
     *
     * @return array
     */
    public function getTable($table)
    {
        $this->columns = [];

        $information = $this->pdo->prepare('DESCRIBE ' . $table);
        $information->execute();
        $information->setFetchMode(\PDO::FETCH_OBJ);

        // if ($stripped = strpos($table, '.')) {

        //     $table = substr($table, $stripped + 1);

        // }

        while ($row = $information->fetch()) {
            preg_match('/(.*?)\((.*?)\)/', $row->Type, $match);

            $column = new Column;
            $null   = 'Null';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $this->setProperties($row, $column);
            $this->setKey($row, $column);

            $column->setDataType($row->Type);
            $column->setDefaultValue($row->Default);
            $column->setField($row->Field);

            if (isset($match[1])) {
                $column->setDataType($match[1]);
                $column->setLength($match[2]);
            }

            $query = 'SELECT COLUMN_NAME as "column",' .
                'REFERENCED_COLUMN_NAME as "referenced_column",' .
                'CONCAT(' .
                    'REFERENCED_TABLE_SCHEMA, ".",' .
                    'REFERENCED_TABLE_NAME' .
                ') as "referenced_table"' .
                'FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE ' .
                'WHERE CONSTRAINT_SCHEMA = "' . $this->database . '" ' .
                'AND TABLE_NAME = "' . $table . '";';

            $foreignTable = $this->pdo->prepare($query);

            $foreignTable->execute();
            $foreignTable->setFetchMode(\PDO::FETCH_OBJ);

            $this->setForeignColumns($foreignTable, $row, $column);

            array_push($this->columns, $column);
        }

        return $this->columns;
    }

    /**
     * Shows the list of tables.
     *
     * @return array
     */
    public function showTables()
    {
        $tables = [];

        $information = $this->pdo->prepare('SHOW TABLES');
        $information->execute();

        while ($row = $information->fetch()) {
            array_push($tables, $row[0]);
        }

        return $tables;
    }

    /**
     * Sets the key of the specified column.
     *
     * @param  mixed                   $row
     * @param  \Rougin\Describe\Column &$column
     * @return void
     */
    protected function setKey($row, Column &$column)
    {
        switch ($row->Key) {
            case 'PRI':
                $column->setPrimary(true);

                break;
            
            case 'MUL':
                $column->setForeign(true);

                break;

            case 'UNI':
                $column->setUnique(true);

                break;
        }
    }

    /**
     * Sets the properties of the specified column.
     *
     * @param  \PDOStatement           $foreignTable
     * @param  mixed                   $row
     * @param  \Rougin\Describe\Column &$column
     * @return void
     */
    protected function setForeignColumns($foreignTable, $row, Column &$column)
    {
        while ($foreignRow = $foreignTable->fetch()) {
            if ($foreignRow->column == $row->Field) {
                $referencedTable = $this->stripTableSchema($foreignRow->referenced_table);

                $column->setReferencedField($foreignRow->referenced_column);
                $column->setReferencedTable($referencedTable);
            }
        }
    }

    /**
     * Sets the properties of the specified column.
     *
     * @param  mixed                   $row
     * @param  \Rougin\Describe\Column &$column
     * @return void
     */
    protected function setProperties($row, Column &$column)
    {
        if ($row->Extra == 'auto_increment') {
            $column->setAutoIncrement(true);
        }

        if ($row->$null == 'YES') {

            $column->setNull(true);
        }
    }

    /**
     * Strips the table schema from the table name.
     *
     * @param  string $table
     * @return string
     */
    protected function stripTableSchema($table)
    {
        return (strpos($table, '.') !== false) ? substr($table, strpos($table, '.') + 1) : $table;
    }
}


1			<?php
2
3			namespace Rougin\Describe\Driver;
4
5			use Rougin\Describe\Column;
6
7			/**
8			* MySQL Driver
9			*
10			* A database driver extension for MySQL.
11			*
12			* @package Describe
13			* @category Driver
14			* @author Rougin Royce Gutib <[email protected]>
15			*/
16			class MySQLDriver implements DriverInterface
17			{
18			/**
19			* @var array
20			*/
21			protected $columns = [];
22
23			/**
24			* @var string
25			*/
26			protected $database;
27
28			/**
29			* @var \PDO
30			*/
31			protected $pdo;
32
33			/**
34			* @param PDO $pdo
35			* @param string $database
36			*/
37			public function __construct(\PDO $pdo, $database)
38			{
39			$this->database = $database;
40			$this->pdo = $pdo;
41			}
42
43			/**
44			* Returns the result.
45			*
46			* @return array
47			*/
48			public function getTable($table)
49			{
50			$this->columns = [];
51
52			$information = $this->pdo->prepare('DESCRIBE ' . $table);
53			$information->execute();
54			$information->setFetchMode(\PDO::FETCH_OBJ);
55
56			// if ($stripped = strpos($table, '.')) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-10 06:07 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57			// $table = substr($table, $stripped + 1);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-10 06:07 UTC by Report Bug Copy Issue Report `48%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			// }
59
60			while ($row = $information->fetch()) {
61			preg_match('/(.?)\((.?)\)/', $row->Type, $match);
62
63			$column = new Column;
64			$null = 'Null';
			0 ignored issues – show Unused Code introduced 2016-11-10 06:07 UTC by Report Bug Copy Issue Report `$null` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
65
66			$this->setProperties($row, $column);
67			$this->setKey($row, $column);
68
69			$column->setDataType($row->Type);
70			$column->setDefaultValue($row->Default);
71			$column->setField($row->Field);
72
73			if (isset($match[1])) {
74			$column->setDataType($match[1]);
75			$column->setLength($match[2]);
76			}
77
78			$query = 'SELECT COLUMN_NAME as "column",' .
79			'REFERENCED_COLUMN_NAME as "referenced_column",' .
80			'CONCAT(' .
81			'REFERENCED_TABLE_SCHEMA, ".",' .
82			'REFERENCED_TABLE_NAME' .
83			') as "referenced_table"' .
84			'FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE ' .
85			'WHERE CONSTRAINT_SCHEMA = "' . $this->database . '" ' .
86			'AND TABLE_NAME = "' . $table . '";';
87
88			$foreignTable = $this->pdo->prepare($query);
89
90			$foreignTable->execute();
91			$foreignTable->setFetchMode(\PDO::FETCH_OBJ);
92
93			$this->setForeignColumns($foreignTable, $row, $column);
94
95			array_push($this->columns, $column);
96			}
97
98			return $this->columns;
99			}
100
101			/**
102			* Shows the list of tables.
103			*
104			* @return array
105			*/
106			public function showTables()
107			{
108			$tables = [];
109
110			$information = $this->pdo->prepare('SHOW TABLES');
111			$information->execute();
112
113			while ($row = $information->fetch()) {
114			array_push($tables, $row[0]);
115			}
116
117			return $tables;
118			}
119
120			/**
121			* Sets the key of the specified column.
122			*
123			* @param mixed $row
124			* @param \Rougin\Describe\Column &$column
125			* @return void
126			*/
127			protected function setKey($row, Column &$column)
128			{
129			switch ($row->Key) {
130			case 'PRI':
131			$column->setPrimary(true);
132
133			break;
134
135			case 'MUL':
136			$column->setForeign(true);
137
138			break;
139
140			case 'UNI':
141			$column->setUnique(true);
142
143			break;
144			}
145			}
146
147			/**
148			* Sets the properties of the specified column.
149			*
150			* @param \PDOStatement $foreignTable
151			* @param mixed $row
152			* @param \Rougin\Describe\Column &$column
153			* @return void
154			*/
155			protected function setForeignColumns($foreignTable, $row, Column &$column)
156			{
157			while ($foreignRow = $foreignTable->fetch()) {
158			if ($foreignRow->column == $row->Field) {
159			$referencedTable = $this->stripTableSchema($foreignRow->referenced_table);
160
161			$column->setReferencedField($foreignRow->referenced_column);
162			$column->setReferencedTable($referencedTable);
163			}
164			}
165			}
166
167			/**
168			* Sets the properties of the specified column.
169			*
170			* @param mixed $row
171			* @param \Rougin\Describe\Column &$column
172			* @return void
173			*/
174			protected function setProperties($row, Column &$column)
175			{
176			if ($row->Extra == 'auto_increment') {
177			$column->setAutoIncrement(true);
178			}
179
180			if ($row->$null == 'YES') {
			0 ignored issues – show Bug introduced 2016-11-10 06:07 UTC by Report Bug Copy Issue Report The variable `$null` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
181			$column->setNull(true);
182			}
183			}
184
185			/**
186			* Strips the table schema from the table name.
187			*
188			* @param string $table
189			* @return string
190			*/
191			protected function stripTableSchema($table)
192			{
193			return (strpos($table, '.') !== false) ? substr($table, strpos($table, '.') + 1) : $table;
194			}
195			}
196

rougin / describe

Pull Request — master (#1)

MySQLDriver::setForeignColumns() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like