CreateScaffoldCommand::execute() - Code Metrics - Inspection of "Update commands and tests" - rougin/combustor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cfe8fe...f9982c )

by Rougin

created 2016-03-11 17:42 UTC

CreateScaffoldCommand::execute() B

↳ Parent: CreateScaffoldCommand

Complexity

Conditions	5
Paths	5

Size

Total Lines	51
Code Lines	38

Duplication

Lines	15
Ratio	29.41 %

Code Coverage

Tests	38
CRAP Score	5

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	15
loc	51
ccs	38
cts	38
cp	1
rs	8.6588
cc	5
eloc	38
nc	5
nop	2
crap	5

How to fix Long Method

<?php

namespace Rougin\Combustor\Commands;

use Rougin\Combustor\Common\Tools;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Create Scaffold Command
 *
 * Generates a Wildfire or Doctrine-based controller,
 * model and view files for CodeIgniter
 * 
 * @package Combustor
 * @author  Rougin Royce Gutib <[email protected]>
 */
class CreateScaffoldCommand extends AbstractCommand
{
    /**
     * Checks whether the command is enabled or not in the current environment.
     *
     * Override this to check for x or y and return false if the command can not
     * run properly under the current conditions.
     *
     * @return bool
     */
    public function isEnabled()
    {
        return Tools::isCommandEnabled();
    }

    /**
     * Sets the configurations of the specified command.
     *
     * @return void
     */
    protected function configure()
    {
        $this->setName('create:scaffold')
            ->setDescription('Creates a new controller, model and view')
            ->addArgument(
                'name',
                InputArgument::REQUIRED,
                'Name of the controller, model and view'
            )->addOption(
                'bootstrap',
                NULL,
                InputOption::VALUE_NONE,
                'Includes the Bootstrap CSS/JS Framework tags'
            )->addOption(
                'camel',
                NULL,
                InputOption::VALUE_NONE,
                'Uses the camel case naming convention'
            )->addOption(
                'doctrine',
                NULL,
                InputOption::VALUE_NONE,
                'Uses the Doctrine\'s specifications'
            )->addOption(
                'keep',
                null,
                InputOption::VALUE_NONE,
                'Keeps the name to be used'
            )->addOption(
                'lowercase',
                null,
                InputOption::VALUE_NONE,
                'Keeps the first character of the name to lowercase'
            )->addOption(
                'wildfire',
                NULL,
                InputOption::VALUE_NONE,
                'Uses the Wildfire\'s specifications'
            );
    }

    /**
     * Executes the command.
     * 
     * @param \Symfony\Component\Console\Input\InputInterface   $input
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     * @return object|\Symfony\Component\Console\Output\OutputInterface
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $commands = [
            'create:controller',
            'create:model',
            'create:view'
        ];

        $bootstrap = $input->getOption('bootstrap');
        $camel = $input->getOption('camel');
        $doctrine = $input->getOption('doctrine');
        $keep = $input->getOption('keep');
        $lowercase = $input->getOption('lowercase');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $lowercase = $input->getOption('lowercase');
        $wildfire = $input->getOption('wildfire');

        foreach ($commands as $command) {
            $arguments = [
                'command' => $command,
                'name' => $input->getArgument('name')
            ];

            switch ($command) {
                case 'create:controller':

                    $arguments['--camel'] = $camel;
                    $arguments['--doctrine'] = $doctrine;
                    $arguments['--keep'] = $keep;
                    $arguments['--lowercase'] = $lowercase;
                    $arguments['--wildfire'] = $wildfire;

                    break;
                case 'create:model':

                    $arguments['--camel'] = $camel;
                    $arguments['--doctrine'] = $doctrine;
                    $arguments['--lowercase'] = $lowercase;
                    $arguments['--wildfire'] = $wildfire;

                    break;
                case 'create:view':
                    $arguments['--bootstrap'] = $bootstrap;
                    $arguments['--camel'] = $camel;
                    $arguments['--keep'] = $keep;

                    break;
            }

            $input = new ArrayInput($arguments);
            $application = $this->getApplication()->find($command);
            $application->run($input, $output);
        }
    }
}


1			<?php
2
3			namespace Rougin\Combustor\Commands;
4
5			use Rougin\Combustor\Common\Tools;
6			use Symfony\Component\Console\Input\ArrayInput;
7			use Symfony\Component\Console\Input\InputArgument;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Input\InputOption;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			/**
13			* Create Scaffold Command
14			*
15			* Generates a Wildfire or Doctrine-based controller,
16			* model and view files for CodeIgniter
17			*
18			* @package Combustor
19			* @author Rougin Royce Gutib <[email protected]>
20			*/
21			class CreateScaffoldCommand extends AbstractCommand
22			{
23			/**
24			* Checks whether the command is enabled or not in the current environment.
25			*
26			* Override this to check for x or y and return false if the command can not
27			* run properly under the current conditions.
28			*
29			* @return bool
30			*/
31	6		public function isEnabled()
32			{
33	6		return Tools::isCommandEnabled();
34			}
35
36			/**
37			* Sets the configurations of the specified command.
38			*
39			* @return void
40			*/
41	6		protected function configure()
42			{
43	6		$this->setName('create:scaffold')
44	6		->setDescription('Creates a new controller, model and view')
45	6		->addArgument(
46	6		'name',
47	6		InputArgument::REQUIRED,
48			'Name of the controller, model and view'
49	6		)->addOption(
50	6		'bootstrap',
51	6		NULL,
52	6		InputOption::VALUE_NONE,
53			'Includes the Bootstrap CSS/JS Framework tags'
54	6		)->addOption(
55	6		'camel',
56	6		NULL,
57	6		InputOption::VALUE_NONE,
58			'Uses the camel case naming convention'
59	6		)->addOption(
60	6		'doctrine',
61	6		NULL,
62	6		InputOption::VALUE_NONE,
63			'Uses the Doctrine\'s specifications'
64	6		)->addOption(
65	6		'keep',
66	6		null,
67	6		InputOption::VALUE_NONE,
68			'Keeps the name to be used'
69	6		)->addOption(
70	6		'lowercase',
71	6		null,
72	6		InputOption::VALUE_NONE,
73			'Keeps the first character of the name to lowercase'
74	6		)->addOption(
75	6		'wildfire',
76	6		NULL,
77	6		InputOption::VALUE_NONE,
78			'Uses the Wildfire\'s specifications'
79	6		);
80	6		}
81
82			/**
83			* Executes the command.
84			*
85			* @param \Symfony\Component\Console\Input\InputInterface $input
86			* @param \Symfony\Component\Console\Output\OutputInterface $output
87			* @return object\|\Symfony\Component\Console\Output\OutputInterface
88			*/
89	3		protected function execute(InputInterface $input, OutputInterface $output)
90			{
91			$commands = [
92	3		'create:controller',
93	3		'create:model',
94			'create:view'
95	3		];
96
97	3		$bootstrap = $input->getOption('bootstrap');
98	3		$camel = $input->getOption('camel');
99	3		$doctrine = $input->getOption('doctrine');
100	3		$keep = $input->getOption('keep');
101	3		$lowercase = $input->getOption('lowercase');
			0 ignored issues – show Unused Code introduced 2016-03-11 17:47 UTC by Report Bug Copy Issue Report `$lowercase` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102	3		$lowercase = $input->getOption('lowercase');
103	3		$wildfire = $input->getOption('wildfire');
104
105	3		foreach ($commands as $command) {
106			$arguments = [
107	3		'command' => $command,
108	3		'name' => $input->getArgument('name')
109	3		];
110
111			switch ($command) {
112	3	View Code Duplication	case 'create:controller':
			0 ignored issues – show Duplication introduced 2016-03-11 17:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113	3		$arguments['--camel'] = $camel;
114	3		$arguments['--doctrine'] = $doctrine;
115	3		$arguments['--keep'] = $keep;
116	3		$arguments['--lowercase'] = $lowercase;
117	3		$arguments['--wildfire'] = $wildfire;
118
119	3		break;
120	3	View Code Duplication	case 'create:model':
			0 ignored issues – show Duplication introduced 2016-03-11 17:47 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121	3		$arguments['--camel'] = $camel;
122	3		$arguments['--doctrine'] = $doctrine;
123	3		$arguments['--lowercase'] = $lowercase;
124	3		$arguments['--wildfire'] = $wildfire;
125
126	3		break;
127	3		case 'create:view':
128	3		$arguments['--bootstrap'] = $bootstrap;
129	3		$arguments['--camel'] = $camel;
130	3		$arguments['--keep'] = $keep;
131
132	3		break;
133			}
134
135	3		$input = new ArrayInput($arguments);
136	3		$application = $this->getApplication()->find($command);
137	3		$application->run($input, $output);
138	3		}
139	3		}
140			}
141

rougin / combustor

Push — master ( cfe8fe...f9982c )

CreateScaffoldCommand::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like