InstallData::install() - Code Metrics - Inspection of "fixing broken config" - rossmitchell/module-twofactor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ec14e...eda794 )

by Ross

created 2017-05-20 17:58 UTC

InstallData::install() A

↳ Parent: InstallData

Complexity

Conditions	1
Paths	1

Size

Total Lines	62
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	62
rs	9.4743
cc	1
eloc	42
nc	1
nop	2

How to fix Long Method

<?php
/**
 * A two factor authentication module that protects both the admin and customer logins
 * Copyright (C) 2017  Ross Mitchell
 *
 * This file is part of Rossmitchell/Twofactor.
 *
 * Rossmitchell/Twofactor is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

namespace Rossmitchell\Twofactor\Setup;

use Magento\Customer\Setup\CustomerSetup;
use Magento\Customer\Setup\CustomerSetupFactory;
use Magento\Eav\Api\AttributeRepositoryInterface;
use Magento\Eav\Model\Entity\Attribute\SetFactory as AttributeSetFactory;
use Magento\Framework\Setup\InstallDataInterface;
use Magento\Framework\Setup\ModuleContextInterface;
use Magento\Framework\Setup\ModuleDataSetupInterface;
use Rossmitchell\Twofactor\Model\Customer\Attribute\IsUsingTwoFactor;
use Rossmitchell\Twofactor\Model\Customer\Attribute\TwoFactorSecret;

class InstallData implements InstallDataInterface
{

    private $customerSetupFactory;
    /**
     * @var AttributeSetFactory
     */
    private $attributeSetFactory;
    /**
     * @var AttributeRepositoryInterface
     */
    private $attributeRepository;

    /**
     * Constructor
     *
     * @param CustomerSetupFactory         $customerSetupFactory
     * @param AttributeSetFactory          $attributeSetFactory
     * @param AttributeRepositoryInterface $attributeRepository
     */
    public function __construct(
        CustomerSetupFactory $customerSetupFactory,
        AttributeSetFactory $attributeSetFactory,
        AttributeRepositoryInterface $attributeRepository
    ) {
        $this->customerSetupFactory = $customerSetupFactory;
        $this->attributeSetFactory  = $attributeSetFactory;
        $this->attributeRepository  = $attributeRepository;
    }

    /**
     * {@inheritdoc}
     */
    public function install(

        ModuleDataSetupInterface $setup,
        ModuleContextInterface $context
    ) {
        /** @var CustomerSetup $customerSetup */
        $customerSetup  = $this->customerSetupFactory->create(['setup' => $setup]);
        $customerEntity = $customerSetup->getEavConfig()->getEntityType('customer');
        $attributeSetId = $customerEntity->getDefaultAttributeSetId();

        /** @var $attributeSet AttributeSet */
        $attributeSet     = $this->attributeSetFactory->create();
        $attributeGroupId = $attributeSet->getDefaultGroupId($attributeSetId);

        $useTwoFactorCode = IsUsingTwoFactor::ATTRIBUTE_CODE;

        $customerSetup->addAttribute(
            'customer',
            $useTwoFactorCode,
            [
                'type' => 'int',
                'label' => $useTwoFactorCode,
                'input' => 'boolean',
                'source' => '',
                'required' => true,
                'visible' => true,
                'position' => 333,
                'system' => false,
                'backend' => '',
            ]
        );

        $attribute = $customerSetup->getEavConfig()->getAttribute('customer', $useTwoFactorCode)->addData(
            [
                'attribute_set_id' => $attributeSetId,
                'attribute_group_id' => $attributeGroupId,
                'used_in_forms' => [
                    'adminhtml_customer',
                    'customer_account_create',
                    'customer_account_edit',
                ],
            ]
        );
        $attribute->save();

        $secretCode = TwoFactorSecret::ATTRIBUTE_CODE;

        $customerSetup->addAttribute(
            'customer',
            $secretCode,
            [
                'type' => 'varchar',
                'label' => $secretCode,
                'input' => 'text',
                'source' => '',
                'required' => false,
                'visible' => false,
                'position' => 334,
                'system' => false,
                'backend' => '',
            ]
        );
    }
}


1			<?php
2			/**
3			* A two factor authentication module that protects both the admin and customer logins
4			* Copyright (C) 2017 Ross Mitchell
5			*
6			* This file is part of Rossmitchell/Twofactor.
7			*
8			* Rossmitchell/Twofactor is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU General Public License as published by
10			* the Free Software Foundation, either version 3 of the License, or
11			* (at your option) any later version.
12			*
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU General Public License for more details.
17			*
18			* You should have received a copy of the GNU General Public License
19			* along with this program. If not, see <http://www.gnu.org/licenses/>.
20			*/
21
22			namespace Rossmitchell\Twofactor\Setup;
23
24			use Magento\Customer\Setup\CustomerSetup;
25			use Magento\Customer\Setup\CustomerSetupFactory;
26			use Magento\Eav\Api\AttributeRepositoryInterface;
27			use Magento\Eav\Model\Entity\Attribute\SetFactory as AttributeSetFactory;
28			use Magento\Framework\Setup\InstallDataInterface;
29			use Magento\Framework\Setup\ModuleContextInterface;
30			use Magento\Framework\Setup\ModuleDataSetupInterface;
31			use Rossmitchell\Twofactor\Model\Customer\Attribute\IsUsingTwoFactor;
32			use Rossmitchell\Twofactor\Model\Customer\Attribute\TwoFactorSecret;
33
34			class InstallData implements InstallDataInterface
35			{
36
37			private $customerSetupFactory;
38			/**
39			* @var AttributeSetFactory
40			*/
41			private $attributeSetFactory;
42			/**
43			* @var AttributeRepositoryInterface
44			*/
45			private $attributeRepository;
46
47			/**
48			* Constructor
49			*
50			* @param CustomerSetupFactory $customerSetupFactory
51			* @param AttributeSetFactory $attributeSetFactory
52			* @param AttributeRepositoryInterface $attributeRepository
53			*/
54			public function __construct(
55			CustomerSetupFactory $customerSetupFactory,
56			AttributeSetFactory $attributeSetFactory,
57			AttributeRepositoryInterface $attributeRepository
58			) {
59			$this->customerSetupFactory = $customerSetupFactory;
60			$this->attributeSetFactory = $attributeSetFactory;
61			$this->attributeRepository = $attributeRepository;
62			}
63
64			/**
65			* {@inheritdoc}
66			*/
67			public function install(
			0 ignored issues – show Unused Code introduced 2017-04-17 00:01 UTC by Report Bug Copy Issue Report The method parameter $context is never used Loading history...
68			ModuleDataSetupInterface $setup,
69			ModuleContextInterface $context
70			) {
71			/** @var CustomerSetup $customerSetup */
72			$customerSetup = $this->customerSetupFactory->create(['setup' => $setup]);
73			$customerEntity = $customerSetup->getEavConfig()->getEntityType('customer');
74			$attributeSetId = $customerEntity->getDefaultAttributeSetId();
75
76			/** @var $attributeSet AttributeSet */
77			$attributeSet = $this->attributeSetFactory->create();
78			$attributeGroupId = $attributeSet->getDefaultGroupId($attributeSetId);
79
80			$useTwoFactorCode = IsUsingTwoFactor::ATTRIBUTE_CODE;
81
82			$customerSetup->addAttribute(
83			'customer',
84			$useTwoFactorCode,
85			[
86			'type' => 'int',
87			'label' => $useTwoFactorCode,
88			'input' => 'boolean',
89			'source' => '',
90			'required' => true,
91			'visible' => true,
92			'position' => 333,
93			'system' => false,
94			'backend' => '',
95			]
96			);
97
98			$attribute = $customerSetup->getEavConfig()->getAttribute('customer', $useTwoFactorCode)->addData(
99			[
100			'attribute_set_id' => $attributeSetId,
101			'attribute_group_id' => $attributeGroupId,
102			'used_in_forms' => [
103			'adminhtml_customer',
104			'customer_account_create',
105			'customer_account_edit',
106			],
107			]
108			);
109			$attribute->save();
110
111			$secretCode = TwoFactorSecret::ATTRIBUTE_CODE;
112
113			$customerSetup->addAttribute(
114			'customer',
115			$secretCode,
116			[
117			'type' => 'varchar',
118			'label' => $secretCode,
119			'input' => 'text',
120			'source' => '',
121			'required' => false,
122			'visible' => false,
123			'position' => 334,
124			'system' => false,
125			'backend' => '',
126			]
127			);
128			}
129			}
130

rossmitchell / module-twofactor

Push — master ( 4ec14e...eda794 )

InstallData::install() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like