Rossmitchell\Twofactor\Tests\Integration\FixtureLoader\Configuration

Complexity

Total Complexity

12

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	loadData()	0	23	5
A	rollBackData()	0	4	1
B	verifyData()	0	11	6

<?php
/**
 * A two factor authentication module that protects both the admin and customer logins
 * Copyright (C) 2017  Ross Mitchell
 *
 * This file is part of Rossmitchell/Twofactor.
 *
 * Rossmitchell/Twofactor is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

namespace Rossmitchell\Twofactor\Tests\Integration\FixtureLoader;

use Magento\Framework\App\Config\ScopeConfigInterface;

class Configuration extends AbstractLoader
{

    public function loadData()
    {
        /** @var \Magento\TestFramework\App\Config $configWriter */
        $configWriter = $this->createObject(ScopeConfigInterface::class, false);
        foreach ($this->data as $configValue) {
            $key   = $configValue['key'];
            $value = $configValue['value'];
            $scope = $configValue['scope'];
            switch ($scope) {
                case 'default':
                    $configWriter->setValue($key, $value, 'default');
                // Intentional fall through
                case 'website':
                    $configWriter->setValue($key, $value, 'website');
                // Intentional fall through
                case 'store':
                    $configWriter->setValue($key, $value, 'store');
                    break;
                default:
                    throw new \Exception("Scope must be ons of default, website, store. You used $scope");

Direct throw of Exception is discouraged. Use \Magento\Framework\Exception\LocalizedException instead.

            }
        }
    }

    public function rollBackData()

Empty FUNCTION statement detected

    {
        // TODO: Implement rollBackData() method.

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

    }

    public function verifyData()
    {
        if (!is_array($this->data)) {
            throw new \Exception("configData must be an array");

Direct throw of Exception is discouraged. Use \Magento\Framework\Exception\LocalizedException instead.

        }
        foreach ($this->data as $config) {
            if(!isset($config['key']) || !isset($config['value']) || !isset($config['scope'])) {

Expected 1 space after IF keyword; 0 found

Expected "if (...) {\n"; found "if(...) {\n"

                throw new \Exception('Each row must contain key, value, and scope values');

Direct throw of Exception is discouraged. Use \Magento\Framework\Exception\LocalizedException instead.

            }
        }
    }
}