rosasurfer\bfx\controller\actions\CheckLicenseAction::execute()

Complexity

Conditions	5
Paths	6

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function execute(Request $request, Response $response) {
        /** @var Config $config */
        $config = $this->di()['config'];

        // request:  GET /Paypal/TFV/index.php?id=TSR&lic={encoded-license}&rn=9&mt4={account}&ec=1
        // response: {account}|{plain-license}|A|{expiration}|mt4tfv|ok
        //       or: ERROR: {error-msg}|no

        $knownAccount = false;
        $input = $request->input();
        $account = $input->get('mt4', '');

        if (strIsDigits($account)) {

It seems like $account can also be of type null; however, parameter $string of rosasurfer\ministruts\strIsDigits() does only seem to accept string, maybe add an additional type check?

            $license = $config->get('bfx.accounts.'.$account, null);
            $knownAccount = !is_null($license);
            $license = $license ?: $config->get('bfx.accounts.default');
            $expires = date('Ymd', time() + 1*MONTH);                       // extend license for 30 days
            $reply = $account.'|'.$license.'|A|'.$expires.'|mt4tfv|ok';
        }
        else {
            $reply = 'ERROR: '.($account=="" ? 'Missing':'Invalid').' account number.|no';
        }
        $knownAccount || Logger::log('reply: '.$reply, L_INFO);             // log requests for unknown accounts

        echo $reply;
        return null;
    }