rootsdev / gedcomx-js

src/core/Gender.js

var GedcomX = require('../'),
    utils = require('../utils');

/**
 * A gender conclusion.
 * 
 * @see {@link https://github.com/FamilySearch/gedcomx/blob/master/specifications/json-format-specification.md#gender-conclusion|GEDCOM X JSON Spec}
 * 
 * @class
 * @extends Conclusion
 * @param {Object} [json]
 */
var Gender = function(json){
  
  // Protect against forgetting the new keyword when calling the constructor
  if(!(this instanceof Gender)){
    return new Gender(json);
  }
  
  // If the given object is already an instance then just return it. DON'T copy it.
  if(Gender.isInstance(json)){
    return json;
  }
  
  this.init(json);

There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.

};

Gender.prototype = Object.create(GedcomX.Conclusion.prototype);

Gender._gedxClass = Gender.prototype._gedxClass = 'GedcomX.Gender';

Gender.jsonProps = ['type'];

/**
 * Check whether the given object is an instance of this class.
 * 
 * @param {Object} obj
 * @returns {Boolean}
 */
Gender.isInstance = function(obj){
  return utils.isInstance(obj, this._gedxClass);
};

/**
 * Initialize from JSON
 * 
 * @param {Object}

The parameter * does not exist. Did you maybe forget to remove this comment?

 * @return {Gender} this
 */
Gender.prototype.init = function(json){
  
  GedcomX.Conclusion.prototype.init.call(this, json);
  
  if(json){
    this.setType(json.type);
  }
  return this;
};

/**
 * Get the gender type
 * 
 * @returns {String} gender
 */
Gender.prototype.getType = function(){
  return this.type;
};

/**
 * Set the gender type
 * 
 * @param {String} gender
 * @returns {Gender} This instance
 */
Gender.prototype.setType = function(gender){
  this.type = gender;
  return this;
};

/**
 * Export the object as JSON
 * 
 * @return {Object} JSON object
 */
Gender.prototype.toJSON = function(){
  return this._toJSON(GedcomX.Conclusion, Gender.jsonProps);
};

module.exports = Gender;