src/NamePart.js - Code Metrics - Inspection of "reduce duplicate code; close #16" - rootsdev/gedcomx-js - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 40c2b4...09bd06 )

by Justin

created 2016-09-21 21:53 UTC

src/NamePart.js A

↳ Parent: Project

Complexity

Total Complexity	13
Complexity/F	1.3

Size

Lines of Code	128
Function Count	10

Duplication

Duplicated Lines	128
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	0
c	1
b	0
f	0
nc	2
dl	128
loc	128
rs	10
wmc	13
mnd	1
bc	13
fnc	10
bpm	1.3
cpm	1.3
noi	3

10 Functions

Rating	Name	Duplication	Size	Complexity
A	NamePart.getType	3	3	1
A	NamePart.setValue	4	4	1
A	NamePart.setType	4	4	1
A	NamePart.addQualifier	3	3	1
A	NamePart.getValue	3	3	1
A	NamePart.getQualifiers	3	3	1
A	NamePart.js ➔ NamePart	20	20	4
A	NamePart.toJSON	7	7	1
A	NamePart.setQualifiers	3	3	1
A	NamePart.isInstance	3	3	1

How to fix Duplicated Code

var ExtensibleData = require('./ExtensibleData'),

    Qualifier = require('./Qualifier'),
    utils = require('./utils');

/**
 * A part of a name.
 * 
 * @constructor
 * @param {Object} [json]

 */
var NamePart = function(json){
  
  // Protect against forgetting the new keyword when calling the constructor
  if(!(this instanceof NamePart)){
    return new NamePart(json);
  }
  
  // If the given object is already an instance then just return it. DON'T copy it.
  if(NamePart.isInstance(json)){
    return json;
  }
  
  ExtensibleData.call(this, json);
  
  if(json){
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
    this.setValue(json.value);
    this.setType(json.type);
    this.setQualifiers(json.qualifiers);

  }
};

NamePart.prototype = Object.create(ExtensibleData.prototype);

NamePart._gedxClass = NamePart.prototype._gedxClass = 'GedcomX.NamePart';

/**
 * Check whether the given object is an instance of this class.
 * 
 * @param {Object} obj
 * @returns {Boolean}
 */
NamePart.isInstance = function(obj){
  return utils.isInstance(obj, this._gedxClass);
};

/**
 * Get the type
 * 
 * @returns {String} type
 */
NamePart.prototype.getType = function(){
  return this.type;
};

/**
 * Set the type
 * 
 * @param {String} type
 * @returns {NamePart} This instance
 */
NamePart.prototype.setType = function(type){
  this.type = type;
  return this;
};

/**
 * Get the value
 * 
 * @returns {String}
 */
NamePart.prototype.getValue = function(){
  return this.value;
};

/**
 * Set the value
 * 
 * @param {String} value
 * @returns {NamePart} This instance
 */
NamePart.prototype.setValue = function(value){
  this.value = value;
  return this;
};

/**
 * Get qualifiers
 * 
 * @return {Qualifer[]}
 */
NamePart.prototype.getQualifiers = function(){
  return this.qualifiers || [];
};

/**
 * Set the qualifiers
 * 
 * @param {Qualifer[]|Object[]} qualifiers
 * @returns {NamePart} This instance
 */
NamePart.prototype.setQualifiers = function(qualifiers){
  return this._setArray(qualifiers, 'qualifiers', 'addQualifier');
};

/**
 * Add a qualifier
 * 
 * @param {Qualifier|Object} qualifier
 * @returns {NamePart} This instance
 */
NamePart.prototype.addQualifier = function(qualifier){
  return this._arrayPush(qualifier, 'qualifiers', Qualifier);
};

/**
 * Export the object as JSON
 * 
 * @return {Object} JSON object
 */
NamePart.prototype.toJSON = function(){
  return this._toJSON(ExtensibleData, [
    'type',
    'value',
    'qualifiers'
  ]);
};

module.exports = NamePart;

Metric	Value
cc	0
c	1
b	0
f	0
nc	2
dl	128
loc	128
rs	10
wmc	13
mnd	1
bc	13
fnc	10
bpm	1.3
cpm	1.3
noi	3

1	View Code Duplication	var ExtensibleData = require('./ExtensibleData'),
		0 ignored issues – show Duplication introduced 2016-09-21 21:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
2		Qualifier = require('./Qualifier'),
3		utils = require('./utils');
4
5		/**
6		* A part of a name.
7		*
8		* @constructor
9		* @param {Object} [json]
		0 ignored issues – show Documentation introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report The parameter `[json]` does not exist. Did you maybe forget to remove this comment? Loading history...
10		*/
11		var NamePart = function(json){
12
13		// Protect against forgetting the new keyword when calling the constructor
14		if(!(this instanceof NamePart)){
15		return new NamePart(json);
16		}
17
18		// If the given object is already an instance then just return it. DON'T copy it.
19		if(NamePart.isInstance(json)){
20		return json;
21		}
22
23		ExtensibleData.call(this, json);
24
25		if(json){
		0 ignored issues – show Complexity Best Practice introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report There is no return statement if `json` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
26		this.setValue(json.value);
27		this.setType(json.type);
28		this.setQualifiers(json.qualifiers);
		0 ignored issues – show Best Practice introduced 2016-05-27 14:53 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
29		}
30		};
31
32		NamePart.prototype = Object.create(ExtensibleData.prototype);
33
34		NamePart._gedxClass = NamePart.prototype._gedxClass = 'GedcomX.NamePart';
35
36		/**
37		* Check whether the given object is an instance of this class.
38		*
39		* @param {Object} obj
40		* @returns {Boolean}
41		*/
42		NamePart.isInstance = function(obj){
43		return utils.isInstance(obj, this._gedxClass);
44		};
45
46		/**
47		* Get the type
48		*
49		* @returns {String} type
50		*/
51		NamePart.prototype.getType = function(){
52		return this.type;
53		};
54
55		/**
56		* Set the type
57		*
58		* @param {String} type
59		* @returns {NamePart} This instance
60		*/
61		NamePart.prototype.setType = function(type){
62		this.type = type;
63		return this;
64		};
65
66		/**
67		* Get the value
68		*
69		* @returns {String}
70		*/
71		NamePart.prototype.getValue = function(){
72		return this.value;
73		};
74
75		/**
76		* Set the value
77		*
78		* @param {String} value
79		* @returns {NamePart} This instance
80		*/
81		NamePart.prototype.setValue = function(value){
82		this.value = value;
83		return this;
84		};
85
86		/**
87		* Get qualifiers
88		*
89		* @return {Qualifer[]}
90		*/
91		NamePart.prototype.getQualifiers = function(){
92		return this.qualifiers \|\| [];
93		};
94
95		/**
96		* Set the qualifiers
97		*
98		* @param {Qualifer[]\|Object[]} qualifiers
99		* @returns {NamePart} This instance
100		*/
101		NamePart.prototype.setQualifiers = function(qualifiers){
102		return this._setArray(qualifiers, 'qualifiers', 'addQualifier');
103		};
104
105		/**
106		* Add a qualifier
107		*
108		* @param {Qualifier\|Object} qualifier
109		* @returns {NamePart} This instance
110		*/
111		NamePart.prototype.addQualifier = function(qualifier){
112		return this._arrayPush(qualifier, 'qualifiers', Qualifier);
113		};
114
115		/**
116		* Export the object as JSON
117		*
118		* @return {Object} JSON object
119		*/
120		NamePart.prototype.toJSON = function(){
121		return this._toJSON(ExtensibleData, [
122		'type',
123		'value',
124		'qualifiers'
125		]);
126		};
127
128		module.exports = NamePart;

Metric	Value
cc	0
c	1
b	0
f	0
nc	2
dl	128
loc	128
rs	10
wmc	13
mnd	1
bc	13
fnc	10
bpm	1.3
cpm	1.3
noi	3

rootsdev / gedcomx-js

Push — master ( 40c2b4...09bd06 )

src/NamePart.js A

Complexity

Size

Duplication

Importance

10 Functions

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Metric	Value
cc	0
c	1
b	0
f	0
nc	2
dl	128
loc	128
rs	10
wmc	13
mnd	1
bc	13
fnc	10
bpm	1.3
cpm	1.3
noi	3