Issues in AttributeMetadata.php (master) - Issues in master - ronte-ltd/JsonApiBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Serializer/Mapping/AttributeMetadata.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of AppBundle the package.
 *
 * (c) Ruslan Muriev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace RonteLtd\JsonApiBundle\Serializer\Mapping;

use RonteLtd\JsonApiBundle\Annotation\Attribute;
use RonteLtd\JsonApiBundle\Annotation\Relationship;

/**
 * Class AttributeMetadata
 *
 * @package RonteLtd\Bundle\Serializer\Mapping
 * @author Ruslan Muriev <[email protected]>
 */
class AttributeMetadata implements AttributeMetadataInterface
{
    /**
     * @var string
     *
     * @internal This property is public in order to reduce the size of the
     *           class' serialized representation. Do not access it. Use
     *           {@link getName()} instead.
     */
    public $name;

    /**
     * @var Attribute
     */
    public $attribute;

    /**
     * @var Relationship
     */
    public $relationship;

    /**
     * Constructs a metadata for the given attribute.
     *
     * @param string $name
     */
    public function __construct($name)
    {
        $this->name = $name;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return Attribute
     */
    public function getAttribute()
    {
        return $this->attribute;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param Attribute $attribute
     */
    public function setAttribute($attribute)
    {
        $this->attribute = $attribute;
    }

    /**
     * @return Relationship
     */
    public function getRelationship()
    {
        return $this->relationship;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param Relationship $relationship
     */
    public function setRelationship($relationship)
    {
        $this->relationship = $relationship;
    }

    /**
     * {@inheritdoc}
     */
    public function merge(AttributeMetadataInterface $attributeMetadata)
    {
        // Overwrite only if not defined
        if (null === $this->attribute) {
            $this->attribute = $attributeMetadata->getAttribute();

        }

        // Overwrite only if not defined
        if (null === $this->relationship) {
            $this->relationship = $attributeMetadata->getRelationship();

        }
    }

    /**
     * Returns the names of the properties that should be serialized.
     *
     * @return string[]
     */
    public function __sleep()
    {
        return array('name', 'attribute', 'relationship');
    }
}

1			<?php
2			/*
3			* This file is part of AppBundle the package.
4			*
5			* (c) Ruslan Muriev <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace RonteLtd\JsonApiBundle\Serializer\Mapping;
12
13			use RonteLtd\JsonApiBundle\Annotation\Attribute;
14			use RonteLtd\JsonApiBundle\Annotation\Relationship;
15
16			/**
17			* Class AttributeMetadata
18			*
19			* @package RonteLtd\Bundle\Serializer\Mapping
20			* @author Ruslan Muriev <[email protected]>
21			*/
22			class AttributeMetadata implements AttributeMetadataInterface
23			{
24			/**
25			* @var string
26			*
27			* @internal This property is public in order to reduce the size of the
28			* class' serialized representation. Do not access it. Use
29			* {@link getName()} instead.
30			*/
31			public $name;
32
33			/**
34			* @var Attribute
35			*/
36			public $attribute;
37
38			/**
39			* @var Relationship
40			*/
41			public $relationship;
42
43			/**
44			* Constructs a metadata for the given attribute.
45			*
46			* @param string $name
47			*/
48			public function __construct($name)
49			{
50			$this->name = $name;
51			}
52
53			/**
54			* {@inheritdoc}
55			*/
56			public function getName()
57			{
58			return $this->name;
59			}
60
61			/**
62			* @return Attribute
63			*/
64			public function getAttribute()
65			{
66			return $this->attribute;
			0 ignored issues – show Bug Best Practice introduced 2016-12-09 05:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->attribute;` (`RonteLtd\JsonApiBundle\Annotation\Attribute`) is incompatible with the return type declared by the interface `RonteLtd\JsonApiBundle\S...Interface::getAttribute` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
67			}
68
69			/**
70			* @param Attribute $attribute
71			*/
72			public function setAttribute($attribute)
73			{
74			$this->attribute = $attribute;
75			}
76
77			/**
78			* @return Relationship
79			*/
80			public function getRelationship()
81			{
82			return $this->relationship;
			0 ignored issues – show Bug Best Practice introduced 2016-12-09 05:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->relationship;` (`RonteLtd\JsonApiBundle\Annotation\Relationship`) is incompatible with the return type declared by the interface `RonteLtd\JsonApiBundle\S...erface::getRelationship` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
83			}
84
85			/**
86			* @param Relationship $relationship
87			*/
88			public function setRelationship($relationship)
89			{
90			$this->relationship = $relationship;
91			}
92
93			/**
94			* {@inheritdoc}
95			*/
96			public function merge(AttributeMetadataInterface $attributeMetadata)
97			{
98			// Overwrite only if not defined
99			if (null === $this->attribute) {
100			$this->attribute = $attributeMetadata->getAttribute();
			0 ignored issues – show Documentation Bug introduced 2016-12-09 05:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$attributeMetadata->getAttribute()` of type `array` is incompatible with the declared type `object<RonteLtd\JsonApiB...e\Annotation\Attribute>` of property `$attribute`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
101			}
102
103			// Overwrite only if not defined
104			if (null === $this->relationship) {
105			$this->relationship = $attributeMetadata->getRelationship();
			0 ignored issues – show Documentation Bug introduced 2016-12-09 05:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$attributeMetadata->getRelationship()` of type `array` is incompatible with the declared type `object<RonteLtd\JsonApiB...nnotation\Relationship>` of property `$relationship`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
106			}
107			}
108
109			/**
110			* Returns the names of the properties that should be serialized.
111			*
112			* @return string[]
113			*/
114			public function __sleep()
115			{
116			return array('name', 'attribute', 'relationship');
117			}
118			}

ronte-ltd / JsonApiBundle

Issues (21)

Security Analysis no request data

Serializer/Mapping/AttributeMetadata.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like