SubstepDefinition - Code Metrics - Inspection of "WIP" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — middleware-wip ( 1f2854...9da264 )

by Romain

created 2017-05-12 15:35 UTC

SubstepDefinition A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

Metric	Value
wmc	14
lcom	2
cbo	3
dl	0
loc	119
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	getSubstep()	9	1
A	getUniqueIdentifier()	18	3
A	isLast()	6	3
A	hasNextSubsteps()	4	1
A	getNextSubsteps()	8	2
A	getDetourSubsteps()	4	1
A	hasDetour()	4	1
A	getDivergenceSubsteps()	4	1
A	hasDivergence()	4	1

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Form\Definition\Step\Step\Substep;

use Romm\Formz\Form\Definition\AbstractFormDefinition;
use Romm\Formz\Form\Definition\Step\Step\Step;

class SubstepDefinition extends AbstractFormDefinition
{
    /**
     * @var string
     * @validate NotEmpty
     */
    protected $substep;

    /**
     * @var \Romm\Formz\Form\Definition\Step\Step\Substep\SubstepDefinition
     */
    protected $next;

    /**
     * @var \Romm\Formz\Form\Definition\Step\Step\Substep\ConditionalSubstepDefinition[]
     */
    protected $detour;

    /**
     * @var \Romm\Formz\Form\Definition\Step\Step\Substep\ConditionalSubstepDefinition[]
     */
    protected $divergence;

    /**
     * @return Substep
     */
    public function getSubstep()
    {
        return $this->withFirstParent(
            Substeps::class,
            function (Substeps $substeps) {
                return $substeps->getEntry($this->substep);
            }
        );
    }

    public function getUniqueIdentifier()
    {
        $level = 1;

        $this->alongParents(function ($parent) use (&$level) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($parent instanceof self) {
                $level++;
            }

            if ($parent instanceof Step) {
                return false;
            }

            return true;
        });

        return $this->getSubstep()->getIdentifier() . '-' . $level;
    }

    /**
     * @todo
     *
     * @return bool
     */
    public function isLast()
    {
        return false === $this->hasNextSubsteps()
            && false === $this->hasDetour()
            && false === $this->hasDivergence();
    }

    /**
     * @return bool
     */
    public function hasNextSubsteps()
    {
        return null !== $this->next;
    }

    /**
     * @return SubstepDefinition
     */
    public function getNextSubsteps()
    {
        if (false === $this->hasNextSubsteps()) {
            throw new \Exception('todo'); // @todo
        }

        return $this->next;
    }

    /**
     * @return ConditionalSubstepDefinition[]
     */
    public function getDetourSubsteps()
    {
        return $this->detour;
    }

    /**
     * @return bool
     */
    public function hasDetour()
    {
        return false === empty($this->detour);
    }

    /**
     * @return ConditionalSubstepDefinition[]
     */
    public function getDivergenceSubsteps()
    {
        return $this->divergence;
    }

    /**
     * @return bool
     */
    public function hasDivergence()
    {
        return false === empty($this->divergence);
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 FormZ project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Form\Definition\Step\Step\Substep;
15
16			use Romm\Formz\Form\Definition\AbstractFormDefinition;
17			use Romm\Formz\Form\Definition\Step\Step\Step;
18
19			class SubstepDefinition extends AbstractFormDefinition
20			{
21			/**
22			* @var string
23			* @validate NotEmpty
24			*/
25			protected $substep;
26
27			/**
28			* @var \Romm\Formz\Form\Definition\Step\Step\Substep\SubstepDefinition
29			*/
30			protected $next;
31
32			/**
33			* @var \Romm\Formz\Form\Definition\Step\Step\Substep\ConditionalSubstepDefinition[]
34			*/
35			protected $detour;
36
37			/**
38			* @var \Romm\Formz\Form\Definition\Step\Step\Substep\ConditionalSubstepDefinition[]
39			*/
40			protected $divergence;
41
42			/**
43			* @return Substep
44			*/
45			public function getSubstep()
46			{
47			return $this->withFirstParent(
48			Substeps::class,
49			function (Substeps $substeps) {
50			return $substeps->getEntry($this->substep);
51			}
52			);
53			}
54
55			public function getUniqueIdentifier()
56			{
57			$level = 1;
58
59			$this->alongParents(function ($parent) use (&$level) {
			0 ignored issues – show Documentation Bug introduced 2017-05-12 15:38 UTC by Report Bug Copy Issue Report The method `alongParents` does not exist on `object<Romm\Formz\Form\D...step\SubstepDefinition>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
60			if ($parent instanceof self) {
61			$level++;
62			}
63
64			if ($parent instanceof Step) {
65			return false;
66			}
67
68			return true;
69			});
70
71			return $this->getSubstep()->getIdentifier() . '-' . $level;
72			}
73
74			/**
75			* @todo
76			*
77			* @return bool
78			*/
79			public function isLast()
80			{
81			return false === $this->hasNextSubsteps()
82			&& false === $this->hasDetour()
83			&& false === $this->hasDivergence();
84			}
85
86			/**
87			* @return bool
88			*/
89			public function hasNextSubsteps()
90			{
91			return null !== $this->next;
92			}
93
94			/**
95			* @return SubstepDefinition
96			*/
97			public function getNextSubsteps()
98			{
99			if (false === $this->hasNextSubsteps()) {
100			throw new \Exception('todo'); // @todo
101			}
102
103			return $this->next;
104			}
105
106			/**
107			* @return ConditionalSubstepDefinition[]
108			*/
109			public function getDetourSubsteps()
110			{
111			return $this->detour;
112			}
113
114			/**
115			* @return bool
116			*/
117			public function hasDetour()
118			{
119			return false === empty($this->detour);
120			}
121
122			/**
123			* @return ConditionalSubstepDefinition[]
124			*/
125			public function getDivergenceSubsteps()
126			{
127			return $this->divergence;
128			}
129
130			/**
131			* @return bool
132			*/
133			public function hasDivergence()
134			{
135			return false === empty($this->divergence);
136			}
137			}
138

romm / formz

Push — middleware-wip ( 1f2854...9da264 )

SubstepDefinition A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like