FormRequestDataJavaScriptAssetHandler::getFieldsExistingMessages() - Code Metrics - Inspection of "[TASK] Todo!" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 915d6a...f488fc )

by Romain

created 2017-03-06 23:55 UTC

FormRequestDataJavaScriptAssetHandler::getFieldsExistingMessages() C

↳ Parent: Project

Complexity

Conditions	7
Paths	2

Size

Total Lines	32
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	17
nc	2
nop	0

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 Formz project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\AssetHandler\JavaScript;

use Romm\Formz\AssetHandler\AbstractAssetHandler;
use Romm\Formz\Error\FormzMessageInterface;
use Romm\Formz\Service\ArrayService;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Will handle the "one time run" data needed by JavaScript: the submitted
 * values, and others.
 */
class FormRequestDataJavaScriptAssetHandler extends AbstractAssetHandler
{

    /**
     * See class description.
     *
     * @return string
     */
    public function getFormRequestDataJavaScriptCode()
    {
        $submittedFormValues = [];
        $fieldsExistingMessages = [];
        $deactivatedFields = [];
        $formWasSubmitted = $this->getFormObject()->formWasSubmitted()
            ? 'true'
            : 'false';

        if ($formWasSubmitted) {
            $submittedFormValues = ArrayService::get()->arrayToJavaScriptJson($this->getSubmittedFormValues());
            $fieldsExistingMessages = ArrayService::get()->arrayToJavaScriptJson($this->getFieldsExistingMessages());
            $deactivatedFields = ArrayService::get()->arrayToJavaScriptJson($this->getDeactivatedFields());
        }

        $formName = GeneralUtility::quoteJSvalue($this->getFormObject()->getName());

        $javaScriptCode = <<<JS
(function() {
    Formz.Form.beforeInitialization($formName, function(form) {
        form.injectRequestData($submittedFormValues, $fieldsExistingMessages, $formWasSubmitted, $deactivatedFields)
    });
})();
JS;

        return $javaScriptCode;
    }

    /**
     * Will fetch the values of the fields of the submitted form, if a form has
     * been submitted.
     *
     * @return array
     */
    protected function getSubmittedFormValues()
    {
        $result = [];
        $formName = $this->getFormObject()->getName();
        $originalRequest = $this->getControllerContext()
            ->getRequest()
            ->getOriginalRequest();

        if (null !== $originalRequest
            && $originalRequest->hasArgument($formName)
        ) {
            $result = $originalRequest->getArgument($formName);
        }

        return $result;
    }

    /**
     * This function checks every message which may exist on every property of
     * the form (used to tell to JavaScript which messages already exist).
     *
     * @return array
     */
    protected function getFieldsExistingMessages()
    {
        $fieldsMessages = [];
        $formObject = $this->getFormObject();

        if ($formObject->formWasSubmitted()
            && $formObject->hasLastValidationResult()
        ) {
            $lastValidationResult = $this->getFormObject()->getLastValidationResult();

            foreach ($this->getFormObject()->getProperties() as $fieldName) {
                $result = $lastValidationResult->forProperty($fieldName);
                $messages = [];

                if ($result->hasErrors()) {
                    $messages['errors'] = $this->formatMessages($result->getErrors());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }

                if ($result->hasWarnings()) {
                    $messages['warnings'] = $this->formatMessages($result->getWarnings());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }

                if ($result->hasNotices()) {
                    $messages['notices'] = $this->formatMessages($result->getNotices());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }

                $fieldsMessages[$fieldName] = $messages;
            }
        }

        return $fieldsMessages;
    }

    /**
     * @param FormzMessageInterface[] $messages
     * @return array
     */
    protected function formatMessages(array $messages)
    {
        $sortedMessages = [];

        foreach ($messages as $message) {
            $validationName = $message->getValidationName();
            $messageKey = $message->getMessageKey();

            if (false === isset($sortedMessages[$validationName])) {
                $sortedMessages[$validationName] = [];
            }

            $sortedMessages[$validationName][$messageKey] = $message->render();
        }

        return $sortedMessages;
    }

    /**
     * @return array
     */
    protected function getDeactivatedFields()
    {
        return ($this->getFormObject()->hasLastValidationResult())
            ? array_keys($this->getFormObject()->getLastValidationResult()->getDeactivatedFields())
            : [];
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 Formz project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\AssetHandler\JavaScript;
15
16			use Romm\Formz\AssetHandler\AbstractAssetHandler;
17			use Romm\Formz\Error\FormzMessageInterface;
18			use Romm\Formz\Service\ArrayService;
19			use TYPO3\CMS\Core\Utility\GeneralUtility;
20
21			/**
22			* Will handle the "one time run" data needed by JavaScript: the submitted
23			* values, and others.
24			*/
25			class FormRequestDataJavaScriptAssetHandler extends AbstractAssetHandler
26			{
27
28			/**
29			* See class description.
30			*
31			* @return string
32			*/
33			public function getFormRequestDataJavaScriptCode()
34			{
35			$submittedFormValues = [];
36			$fieldsExistingMessages = [];
37			$deactivatedFields = [];
38			$formWasSubmitted = $this->getFormObject()->formWasSubmitted()
39			? 'true'
40			: 'false';
41
42			if ($formWasSubmitted) {
43			$submittedFormValues = ArrayService::get()->arrayToJavaScriptJson($this->getSubmittedFormValues());
44			$fieldsExistingMessages = ArrayService::get()->arrayToJavaScriptJson($this->getFieldsExistingMessages());
45			$deactivatedFields = ArrayService::get()->arrayToJavaScriptJson($this->getDeactivatedFields());
46			}
47
48			$formName = GeneralUtility::quoteJSvalue($this->getFormObject()->getName());
49
50			$javaScriptCode = <<<JS
51			(function() {
52			Formz.Form.beforeInitialization($formName, function(form) {
53			form.injectRequestData($submittedFormValues, $fieldsExistingMessages, $formWasSubmitted, $deactivatedFields)
54			});
55			})();
56			JS;
57
58			return $javaScriptCode;
59			}
60
61			/**
62			* Will fetch the values of the fields of the submitted form, if a form has
63			* been submitted.
64			*
65			* @return array
66			*/
67			protected function getSubmittedFormValues()
68			{
69			$result = [];
70			$formName = $this->getFormObject()->getName();
71			$originalRequest = $this->getControllerContext()
72			->getRequest()
73			->getOriginalRequest();
74
75			if (null !== $originalRequest
76			&& $originalRequest->hasArgument($formName)
77			) {
78			$result = $originalRequest->getArgument($formName);
79			}
80
81			return $result;
82			}
83
84			/**
85			* This function checks every message which may exist on every property of
86			* the form (used to tell to JavaScript which messages already exist).
87			*
88			* @return array
89			*/
90			protected function getFieldsExistingMessages()
91			{
92			$fieldsMessages = [];
93			$formObject = $this->getFormObject();
94
95			if ($formObject->formWasSubmitted()
96			&& $formObject->hasLastValidationResult()
97			) {
98			$lastValidationResult = $this->getFormObject()->getLastValidationResult();
99
100			foreach ($this->getFormObject()->getProperties() as $fieldName) {
101			$result = $lastValidationResult->forProperty($fieldName);
102			$messages = [];
103
104			if ($result->hasErrors()) {
105			$messages['errors'] = $this->formatMessages($result->getErrors());
			0 ignored issues – show Documentation introduced 2017-03-01 10:38 UTC by Report Bug Copy Issue Report `$result->getErrors()` is of type `array<integer,object<TYP...S\Extbase\Error\Error>>`, but the function expects a `array<integer,object<Rom...FormzMessageInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106			}
107
108			if ($result->hasWarnings()) {
109			$messages['warnings'] = $this->formatMessages($result->getWarnings());
			0 ignored issues – show Documentation introduced 2017-03-01 10:38 UTC by Report Bug Copy Issue Report `$result->getWarnings()` is of type `array<integer,object<TYP...Extbase\Error\Warning>>`, but the function expects a `array<integer,object<Rom...FormzMessageInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110			}
111
112			if ($result->hasNotices()) {
113			$messages['notices'] = $this->formatMessages($result->getNotices());
			0 ignored issues – show Documentation introduced 2017-03-01 10:38 UTC by Report Bug Copy Issue Report `$result->getNotices()` is of type `array<integer,object<TYP...\Extbase\Error\Notice>>`, but the function expects a `array<integer,object<Rom...FormzMessageInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
114			}
115
116			$fieldsMessages[$fieldName] = $messages;
117			}
118			}
119
120			return $fieldsMessages;
121			}
122
123			/**
124			* @param FormzMessageInterface[] $messages
125			* @return array
126			*/
127			protected function formatMessages(array $messages)
128			{
129			$sortedMessages = [];
130
131			foreach ($messages as $message) {
132			$validationName = $message->getValidationName();
133			$messageKey = $message->getMessageKey();
134
135			if (false === isset($sortedMessages[$validationName])) {
136			$sortedMessages[$validationName] = [];
137			}
138
139			$sortedMessages[$validationName][$messageKey] = $message->render();
140			}
141
142			return $sortedMessages;
143			}
144
145			/**
146			* @return array
147			*/
148			protected function getDeactivatedFields()
149			{
150			return ($this->getFormObject()->hasLastValidationResult())
151			? array_keys($this->getFormObject()->getLastValidationResult()->getDeactivatedFields())
152			: [];
153			}
154			}
155

romm / formz

Push — development ( 915d6a...f488fc )

FormRequestDataJavaScriptAssetHandler::getFieldsExistingMessages() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like