StepMiddlewareService::validateStep() - Code Metrics - Inspection of "[TASK] Inject dependencies in middlewares fetched..." - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — middleware-wip-tmp2 ( 51115e...a3478c )

by Romain

created 2017-04-14 15:19 UTC

StepMiddlewareService::validateStep() B

↳ Parent: StepMiddlewareService

Complexity

Conditions	7
Paths	8

Size

Total Lines	56
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	56
rs	7.7489
cc	7
eloc	25
nc	8
nop	1

How to fix Long Method

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Middleware\Item\Step\Service;

use Romm\Formz\Configuration\Form\Step\Step\Step;
use Romm\Formz\Core\Core;
use Romm\Formz\Error\FormResult;
use Romm\Formz\Form\FormObject\FormObject;
use Romm\Formz\Middleware\Item\FormValidation\FormValidationMiddlewareOption;
use Romm\Formz\Service\Traits\SelfInstantiateTrait;
use Romm\Formz\Validation\Validator\Form\AbstractFormValidator;
use TYPO3\CMS\Core\SingletonInterface;

class StepMiddlewareService implements SingletonInterface
{
    use SelfInstantiateTrait;

    const METADATA_STEP_KEY = 'core.step';

    /**
     * @var FormObject
     */
    protected $formObject;

    /**
     * @param FormObject $formObject
     */
    public function reset(FormObject $formObject)
    {
        $this->formObject = $formObject;
    }

    /**
     * @param Step $step
     * @return Step|null
     */
    public function validateStep(Step $step)
    {
        /*
         * The first step is always valid.
         */
        $firstStep = $this->formObject->getConfiguration()->getSteps()->getFirstStep();

        if ($step === $firstStep) {
            \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump(111, '111');
            return null;
        }

        /*
         * If there is no form instance, and the request is not in the first
         * step, obviously the user should not be there.
         */
        if (false === $this->formObject->hasForm()) {
            \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump(222, '222');
            return $firstStep;
        }

        /*
         * @todo
         */
        $stepsToTest = [];
        $stepToRedirect = $firstStep;
//        \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($step, '$step??');

        while ($step->hasPreviousStep()) {
            $step = $step->getPreviousStep();
            $stepsToTest[] = $step;
        }

        \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($stepsToTest, '$stepsToTest');

        foreach ($stepsToTest as $step) {
            $result = $this->getStepValidationResult($step);

            if ($result->hasErrors()) {
                $stepToRedirect = $step;
            }
        }

        \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($stepToRedirect, '$lastStepWithErrors 333');
        return $stepToRedirect;


        $key = 'core.step';
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        $metadata = $this->formObject->getFormMetadata()->getMetadata();

        if ($metadata->has(self::METADATA_STEP_KEY)) {
            // @todo
        } else {
            $metadata->set($key, 1);
        }
    }

    /**
     * @param Step $step
     * @return FormResult
     */
    protected function getStepValidationResult(Step $step)
    {
        /** @var FormValidationMiddlewareOption $formValidationMiddlewareOptions */
        $formValidationMiddlewareOptions = $this->formObject
            ->getConfiguration()
            ->getPresetMiddlewares()
            ->getFormValidationMiddleware()
            ->getOptions();

        /** @var AbstractFormValidator $validator */
        $validator = Core::instantiate(
            $formValidationMiddlewareOptions->getFormValidatorClassName(),
            ['name' => $this->formObject->getName()]
        );

        $validator->getDataObject()->setValidatedStep($step);

        return $validator->validate($this->formObject->getForm());
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 FormZ project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Middleware\Item\Step\Service;
15
16			use Romm\Formz\Configuration\Form\Step\Step\Step;
17			use Romm\Formz\Core\Core;
18			use Romm\Formz\Error\FormResult;
19			use Romm\Formz\Form\FormObject\FormObject;
20			use Romm\Formz\Middleware\Item\FormValidation\FormValidationMiddlewareOption;
21			use Romm\Formz\Service\Traits\SelfInstantiateTrait;
22			use Romm\Formz\Validation\Validator\Form\AbstractFormValidator;
23			use TYPO3\CMS\Core\SingletonInterface;
24
25			class StepMiddlewareService implements SingletonInterface
26			{
27			use SelfInstantiateTrait;
28
29			const METADATA_STEP_KEY = 'core.step';
30
31			/**
32			* @var FormObject
33			*/
34			protected $formObject;
35
36			/**
37			* @param FormObject $formObject
38			*/
39			public function reset(FormObject $formObject)
40			{
41			$this->formObject = $formObject;
42			}
43
44			/**
45			* @param Step $step
46			* @return Step\|null
47			*/
48			public function validateStep(Step $step)
49			{
50			/*
51			* The first step is always valid.
52			*/
53			$firstStep = $this->formObject->getConfiguration()->getSteps()->getFirstStep();
54
55			if ($step === $firstStep) {
56			\TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump(111, '111');
57			return null;
58			}
59
60			/*
61			* If there is no form instance, and the request is not in the first
62			* step, obviously the user should not be there.
63			*/
64			if (false === $this->formObject->hasForm()) {
65			\TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump(222, '222');
66			return $firstStep;
67			}
68
69			/*
70			* @todo
71			*/
72			$stepsToTest = [];
73			$stepToRedirect = $firstStep;
74			// \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($step, '$step??');
75
76			while ($step->hasPreviousStep()) {
77			$step = $step->getPreviousStep();
78			$stepsToTest[] = $step;
79			}
80
81			\TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($stepsToTest, '$stepsToTest');
82
83			foreach ($stepsToTest as $step) {
84			$result = $this->getStepValidationResult($step);
85
86			if ($result->hasErrors()) {
87			$stepToRedirect = $step;
88			}
89			}
90
91			\TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($stepToRedirect, '$lastStepWithErrors 333');
92			return $stepToRedirect;
93
94
95			$key = 'core.step';
			0 ignored issues – show Unused Code introduced 2017-04-14 15:22 UTC by Report Bug Copy Issue Report `$key = 'core.step';` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
96			$metadata = $this->formObject->getFormMetadata()->getMetadata();
97
98			if ($metadata->has(self::METADATA_STEP_KEY)) {
99			// @todo
100			} else {
101			$metadata->set($key, 1);
102			}
103			}
104
105			/**
106			* @param Step $step
107			* @return FormResult
108			*/
109			protected function getStepValidationResult(Step $step)
110			{
111			/** @var FormValidationMiddlewareOption $formValidationMiddlewareOptions */
112			$formValidationMiddlewareOptions = $this->formObject
113			->getConfiguration()
114			->getPresetMiddlewares()
115			->getFormValidationMiddleware()
116			->getOptions();
117
118			/** @var AbstractFormValidator $validator */
119			$validator = Core::instantiate(
120			$formValidationMiddlewareOptions->getFormValidatorClassName(),
121			['name' => $this->formObject->getName()]
122			);
123
124			$validator->getDataObject()->setValidatedStep($step);
125
126			return $validator->validate($this->formObject->getForm());
127			}
128			}
129

romm / formz

Push — middleware-wip-tmp2 ( 51115e...a3478c )

StepMiddlewareService::validateStep() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like