FormValidationMiddleware::process() - Code Metrics - Inspection of "[CLEANUP] Cleanup" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — middleware-wip ( 106169...2ebda9 )

by Romain

created 2017-03-13 13:04 UTC

FormValidationMiddleware::process() A

↳ Parent: FormValidationMiddleware

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	2
nop	0

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Middleware\Items\FormValidation;

use Romm\Formz\Middleware\Items\OnBeginMiddleware;
use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;

class FormValidationMiddleware extends OnBeginMiddleware implements SendsMiddlewareSignal
{
    /**
     * @todo
     */
    protected function process()
    {
        $formObject = $this->getFormObject();

        if ($formObject->hasForm()
            && $formObject->formWasSubmitted()
        ) {
            $validator = new \Romm\Formz\Validation\Validator\Form\DefaultFormValidator(['name' => $this->getFormObject()->getName()]);
            $result = $validator->validate($this->getFormObject()->getForm());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }

    /**
     * @return string
     */
    public function getSignalName()
    {
        return FormValidationSignal::class;
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 FormZ project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Middleware\Items\FormValidation;
15
16			use Romm\Formz\Middleware\Items\OnBeginMiddleware;
17			use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;
18
19			class FormValidationMiddleware extends OnBeginMiddleware implements SendsMiddlewareSignal
20			{
21			/**
22			* @todo
23			*/
24			protected function process()
25			{
26			$formObject = $this->getFormObject();
27
28			if ($formObject->hasForm()
29			&& $formObject->formWasSubmitted()
30			) {
31			$validator = new \Romm\Formz\Validation\Validator\Form\DefaultFormValidator(['name' => $this->getFormObject()->getName()]);
32			$result = $validator->validate($this->getFormObject()->getForm());
			0 ignored issues – show Unused Code introduced 2017-03-13 10:39 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
33			}
34			}
35
36			/**
37			* @return string
38			*/
39			public function getSignalName()
40			{
41			return FormValidationSignal::class;
42			}
43			}
44

romm / formz

Push — middleware-wip ( 106169...2ebda9 )

FormValidationMiddleware::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like