AbstractConfiguration - Code Metrics - Inspection of "WIP" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/improve-form-definitio... ( 2a8834...8225fe )

by Romain

created 2017-05-14 21:24 UTC

AbstractConfiguration A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	3
dl	0
loc	40
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getAbsolutePath()	4	1
A	checkDefinitionFreezeState()	6	2
A	isConfigurationFrozen()	12	3

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Configuration;

use Romm\ConfigurationObject\Service\Items\Parents\ParentsTrait;
use Romm\ConfigurationObject\Traits\ConfigurationObject\MagicMethodsTrait;
use TYPO3\CMS\Core\Utility\GeneralUtility;

abstract class AbstractConfiguration
{
    use MagicMethodsTrait;
    use ParentsTrait;

    /**
     * @param string $path
     * @return string
     */
    protected function getAbsolutePath($path)
    {
        return GeneralUtility::getFileAbsFileName($path);
    }

    /**
     * @todo
     */
    protected function checkDefinitionFreezeState()
    {
        if ($this->isConfigurationFrozen()) {
            throw new \Exception('todo');
        }
    }

    /**
     * @return bool
     */
    protected function isConfigurationFrozen()
    {
        $flag = false;

        if ($this instanceof Configuration) {
            $flag = $this->isConfigurationFrozenRoot();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } elseif ($this->hasParent(Configuration::class)) {
            $flag = $this->getFirstParent(Configuration::class)->isConfigurationFrozenRoot();
        }

        return $flag;
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 FormZ project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Configuration;
15
16			use Romm\ConfigurationObject\Service\Items\Parents\ParentsTrait;
17			use Romm\ConfigurationObject\Traits\ConfigurationObject\MagicMethodsTrait;
18			use TYPO3\CMS\Core\Utility\GeneralUtility;
19
20			abstract class AbstractConfiguration
21			{
22			use MagicMethodsTrait;
23			use ParentsTrait;
24
25			/**
26			* @param string $path
27			* @return string
28			*/
29			protected function getAbsolutePath($path)
30			{
31			return GeneralUtility::getFileAbsFileName($path);
32			}
33
34			/**
35			* @todo
36			*/
37			protected function checkDefinitionFreezeState()
38			{
39			if ($this->isConfigurationFrozen()) {
40			throw new \Exception('todo');
41			}
42			}
43
44			/**
45			* @return bool
46			*/
47			protected function isConfigurationFrozen()
48			{
49			$flag = false;
50
51			if ($this instanceof Configuration) {
52			$flag = $this->isConfigurationFrozenRoot();
			0 ignored issues – show Documentation Bug introduced 2017-05-14 21:26 UTC by Report Bug Copy Issue Report The method `isConfigurationFrozenRoot` does not exist on `object<Romm\Formz\Config...\AbstractConfiguration>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
53			} elseif ($this->hasParent(Configuration::class)) {
54			$flag = $this->getFirstParent(Configuration::class)->isConfigurationFrozenRoot();
55			}
56
57			return $flag;
58			}
59			}
60

romm / formz

Push — feature/improve-form-definitio... ( 2a8834...8225fe )

AbstractConfiguration A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like