FormzControllerTrait - Code Metrics - Inspection of "[TASK] Introduce `FormController`" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — middleware ( 1eef6b )

by Romain

created 2017-03-06 13:53 UTC

FormzControllerTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	0
dl	0
loc	43
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processRequest()	0	20	2
A	injectFormzControllerContext()	0	4	1

<?php
namespace Romm\Formz\Controller;

use TYPO3\CMS\Extbase\Mvc\RequestInterface;
use TYPO3\CMS\Extbase\Mvc\ResponseInterface;
use TYPO3\CMS\Extbase\Mvc\Web\Request;

trait FormzControllerTrait
{
    /**
     * @var FormzControllerContext
     */
    protected $formzControllerContext;

    /**
     * This function will dispatch the request to the form controller, which
     * will process the request depending on Formz configuration.
     *
     * @param RequestInterface  $request
     * @param ResponseInterface $response
     */
    public function processRequest(RequestInterface $request, ResponseInterface $response)
    {
        if (false === $this->formzControllerContext->isDispatched()) {
            $this->request = $request;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->actionMethodName = $this->resolveActionMethodName();
class MyClass { }

$x = new MyClass();
$x->foo = true;

            $this->initializeActionMethodArguments();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->initializeActionMethodValidators();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            /** @var Request $request */
            $this->formzControllerContext->setExtensionName($request->getControllerExtensionName());
            $this->formzControllerContext->setControllerName($request->getControllerName());
            $this->formzControllerContext->setActionName($request->getControllerActionName());
            $this->formzControllerContext->setArguments($this->arguments);
class MyClass { }

$x = new MyClass();
$x->foo = true;

            $this->forward('processForm', 'Form', 'Formz', $request->getArguments());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } else {
            parent::processRequest($request, $response);
        }
    }

    /**
     * @param FormzControllerContext $formzControllerContext
     */
    public function injectFormzControllerContext(FormzControllerContext $formzControllerContext)
    {
        $this->formzControllerContext = $formzControllerContext;
    }
}


1			<?php
2			namespace Romm\Formz\Controller;
3
4			use TYPO3\CMS\Extbase\Mvc\RequestInterface;
5			use TYPO3\CMS\Extbase\Mvc\ResponseInterface;
6			use TYPO3\CMS\Extbase\Mvc\Web\Request;
7
8			trait FormzControllerTrait
9			{
10			/**
11			* @var FormzControllerContext
12			*/
13			protected $formzControllerContext;
14
15			/**
16			* This function will dispatch the request to the form controller, which
17			* will process the request depending on Formz configuration.
18			*
19			* @param RequestInterface $request
20			* @param ResponseInterface $response
21			*/
22			public function processRequest(RequestInterface $request, ResponseInterface $response)
23			{
24			if (false === $this->formzControllerContext->isDispatched()) {
25			$this->request = $request;
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$this->actionMethodName = $this->resolveActionMethodName();
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report The property `actionMethodName` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report It seems like `resolveActionMethodName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27
28			$this->initializeActionMethodArguments();
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report It seems like `initializeActionMethodArguments()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			$this->initializeActionMethodValidators();
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report It seems like `initializeActionMethodValidators()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30
31			/** @var Request $request */
32			$this->formzControllerContext->setExtensionName($request->getControllerExtensionName());
33			$this->formzControllerContext->setControllerName($request->getControllerName());
34			$this->formzControllerContext->setActionName($request->getControllerActionName());
35			$this->formzControllerContext->setArguments($this->arguments);
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report The property `arguments` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36
37			$this->forward('processForm', 'Form', 'Formz', $request->getArguments());
			0 ignored issues – show Bug introduced 2017-03-06 13:56 UTC by Report Bug Copy Issue Report It seems like `forward()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38			} else {
39			parent::processRequest($request, $response);
40			}
41			}
42
43			/**
44			* @param FormzControllerContext $formzControllerContext
45			*/
46			public function injectFormzControllerContext(FormzControllerContext $formzControllerContext)
47			{
48			$this->formzControllerContext = $formzControllerContext;
49			}
50			}
51

romm / formz

Push — middleware ( 1eef6b )

FormzControllerTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like