Romm\Formz\Middleware\State\StateMiddlewareDependencyTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeSignal()	0	4	1
A	afterSignal()	0	4	1
B	getSignalObject()	0	23	5
A	bindMiddlewareState()	0	4	1

<?php
/*
 * 2017 Romain CANON <romain.hydrocanon@gmail.com>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Middleware\State;

use Romm\Formz\Middleware\Signal\After;
use Romm\Formz\Middleware\Signal\Before;
use Romm\Formz\Middleware\Signal\SendsMiddlewareSignal;
use Romm\Formz\Middleware\Signal\SignalObject;

trait StateMiddlewareDependencyTrait
{
    /**
     * @var MiddlewareState
     */
    private $state;

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::beforeSignal()
     *
     * @param string $signal
     * @return SignalObject
     */
    final public function beforeSignal($signal = null)
    {
        return $this->getSignalObject($signal, Before::class);
    }

    /**
     * @see \Romm\Formz\Middleware\Signal\SendsMiddlewareSignal::afterSignal()
     *
     * @param string $signal
     * @return SignalObject
     */
    final public function afterSignal($signal = null)
    {
        return $this->getSignalObject($signal, After::class);
    }

    /**
     * @param string $signal
     * @param string $type
     * @return SignalObject
     */
    private function getSignalObject($signal, $type)
    {
        if (false === $this instanceof SendsMiddlewareSignal) {
            // @todo exception
            throw new \Exception();
        }

        if (null === $signal) {
            if (count($this->getAllowedSignals()) > 1) {
                // @todo exception
                throw new \Exception();
            }

            $signal = reset($this->getAllowedSignals());

$this->getAllowedSignals() cannot be passed to reset() as the parameter $array expects a reference.

        }

        if (false === in_array($signal, $this->getAllowedSignals())) {
            // @todo exception
            throw new \Exception();
        }

        return new SignalObject($this->state, $signal, $type);

Accessing state on the interface Romm\Formz\Middleware\Signal\SendsMiddlewareSignal suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @param MiddlewareState $middlewareState
     */
    final public function bindMiddlewareState(MiddlewareState $middlewareState)
    {
        $this->state = $middlewareState;
    }
}