Field::setActivation() - Code Metrics - Inspection of "[FEATURE] Upgrade condition support" - romm/formz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — unit-tests-validation ( 34c29c...a12b55 )

by Romain

created 2017-02-27 12:35 UTC

Field::setActivation() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php
/*
 * 2017 Romain CANON <[email protected]>
 *
 * This file is part of the TYPO3 Formz project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\Configuration\Form\Field;

use Romm\ConfigurationObject\Service\Items\Parents\ParentsTrait;
use Romm\ConfigurationObject\Traits\ConfigurationObject\StoreArrayIndexTrait;
use Romm\Formz\Configuration\AbstractFormzConfiguration;
use Romm\Formz\Configuration\Form\Condition\Activation\ActivationInterface;
use Romm\Formz\Configuration\Form\Condition\Activation\ActivationUsageInterface;
use Romm\Formz\Configuration\Form\Condition\Activation\EmptyActivation;
use Romm\Formz\Configuration\Form\Field\Behaviour\Behaviour;
use Romm\Formz\Configuration\Form\Field\Settings\FieldSettings;
use Romm\Formz\Configuration\Form\Field\Validation\Validation;
use Romm\Formz\Configuration\Form\Form;
use Romm\Formz\Exceptions\EntryNotFoundException;

class Field extends AbstractFormzConfiguration implements ActivationUsageInterface
{
    use StoreArrayIndexTrait;
    use ParentsTrait;

    /**
     * @var \ArrayObject<Romm\Formz\Configuration\Form\Field\Validation\Validation>
     */
    protected $validation = [];

    /**
     * @var \ArrayObject<Romm\Formz\Configuration\Form\Field\Behaviour\Behaviour>
     */
    protected $behaviours = [];

    /**
     * @var \Romm\Formz\Configuration\Form\Condition\Activation\ActivationResolver
     * @validate Romm.Formz:Internal\ConditionIsValid
     */
    protected $activation;

    /**
     * @var \Romm\Formz\Configuration\Form\Field\Settings\FieldSettings
     */
    protected $settings;

    /**
     * Name of the field. By default, it is the key of this field in the array
     * containing all the fields for the parent form.
     *
     * @var string
     */
    private $fieldName;

    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->settings = new FieldSettings();
        $this->settings->setParents([$this]);

        $this->activation = EmptyActivation::get();
    }

    /**
     * @return Form
     */
    public function getForm()
    {
        return $this->getFirstParent(Form::class);
    }

    /**
     * @param string $validationName
     * @return bool
     */
    public function hasValidation($validationName)
    {
        return true === isset($this->validation[$validationName]);
    }

    /**
     * @return Validation[]
     */
    public function getValidation()
    {
        return $this->validation;
    }

    /**
     * @param Validation $validation
     */
    public function addValidation(Validation $validation)
    {
        $this->validation[$validation->getValidationName()] = $validation;
    }

    /**
     * @param $validationName
     * @return Validation
     * @throws EntryNotFoundException
     */
    public function getValidationByName($validationName)
    {
        if (false === $this->hasValidation($validationName)) {
            throw new EntryNotFoundException(
                'The validation "' . $validationName . '" was not found. Please use the function "hasValidation()" befo',
                1487672276
            );
        }

        return $this->validation[$validationName];
    }

    /**
     * @return Behaviour[]
     */
    public function getBehaviours()
    {
        return $this->behaviours;
    }

    /**
     * @return ActivationInterface
     */
    public function getActivation()
    {
        return $this->activation;
    }

    /**
     * @return bool
     */
    public function hasActivation()
    {
        return !($this->activation instanceof EmptyActivation);
    }

    /**
     * @param ActivationInterface $activation
     */
    public function setActivation(ActivationInterface $activation)
    {
        $activation->setRootObject($this);

        $this->activation = $activation;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * @return FieldSettings
     */
    public function getSettings()
    {
        return $this->settings;
    }

    /**
     * @return string
     */
    public function getFieldName()
    {
        if (null === $this->fieldName) {
            $this->fieldName = $this->getArrayIndex();
        }

        return $this->fieldName;
    }

    /**
     * @param string $fieldName
     */
    public function setFieldName($fieldName)
    {
        $this->fieldName = $fieldName;
    }
}


1			<?php
2			/*
3			* 2017 Romain CANON <[email protected]>
4			*
5			* This file is part of the TYPO3 Formz project.
6			* It is free software; you can redistribute it and/or modify it
7			* under the terms of the GNU General Public License, either
8			* version 3 of the License, or any later version.
9			*
10			* For the full copyright and license information, see:
11			* http://www.gnu.org/licenses/gpl-3.0.html
12			*/
13
14			namespace Romm\Formz\Configuration\Form\Field;
15
16			use Romm\ConfigurationObject\Service\Items\Parents\ParentsTrait;
17			use Romm\ConfigurationObject\Traits\ConfigurationObject\StoreArrayIndexTrait;
18			use Romm\Formz\Configuration\AbstractFormzConfiguration;
19			use Romm\Formz\Configuration\Form\Condition\Activation\ActivationInterface;
20			use Romm\Formz\Configuration\Form\Condition\Activation\ActivationUsageInterface;
21			use Romm\Formz\Configuration\Form\Condition\Activation\EmptyActivation;
22			use Romm\Formz\Configuration\Form\Field\Behaviour\Behaviour;
23			use Romm\Formz\Configuration\Form\Field\Settings\FieldSettings;
24			use Romm\Formz\Configuration\Form\Field\Validation\Validation;
25			use Romm\Formz\Configuration\Form\Form;
26			use Romm\Formz\Exceptions\EntryNotFoundException;
27
28			class Field extends AbstractFormzConfiguration implements ActivationUsageInterface
29			{
30			use StoreArrayIndexTrait;
31			use ParentsTrait;
32
33			/**
34			* @var \ArrayObject<Romm\Formz\Configuration\Form\Field\Validation\Validation>
35			*/
36			protected $validation = [];
37
38			/**
39			* @var \ArrayObject<Romm\Formz\Configuration\Form\Field\Behaviour\Behaviour>
40			*/
41			protected $behaviours = [];
42
43			/**
44			* @var \Romm\Formz\Configuration\Form\Condition\Activation\ActivationResolver
45			* @validate Romm.Formz:Internal\ConditionIsValid
46			*/
47			protected $activation;
48
49			/**
50			* @var \Romm\Formz\Configuration\Form\Field\Settings\FieldSettings
51			*/
52			protected $settings;
53
54			/**
55			* Name of the field. By default, it is the key of this field in the array
56			* containing all the fields for the parent form.
57			*
58			* @var string
59			*/
60			private $fieldName;
61
62			/**
63			* Constructor.
64			*/
65			public function __construct()
66			{
67			$this->settings = new FieldSettings();
68			$this->settings->setParents([$this]);
69
70			$this->activation = EmptyActivation::get();
71			}
72
73			/**
74			* @return Form
75			*/
76			public function getForm()
77			{
78			return $this->getFirstParent(Form::class);
79			}
80
81			/**
82			* @param string $validationName
83			* @return bool
84			*/
85			public function hasValidation($validationName)
86			{
87			return true === isset($this->validation[$validationName]);
88			}
89
90			/**
91			* @return Validation[]
92			*/
93			public function getValidation()
94			{
95			return $this->validation;
96			}
97
98			/**
99			* @param Validation $validation
100			*/
101			public function addValidation(Validation $validation)
102			{
103			$this->validation[$validation->getValidationName()] = $validation;
104			}
105
106			/**
107			* @param $validationName
108			* @return Validation
109			* @throws EntryNotFoundException
110			*/
111			public function getValidationByName($validationName)
112			{
113			if (false === $this->hasValidation($validationName)) {
114			throw new EntryNotFoundException(
115			'The validation "' . $validationName . '" was not found. Please use the function "hasValidation()" befo',
116			1487672276
117			);
118			}
119
120			return $this->validation[$validationName];
121			}
122
123			/**
124			* @return Behaviour[]
125			*/
126			public function getBehaviours()
127			{
128			return $this->behaviours;
129			}
130
131			/**
132			* @return ActivationInterface
133			*/
134			public function getActivation()
135			{
136			return $this->activation;
137			}
138
139			/**
140			* @return bool
141			*/
142			public function hasActivation()
143			{
144			return !($this->activation instanceof EmptyActivation);
145			}
146
147			/**
148			* @param ActivationInterface $activation
149			*/
150			public function setActivation(ActivationInterface $activation)
151			{
152			$activation->setRootObject($this);
153
154			$this->activation = $activation;
			0 ignored issues – show Documentation Bug introduced 2017-02-27 12:38 UTC by Report Bug Copy Issue Report `$activation` is of type `object<Romm\Formz\Config...on\ActivationInterface>`, but the property `$activation` was declared to be of type `object<Romm\Formz\Config...ion\ActivationResolver>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
155			}
156
157			/**
158			* @return FieldSettings
159			*/
160			public function getSettings()
161			{
162			return $this->settings;
163			}
164
165			/**
166			* @return string
167			*/
168			public function getFieldName()
169			{
170			if (null === $this->fieldName) {
171			$this->fieldName = $this->getArrayIndex();
172			}
173
174			return $this->fieldName;
175			}
176
177			/**
178			* @param string $fieldName
179			*/
180			public function setFieldName($fieldName)
181			{
182			$this->fieldName = $fieldName;
183			}
184			}
185

romm / formz

Push — unit-tests-validation ( 34c29c...a12b55 )

Field::setActivation() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like