Romm\Formz\ViewHelpers\Slot\RenderViewHelper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeArguments()	0	5	1
A	render()	0	6	1
A	renderStatic()	0	31	4

<?php
/*
 * 2017 Romain CANON <romain.hydrocanon@gmail.com>
 *
 * This file is part of the TYPO3 FormZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace Romm\Formz\ViewHelpers\Slot;

use Closure;
use Romm\Formz\Core\Core;
use Romm\Formz\Exceptions\ContextNotFoundException;
use Romm\Formz\Service\ViewHelper\Field\FieldViewHelperService;
use Romm\Formz\Service\ViewHelper\Slot\SlotViewHelperService;
use Romm\Formz\ViewHelpers\AbstractViewHelper;
use TYPO3\CMS\Core\Utility\ArrayUtility;
use TYPO3\CMS\Core\Utility\VersionNumberUtility;
use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;

/**
 * This is the rendering function for the `slot` view helper.
 *
 * @see \Romm\Formz\ViewHelpers\SlotViewHelper
 */
class RenderViewHelper extends AbstractViewHelper implements CompilableInterface
{
    /**
     * @var bool
     */
    protected $escapeOutput = false;

    /**
     * @inheritdoc
     */
    public function initializeArguments()
    {
        $this->registerArgument('slot', 'string', 'Instance of the slot which will be rendered.', true);
        $this->registerArgument('arguments', 'array', 'Arguments sent to the slot.', false, []);
    }

    /**
     * @inheritdoc
     */
    public function render()
    {
        parent::initializeArguments();

It seems like you call parent on a different method (initializeArguments() instead of render()). Are you sure this is correct? If so, you might want to change this to $this->initializeArguments().

        return self::renderStatic($this->arguments, $this->buildRenderChildrenClosure(), $this->renderingContext);

$this->renderingContext of type object<TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface> is not a sub-type of object<TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface>. It seems like you assume a child interface of the interface TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface to be always present.

    }

    /**
     * Will render the slot with the given name, only if the slot is found.
     *
     * @inheritdoc
     */
    public static function renderStatic(array $arguments, Closure $renderChildrenClosure, RenderingContextInterface $renderingContext)
    {
        /** @var FieldViewHelperService $fieldService */
        $fieldService = Core::instantiate(FieldViewHelperService::class);

        if (false === $fieldService->fieldContextExists()) {
            throw ContextNotFoundException::slotRenderViewHelperFieldContextNotFound();
        }

        /** @var SlotViewHelperService $slotService */
        $slotService = Core::instantiate(SlotViewHelperService::class);
        $slotName = $arguments['slot'];
        $result = '';

        if ($slotService->hasSlot($slotName)) {
            $currentVariables = version_compare(VersionNumberUtility::getCurrentTypo3Version(), '8.0.0', '<')
                ? $renderingContext->getTemplateVariableContainer()->getAll()

The method getTemplateVariableContainer() does not seem to exist on object<TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface>.

                : $renderingContext->getVariableProvider()->getAll();

            ArrayUtility::mergeRecursiveWithOverrule($currentVariables, $arguments['arguments']);

            $slotService->addTemplateVariables($slotName, $currentVariables);

            $slotClosure = $slotService->getSlotClosure($slotName);
            $result = $slotClosure();

            $slotService->restoreTemplateVariables($slotName);
        }

        return $result;
    }
}