romeritoCL / paypal-playground

src/Service/SettingsService.php

<?php

namespace App\Service;

use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpFoundation\Session\SessionInterface;

/**
 * Class SettingsService
 * @package App\Service
 */
class SettingsService
{
    /**
     * @var string[] Default Settings
     */
    protected $defaultSettings = [
        'settings-customer-currency' => 'GBP',
        'settings-customer-locale' => 'en_GB',
        'settings-customer-id' => 'customer_id_1',
        'settings-customer-name' => 'John',
        'settings-customer-family-name' => 'Doe',
        'settings-customer-email' => 'john.doe@paypal.com',
        'settings-customer-street' => '1 Westminster',
        'settings-customer-city' => 'London',
        'settings-customer-province' => 'London',
        'settings-customer-zip-code' => 'SW1A0AA',
        'settings-customer-country' => 'GB',
        'settings-merchant-maid' => null,
        'settings-merchant-name' => 'PlayGround Shop',
        'settings-merchant-email' => 'sb-meho36207476@business.example.com',
        'settings-merchant-street' => '2 Great George St, Westminster, London SW1P 3AD, Reino Unido',
        'settings-merchant-city' => 'London',
        'settings-merchant-province' => 'London',
        'settings-merchant-zip-code' => 'SW1P3AD',
        'settings-merchant-country' => 'GB',
        'settings-merchant-negative-testing' => null,
        'settings-item-name' => 'Make me proud! TEE (XXL)',
        'settings-item-price' => '31',
        'settings-item-shipping' => '5',
        'settings-item-sku' => 'TEE-MMP-XXL',
        'settings-item-description' => 'A tee that will make you proud and good looking, in an XXL size',
        'settings-item-purchase-description' => 'Tee sale: Make me proud! (XXL) SPECIAL OFFER',
        'settings-item-tax-name' => 'VAT',
        'settings-item-tax-value' => '21',
    ];

    /**
     * @var Session
     */
    public $session;

    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * SettingsService constructor.
     * @param SessionInterface $session
     * @param LoggerInterface $logger
     * @param string $maid
     */
    public function __construct(SessionInterface  $session, LoggerInterface $logger, string $maid)
    {
        $this->session = $session;

$session is of type Symfony\Component\HttpFoundation\Session\SessionInterface, but the property $session was declared to be of type Symfony\Component\HttpFoundation\Session\Session. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->logger = $logger;
        $this->defaultSettings['settings-merchant-maid'] = $maid;
    }

    /**
     * @param array $settings
     */
    public function storeSettings(array $settings): void
    {
        $this->session->set('settings', $settings);
    }

    /**
     * Clear settings to Defaults
     */
    public function clearSettings(): void
    {
        $this->session->set('settings', $this->defaultSettings);
    }

    /**
     * Check if settings are initialized
     * @return bool
     */
    public function isInitialized(): bool
    {
        $settings = $this->session->get('settings');
        if (is_array($settings)) {
            return true;
        }

        return false;
    }

    /**
     * @param string $settingKey
     *
     * @return string
     */
    public function getSetting(string $settingKey): ?string
    {
        $settings = $this->session->get('settings');
        if (array_key_exists($settingKey, $settings)) {
            return $settings[$settingKey];
        }

        return null;
    }
}