romeritoCL / paypal-playground

src/Service/Paypal/BillingAgreementService.php

<?php

namespace App\Service\Paypal;

/**
 * Class BillingAgreementService
 * @package App\Service\Paypal
 */
class BillingAgreementService extends IdentityService
{
    /**
     * @param $requestBody
     * @param string $url
     * @param array $inputHeaders
     * @param string $verb
     * @return array|string|null
     */
    public function doPaypalApiCall($requestBody, string $url, array $inputHeaders = [], string $verb = 'POST')
    {
        $accessToken = $this->getAccessToken();
        return $this->paypalApiCall($accessToken, $requestBody, $url, $inputHeaders, $verb);

It seems like $accessToken can also be of type null; however, parameter $accessToken of App\Service\Paypal\AbstractPaypalService::paypalApiCall() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * @param $requestBody
     * @return bool|string|null
     */
    public function createBillingAgreementToken($requestBody)
    {
        return $this->doPaypalApiCall(

The expression return $this->doPaypalApiCall($requestBody, 'https://api.sandbox.paypal.com/v1/billing-agreements/agreement-tokens') also could return the type array<string,mixed|string|true> which is incompatible with the documented return type boolean|null|string.

            $requestBody,
            'https://api.sandbox.paypal.com/v1/billing-agreements/agreement-tokens'
        );
    }

    /**
     * @param $requestBody
     * @return bool|string|null
     */
    public function createBillingAgreement($requestBody)
    {
        return $this->doPaypalApiCall(

The expression return $this->doPaypalApiCall($requestBody, 'https://api.sandbox.paypal.com/v1/billing-agreements/agreements') also could return the type array<string,mixed|string|true> which is incompatible with the documented return type boolean|null|string.

            $requestBody,
            'https://api.sandbox.paypal.com/v1/billing-agreements/agreements'
        );
    }

    /**
     * @param $requestBody
     * @param string $fraudnetSession
     * @return bool|string|null
     */
    public function createReferenceTransaction($requestBody, string $fraudnetSession)
    {
        return $this->doPaypalApiCall(

The expression return $this->doPaypalApiCall($requestBody, 'https://api.sandbox.paypal.com/v1/payments/payment', array('PAYPAL-CLIENT-METADATA-ID: ' . $fraudnetSession)) also could return the type array<string,mixed|string|true> which is incompatible with the documented return type boolean|null|string.

            $requestBody,
            'https://api.sandbox.paypal.com/v1/payments/payment',
            ['PAYPAL-CLIENT-METADATA-ID: '.$fraudnetSession]
        );
    }

    /**
     * @param string $billingAgreementId
     * @return bool|string|null
     */
    public function deleteBillingAgreement(string $billingAgreementId)
    {
        return $this->doPaypalApiCall(

The expression return $this->doPaypalApiCall(null, 'https://api.sandbox.paypal.com/v1/billing-agreements/agreements/' . $billingAgreementId . '/cancel') also could return the type array<string,mixed|string|true> which is incompatible with the documented return type boolean|null|string.

            null,
            'https://api.sandbox.paypal.com/v1/billing-agreements/agreements/' . $billingAgreementId . '/cancel'
        );
    }
}