PayoutService::getPayout() - Code Metrics - Inspection of "Features upgrade" - romeritoCL/paypal-playground - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Cesar

created 2020-09-03 19:24 UTC

PayoutService::getPayout() A

↳ Parent: PayoutService

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace App\Service\Paypal;

use Exception;
use PayPal\Api\Currency;
use PayPal\Api\Payout;
use PayPal\Api\PayoutBatch;
use PayPal\Api\PayoutItem;
use PayPal\Api\PayoutSenderBatchHeader;

/**
 * Class PayoutsService
 * @package App\Service\Paypal
 */
class PayoutService extends AbstractPaypalService
{
    /**
     * @param string $subject
     * @param string $note
     * @param string $receiverEmail
     * @param string $itemId
     * @param float $amount
     * @param string $currency
     * @return PayoutBatch|null
     */
    public function createPayout(
        string $subject,
        string $note,
        string $receiverEmail,
        string $itemId,
        float $amount,
        string $currency
    ): ?PayoutBatch {
        $payout = new Payout();
        $senderBatchHeader = new PayoutSenderBatchHeader();
        $senderBatchHeader
            ->setSenderBatchId(uniqid())
            ->setEmailSubject($subject);
        $senderItem = new PayoutItem();
        $senderItem->setRecipientType('Email')
            ->setNote($note)
            ->setReceiver($receiverEmail)
            ->setSenderItemId($itemId)
            ->setAmount(new Currency(json_encode((object)[
                'value' => $amount,
                'currency' => $currency,
            ])));

        $payout->setSenderBatchHeader($senderBatchHeader)
            ->addItem($senderItem);

        try {
            $payouts = $payout->create(null, $this->apiContext);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (Exception $e) {
            $this->logger->error('Error on PayPal::createPayout = ' . $e->getMessage());
            return null;
        }

        return $payouts;
    }

    /**
     * @param string $payoutId
     * @return PayoutBatch|null
     */
    public function getPayout(string $payoutId): ?PayoutBatch
    {
        $payout = new Payout();
        try {
            $payout = $payout->get($payoutId, $this->apiContext);
        } catch (Exception $e) {
            $this->logger->error('Error on PayPal::getPayout = ' . $e->getMessage());
            return null;
        }

        return $payout;
    }
}


1			<?php
2
3			namespace App\Service\Paypal;
4
5			use Exception;
6			use PayPal\Api\Currency;
7			use PayPal\Api\Payout;
8			use PayPal\Api\PayoutBatch;
9			use PayPal\Api\PayoutItem;
10			use PayPal\Api\PayoutSenderBatchHeader;
11
12			/**
13			* Class PayoutsService
14			* @package App\Service\Paypal
15			*/
16			class PayoutService extends AbstractPaypalService
17			{
18			/**
19			* @param string $subject
20			* @param string $note
21			* @param string $receiverEmail
22			* @param string $itemId
23			* @param float $amount
24			* @param string $currency
25			* @return PayoutBatch\|null
26			*/
27			public function createPayout(
28			string $subject,
29			string $note,
30			string $receiverEmail,
31			string $itemId,
32			float $amount,
33			string $currency
34			): ?PayoutBatch {
35			$payout = new Payout();
36			$senderBatchHeader = new PayoutSenderBatchHeader();
37			$senderBatchHeader
38			->setSenderBatchId(uniqid())
39			->setEmailSubject($subject);
40			$senderItem = new PayoutItem();
41			$senderItem->setRecipientType('Email')
42			->setNote($note)
43			->setReceiver($receiverEmail)
44			->setSenderItemId($itemId)
45			->setAmount(new Currency(json_encode((object)[
46			'value' => $amount,
47			'currency' => $currency,
48			])));
49
50			$payout->setSenderBatchHeader($senderBatchHeader)
51			->addItem($senderItem);
52
53			try {
54			$payouts = $payout->create(null, $this->apiContext);
			0 ignored issues – show Documentation introduced 2020-08-24 15:44 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			} catch (Exception $e) {
56			$this->logger->error('Error on PayPal::createPayout = ' . $e->getMessage());
57			return null;
58			}
59
60			return $payouts;
61			}
62
63			/**
64			* @param string $payoutId
65			* @return PayoutBatch\|null
66			*/
67			public function getPayout(string $payoutId): ?PayoutBatch
68			{
69			$payout = new Payout();
70			try {
71			$payout = $payout->get($payoutId, $this->apiContext);
72			} catch (Exception $e) {
73			$this->logger->error('Error on PayPal::getPayout = ' . $e->getMessage());
74			return null;
75			}
76
77			return $payout;
78			}
79			}
80

romeritoCL / paypal-playground

Pull Request — master (#4)

PayoutService::getPayout() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like