Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class UsersController extends AbstractController |
||
18 | { |
||
19 | /** |
||
20 | * @Route("/", name="index", methods={"GET"}) |
||
21 | * |
||
22 | * @return Response |
||
23 | */ |
||
24 | public function index(): Response |
||
28 | |||
29 | /** |
||
30 | * @Route("/create", name="create-get", methods={"GET"}) |
||
31 | * |
||
32 | * @return Response |
||
33 | */ |
||
34 | public function createUserGet(): Response |
||
38 | |||
39 | /** |
||
40 | * @Route("/create", name="create-post", methods={"POST"}) |
||
41 | * |
||
42 | * @return Response |
||
43 | */ |
||
44 | public function createUserPost(): Response |
||
45 | { |
||
46 | $request = Request::createFromGlobals(); |
||
47 | $userData = $request->request->all(); |
||
48 | $user = $this->hyperwalletService->getUserService()->create($userData); |
||
49 | return $this->render('default/dump.html.twig', [ |
||
50 | 'raw_result' => false, |
||
51 | 'result' => $user, |
||
52 | ]); |
||
53 | } |
||
54 | |||
55 | /** |
||
56 | * @Route("/search", name="search", methods={"GET"}) |
||
57 | * |
||
58 | * @return Response |
||
59 | * @throws HyperwalletApiException |
||
60 | */ |
||
61 | public function searchUser(): Response |
||
68 | |||
69 | /** |
||
70 | * @Route("/get/{userToken}", name="read", methods={"GET"}) |
||
71 | * |
||
72 | * @param string $userToken |
||
73 | * |
||
74 | * @return JsonResponse |
||
75 | */ |
||
76 | public function readUser(string $userToken): JsonResponse |
||
81 | |||
82 | /** |
||
83 | * @Route("/edit/{userToken}", name="edit-get", methods={"GET"}) |
||
84 | * |
||
85 | * @param string $userToken |
||
86 | * |
||
87 | * @return Response |
||
88 | */ |
||
89 | public function editUserGet(string $userToken): Response |
||
96 | |||
97 | /** |
||
98 | * @Route("/edit", name="edit-post", methods={"POST"}) |
||
99 | * |
||
100 | * @return Response |
||
101 | */ |
||
102 | public function editUserPost(): Response |
||
112 | |||
113 | /** |
||
114 | * @Route("/{userToken}/transfer-methods", name="transfer-methods-list", methods={"GET"}) |
||
115 | * |
||
116 | * @param string $userToken |
||
117 | * |
||
118 | * @return Response |
||
119 | */ |
||
120 | View Code Duplication | public function transferMethodsList(string $userToken): Response |
|
128 | |||
129 | /** |
||
130 | * @Route("/{userToken}/balance", name="balance", methods={"GET"}) |
||
131 | * |
||
132 | * @param string $userToken |
||
133 | * |
||
134 | * @return Response |
||
135 | */ |
||
136 | View Code Duplication | public function balanceList(string $userToken): Response |
|
144 | |||
145 | /** |
||
146 | * @Route("/{userToken}/transfer-methods/add", name="transfer-methods-add", methods={"GET"}) |
||
147 | * |
||
148 | * @param string $userToken |
||
149 | * |
||
150 | * @return Response |
||
151 | */ |
||
152 | View Code Duplication | public function transferMethodAdd(string $userToken): Response |
|
159 | |||
160 | /** |
||
161 | * @Route("/{userToken}/verify", name="verify", methods={"GET"}) |
||
162 | * |
||
163 | * @param string $userToken |
||
164 | * |
||
165 | * @return Response |
||
166 | */ |
||
167 | View Code Duplication | public function verify(string $userToken): Response |
|
174 | |||
175 | /** |
||
176 | * @Route("/{userToken}/authentication-token", name="auth-token", methods={"GET"}) |
||
177 | * |
||
178 | * @param string $userToken |
||
179 | * |
||
180 | * @return JsonResponse |
||
181 | */ |
||
182 | public function getAuthenticationToken(string $userToken): JsonResponse |
||
187 | |||
188 | /** |
||
189 | * @Route("/{userToken}/transfer-create", name="transfer-create", methods={"GET"}) |
||
190 | * |
||
191 | * @param string $userToken |
||
192 | * |
||
193 | * @return Response |
||
194 | */ |
||
195 | public function transferCreate(string $userToken): Response |
||
205 | } |
||
206 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: