App\Service\Braintree\ForwardApiService::directTokenization()

Complexity

Conditions	2
Paths	11

Size

Total Lines	29
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function directTokenization(string $paymentNonce, string $deviceData): ?array
    {
        try {
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_URL, $this->DIRECT_TOKEN_ENDPOINT);
            curl_setopt($ch, CURLOPT_HTTPHEADER, ['Content-Type:application/json']);
            curl_setopt(
                $ch,
                CURLOPT_USERPWD,
                $this->gateway->config->getPublicKey() . ':' . $this->gateway->config->getPrivateKey()
            );
            curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
            curl_setopt($ch, CURLOPT_POSTFIELDS, json_encode([
                'merchant_id' => $this->gateway->config->getMerchantId(),
                'payment_method_nonce' => $paymentNonce,
                'device_data' => $deviceData,
            ], true));

true of type true is incompatible with the type integer expected by parameter $flags of json_encode().

            curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
            $result = curl_exec($ch);
            $statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
            curl_close($ch);
        } catch (Exception $e) {
            $this->logger->error('Error on ForwardAPI::'.$this->DIRECT_TOKEN_ENDPOINT.' = ' . $e->getMessage());
            return null;
        }
        return ([
            'result' => (object) json_decode($result),

It seems like $result can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            'statusCode' => $statusCode
        ]);