SessionController::sandboxCredentialsCreate() - Code Metrics - Inspection of "Paypal refactor" - romeritoCL/paypal-playground - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Retried Inspection

Pull Request — master (#15)

by Cesar

created 2020-10-20 15:01 UTC

SessionController::sandboxCredentialsCreate() A

↳ Parent: SessionController

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	3
nc	2
nop	0

<?php

namespace App\Controller\Paypal;

use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

/**
 * Class SessionController
 * @package App\Controller\Paypal
 *
 * @Route("/paypal/session", name="paypal-session-")
 */
class SessionController extends AbstractController
{
    /**
     * @Route("/sandbox-credentials", name="sandbox-credentials-create", methods={"POST"})
     *
     * @return RedirectResponse
     */
    public function sandboxCredentialsCreate()
    {
        $request = Request::createFromGlobals();
        $clientId = $request->request->get('client_id', null);
        $clientSecret = $request->request->get('client_secret', null);
        if ($clientId && $clientSecret) {
            $this->paypalService->getSessionService()->updateCredentials($clientId, $clientSecret);
        }
        return $this->redirectToRoute('paypal-index');
    }

    /**
     * @Route("/sandbox-credentials/delete", name="sandbox-credentials-delete", methods={"GET"})
     *
     * @return RedirectResponse
     */
    public function sandboxCredentialsDelete()
    {
        $this->paypalService->getSessionService()->removeCredentials();

        return $this->redirectToRoute('paypal-index');
    }
}


1			<?php
2
3			namespace App\Controller\Paypal;
4
5			use Symfony\Component\HttpFoundation\RedirectResponse;
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\Routing\Annotation\Route;
8
9			/**
10			* Class SessionController
11			* @package App\Controller\Paypal
12			*
13			* @Route("/paypal/session", name="paypal-session-")
14			*/
15			class SessionController extends AbstractController
16			{
17			/**
18			* @Route("/sandbox-credentials", name="sandbox-credentials-create", methods={"POST"})
19			*
20			* @return RedirectResponse
21			*/
22			public function sandboxCredentialsCreate()
23			{
24			$request = Request::createFromGlobals();
25			$clientId = $request->request->get('client_id', null);
26			$clientSecret = $request->request->get('client_secret', null);
27			if ($clientId && $clientSecret) {
28			$this->paypalService->getSessionService()->updateCredentials($clientId, $clientSecret);
29			}
30			return $this->redirectToRoute('paypal-index');
31			}
32
33			/**
34			* @Route("/sandbox-credentials/delete", name="sandbox-credentials-delete", methods={"GET"})
35			*
36			* @return RedirectResponse
37			*/
38			public function sandboxCredentialsDelete()
39			{
40			$this->paypalService->getSessionService()->removeCredentials();
41
42			return $this->redirectToRoute('paypal-index');
43			}
44			}
45

romeritoCL / paypal-playground

Pull Request — master (#15)

SessionController::sandboxCredentialsCreate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like