App\Service\Braintree\WebhookService

Complexity

Total Complexity

5

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	processLocalPaymentMethodWebhook()	0	12	1
A	processOthers()	0	4	1
A	processWebhook()	0	9	1
A	processPaymentMethodRevokedByCustomer()	0	4	1
A	generateTestNotification()	0	5	1

<?php

namespace App\Service\Braintree;

use Braintree\Exception\InvalidSignature;
use Braintree\WebhookNotification;

/**
 * Class WebhookService
 * @package App\Service\Braintree
 */
class WebhookService extends AbstractBraintreeService
{
    /**
     * @param string $btSignature
     * @param string $btPayload
     * @return bool
     * @throws InvalidSignature
     */
    public function processWebhook(string $btSignature, string $btPayload): bool
    {
        $webhookNotification = $this->gateway->webhookNotification()->parse($btSignature, $btPayload);
        return match ($webhookNotification->kind) {
            WebhookNotification::LOCAL_PAYMENT_COMPLETED =>
            $this->processLocalPaymentMethodWebhook($webhookNotification),
            WebhookNotification::PAYMENT_METHOD_REVOKED_BY_CUSTOMER =>
            $this->processPaymentMethodRevokedByCustomer($webhookNotification),default =>
            $this->processOthers($webhookNotification)
        };
    }

    /**
     * @param string $type
     * @return array
     */
    public function generateTestNotification(string $type): array
    {
        return $this->gateway->webhookTesting()->sampleNotification(

The expression return $this->gateway->webhookTesting()->sampleNotification(constant(Braintree\WebhookNotification::class . '::' . $type), sha1(time())) returns the type Braintree\Webhook which is incompatible with the type-hinted return array.

            constant(WebhookNotification::class .'::'. $type),
            sha1(time())
        );
    }

    /**
     * @param WebhookNotification $webhookNotification
     * @return bool
     */
    protected function processLocalPaymentMethodWebhook(WebhookNotification $webhookNotification): bool
    {
        //match the original amount and cart thanks to the $webhookNotification->paymentId;
        $this->gateway->transaction()->sale([
            'amount' => $this->settingsService->getSetting('settings-item-price'),
            'options' => [
                'submitForSettlement' => true,
            ],
            'paymentMethodNonce' => $webhookNotification->subject['localPayment']['paymentMethodNonce']
        ]);

        return true;
    }

    /**
     * @param WebhookNotification $webhookNotification
     * @return bool
     */
    protected function processPaymentMethodRevokedByCustomer(WebhookNotification $webhookNotification): bool
    {
        error_log(print_r($webhookNotification));

It seems like print_r($webhookNotification) can also be of type true; however, parameter $message of error_log() does only seem to accept string, maybe add an additional type check?

        return true;
    }

    /**
     * @param WebhookNotification $webhookNotification
     * @return bool
     */
    protected function processOthers(WebhookNotification $webhookNotification): bool
    {
        error_log(print_r($webhookNotification));

It seems like print_r($webhookNotification) can also be of type true; however, parameter $message of error_log() does only seem to accept string, maybe add an additional type check?

        return true;
    }
}