App\Controller\Paypal\VaultController

Complexity

Total Complexity

1

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	vaultPayment()	0	6	1

<?php

namespace App\Controller\Paypal;

use App\Service\SettingsService;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class VaultController
 * @package App\Controller\Paypal
 *
 * @Route("/paypal/vault", name="paypal-vault-")
 */
class VaultController extends AbstractController
{
    /**
     * @Route("/payment", name="payment", methods={"GET"}, defaults={"action" = "payment"})
     *
     * @param string $action
     *
     * @return Response
     */
    public function vaultPayment(string $action)
    {
        $customerId = $this->settingsService->getSetting('settings-customer-id');
        $dataUserIdToken = $this->paypalService->getVaultService()->getDataUserIdToken($customerId);

It seems like $customerId can also be of type null; however, parameter $clientId of App\Service\Paypal\VaultService::getDataUserIdToken() does only seem to accept string, maybe add an additional type check?

        return $this->render('paypal/vault/'. $action .'.html.twig', [
            'dataUserIdToken' => $dataUserIdToken,

        ]);
    }
}