Issues in SMSenderExtension.php - New Issues - Inspection of "Remove dependencies without PHP 7.2 support" - romanmatyus/SMSender - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a4d031...ae8bc9 )

by Roman

created 2018-10-05 19:51 UTC

src/RM/SMSender/DI/SMSenderExtension.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace RM\SMSender\DI;

use Nette\Reflection\ClassType;
use Nette\Configurator;
use Nette\DI\Compiler;
use Nette\DI\CompilerExtension;
use Nette\DI\Helpers;

/**
 * Nette DI extension for SMSender.
 */
class SMSenderExtension extends CompilerExtension
{
	/** @var array */
	public $defaults = [
		'config' => [],
		'senderClass' => 'RM\SMSender\EuroSms\Sender',
		'setDebugMode' => FALSE,
		'messageClass' => 'RM\SMSender\EuroSms\Message',
		'messageFactoryClass' => 'RM\SMSender\MessageFactory',
		'message' => [
			'setFrom' => NULL,
			'signature' => NULL,
		],
	];

	public function beforeCompile()
	{
		$builder = $this->getContainerBuilder();

		$config = $this->validateConfig($this->defaults);

		$sender = $builder->addDefinition($this->prefix('sender'))

			->setClass($config['senderClass']);

		foreach ($config as $method => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
			$tmp = new $config['senderClass'];
			if ((new ClassType($tmp))->hasMethod($method)) {
				$sender->addSetup($method, [$value]);
			}
		}

		if ($config['message']['signature']) {
			$sender->addSetup('$service->onBeforeSend[] = function ($message) { $message->setText($message->getText() . ?); };', [$config['message']['signature']]);
		}

		$builder->addDefinition($this->prefix('messageFactory'))

			->setClass($config['messageFactoryClass'])
			->addSetup('$class', [$config['messageClass']])
			->addSetup('$params', [$config['message']]);
	}

	/**
	 * Register extension to DI Container.
	 * @param  Configurator $config
	 */
	public static function register(Configurator $config)
	{
		$config->onCompile[] = function (Configurator $config, Compiler $compiler) {
			$compiler->addExtension('smsender', new SMSenderExtension());
		};
	}
}


1		<?php
2
3		namespace RM\SMSender\DI;
4
5		use Nette\Reflection\ClassType;
6		use Nette\Configurator;
7		use Nette\DI\Compiler;
8		use Nette\DI\CompilerExtension;
9		use Nette\DI\Helpers;
10
11		/**
12		* Nette DI extension for SMSender.
13		*/
14	1	class SMSenderExtension extends CompilerExtension
15		{
16		/** @var array */
17		public $defaults = [
18		'config' => [],
19		'senderClass' => 'RM\SMSender\EuroSms\Sender',
20		'setDebugMode' => FALSE,
21		'messageClass' => 'RM\SMSender\EuroSms\Message',
22		'messageFactoryClass' => 'RM\SMSender\MessageFactory',
23		'message' => [
24		'setFrom' => NULL,
25		'signature' => NULL,
26		],
27		];
28
29		public function beforeCompile()
30		{
31	1	$builder = $this->getContainerBuilder();
32
33	1	$config = $this->validateConfig($this->defaults);
34
35	1	$sender = $builder->addDefinition($this->prefix('sender'))
		0 ignored issues – show Deprecated Code introduced 2018-10-05 08:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Nette\DI\ServiceDefinition::setClass()` has been deprecated with message: Use setType() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
36	1	->setClass($config['senderClass']);
37
38	1	foreach ($config as $method => $value) {
		0 ignored issues – show Bug introduced 2016-04-23 23:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$config` of type `array\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
39	1	$tmp = new $config['senderClass'];
40	1	if ((new ClassType($tmp))->hasMethod($method)) {
41	1	$sender->addSetup($method, [$value]);
42		}
43		}
44
45	1	if ($config['message']['signature']) {
46	1	$sender->addSetup('$service->onBeforeSend[] = function ($message) { $message->setText($message->getText() . ?); };', [$config['message']['signature']]);
47		}
48
49	1	$builder->addDefinition($this->prefix('messageFactory'))
		0 ignored issues – show Deprecated Code introduced 2018-10-05 08:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Nette\DI\ServiceDefinition::setClass()` has been deprecated with message: Use setType() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
50	1	->setClass($config['messageFactoryClass'])
51	1	->addSetup('$class', [$config['messageClass']])
52	1	->addSetup('$params', [$config['message']]);
53	1	}
54
55		/**
56		* Register extension to DI Container.
57		* @param Configurator $config
58		*/
59		public static function register(Configurator $config)
60		{
61	1	$config->onCompile[] = function (Configurator $config, Compiler $compiler) {
62	1	$compiler->addExtension('smsender', new SMSenderExtension());
63	1	};
64	1	}
65		}
66

romanmatyus / SMSender

Push — master ( a4d031...ae8bc9 )

src/RM/SMSender/DI/SMSenderExtension.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like