Issues in Session.php (master) - Issues in master - rolfvreijdenberger/izzum-statemachine - Measure and Improve Code Quality continuously with Scrutinizer

Issues (35)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/statemachine/persistence/Session.php (6 issues)

Labels

Coding Style 6

Severity

Minor 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace izzum\statemachine\persistence;
use izzum\statemachine\Identifier;
use izzum\statemachine\State;

/**
 * the Session persistence adapter uses php sessions for persistence.
 *
 * Keep in mind that:
 * - php sessions have a limited lifetime.
 * - php sessions itself can have a different backend adapter, configurable.
 * - php sessions are only valid for one user's session (unless a session id is
 * forced)
 *
 * A simple adapter for a proof of concept and an example.
 * it's possible to use this adapter for for instance gui wizards.
 * 
 * see also the /examples/session for how to use this adapter.
 *
 * TRICKY: make sure output is not already sent when instantiating this adapter.
 *
 * @author Rolf Vreijdenberger
 */
class Session extends Adapter {
    /**
     * the namespace of the session
     *
     * @var string
     */
    private $namespace;

    /**
     *
     * @param string $namespace
     *            optional, defaults to izzum
     * @param string $session_id
     *            optional force a session id, used for testing purposes
     */
    public function __construct($namespace = 'izzum', $session_id = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (session_status() === PHP_SESSION_NONE) {
            if ($session_id !== null) {
                session_id($session_id);
            }
            session_start();
        }
        $this->namespace = $namespace;
        if (!isset($_SESSION)) {
            $_SESSION = array();
        }
        if (!isset($_SESSION [$this->namespace])) {
            $_SESSION [$this->namespace] = array();
        }
    }
    

    /**
     * {@inheritDoc}
     */
    public function processGetState(Identifier $identifier)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $key = $identifier->getId();
        if (isset($_SESSION [$this->namespace] [$key])) {
            $state = $_SESSION [$this->namespace] [$key]->state;
        } else {
            $state = State::STATE_UNKNOWN;
        }
        return $state;
    }

    
    /**
     * {@inheritDoc}
     */
    protected function insertState(Identifier $identifier, $state, $message = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // set object on the session
        $data = new StorageData($identifier, $state, $message);
        $key = $identifier->getId();
        $_SESSION [$this->namespace] [$key] = $data;
    }
    
    /**
     * {@inheritDoc}
     */
    protected function updateState(Identifier $identifier, $state, $message = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // set object on the session
        $data = new StorageData($identifier, $state, $message);
        $key = $identifier->getId();
        $_SESSION [$this->namespace] [$key] = $data;
    }

    /**
     * {@inheritDoc}
     */
    public function isPersisted(Identifier $identifier)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $key = $identifier->getId();
        if (!isset($_SESSION [$this->namespace] [$key])) {
            return false;
        }
        return true;
    }

    /**
     * {@inheritDoc}
     */
    public function getEntityIds($machine, $state = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ids = array();
        foreach ($_SESSION [$this->namespace] as $key => $storage) {
            if (strstr($key, $machine)) {
                if ($state) {
                    if ($storage->state === $state) {
                        $ids [] = $storage->id;
                    }
                } else {
                    $ids [] = $storage->id;
                }
            }
        }
        return $ids;
    }
}


1			<?php
2			namespace izzum\statemachine\persistence;
3			use izzum\statemachine\Identifier;
4			use izzum\statemachine\State;
5
6			/**
7			* the Session persistence adapter uses php sessions for persistence.
8			*
9			* Keep in mind that:
10			* - php sessions have a limited lifetime.
11			* - php sessions itself can have a different backend adapter, configurable.
12			* - php sessions are only valid for one user's session (unless a session id is
13			* forced)
14			*
15			* A simple adapter for a proof of concept and an example.
16			* it's possible to use this adapter for for instance gui wizards.
17			*
18			* see also the /examples/session for how to use this adapter.
19			*
20			* TRICKY: make sure output is not already sent when instantiating this adapter.
21			*
22			* @author Rolf Vreijdenberger
23			*/
24			class Session extends Adapter {
25			/**
26			* the namespace of the session
27			*
28			* @var string
29			*/
30			private $namespace;
31
32			/**
33			*
34			* @param string $namespace
35			* optional, defaults to izzum
36			* @param string $session_id
37			* optional force a session id, used for testing purposes
38			*/
39			public function __construct($namespace = 'izzum', $session_id = null)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `__construct` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
40			{
41			if (session_status() === PHP_SESSION_NONE) {
42			if ($session_id !== null) {
43			session_id($session_id);
44			}
45			session_start();
46			}
47			$this->namespace = $namespace;
48			if (!isset($_SESSION)) {
49			$_SESSION = array();
50			}
51			if (!isset($_SESSION [$this->namespace])) {
52			$_SESSION [$this->namespace] = array();
53			}
54			}
55
56
57			/**
58			* {@inheritDoc}
59			*/
60			public function processGetState(Identifier $identifier)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `processGetState` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
61			{
62			$key = $identifier->getId();
63			if (isset($_SESSION [$this->namespace] [$key])) {
64			$state = $_SESSION [$this->namespace] [$key]->state;
65			} else {
66			$state = State::STATE_UNKNOWN;
67			}
68			return $state;
69			}
70
71
72			/**
73			* {@inheritDoc}
74			*/
75			protected function insertState(Identifier $identifier, $state, $message = null)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `insertState` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
76			{
77			// set object on the session
78			$data = new StorageData($identifier, $state, $message);
79			$key = $identifier->getId();
80			$_SESSION [$this->namespace] [$key] = $data;
81			}
82
83			/**
84			* {@inheritDoc}
85			*/
86			protected function updateState(Identifier $identifier, $state, $message = null)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `updateState` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
87			{
88			// set object on the session
89			$data = new StorageData($identifier, $state, $message);
90			$key = $identifier->getId();
91			$_SESSION [$this->namespace] [$key] = $data;
92			}
93
94			/**
95			* {@inheritDoc}
96			*/
97			public function isPersisted(Identifier $identifier)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `isPersisted` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
98			{
99			$key = $identifier->getId();
100			if (!isset($_SESSION [$this->namespace] [$key])) {
101			return false;
102			}
103			return true;
104			}
105
106			/**
107			* {@inheritDoc}
108			*/
109			public function getEntityIds($machine, $state = null)
			0 ignored issues – show Coding Style introduced 2017-08-22 19:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `getEntityIds` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
110			{
111			$ids = array();
112			foreach ($_SESSION [$this->namespace] as $key => $storage) {
113			if (strstr($key, $machine)) {
114			if ($state) {
115			if ($storage->state === $state) {
116			$ids [] = $storage->id;
117			}
118			} else {
119			$ids [] = $storage->id;
120			}
121			}
122			}
123			return $ids;
124			}
125			}
126

GitHub Access Token became invalid

Issues (35)

Security Analysis no request data

src/statemachine/persistence/Session.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

rolfvreijdenberger / izzum-statemachine

GitHub Access Token became invalid

Issues (35)

Security Analysis no request data

src/statemachine/persistence/Session.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like