| Conditions | 4 |
| Paths | 1 |
| Total Lines | 55 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 2 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public function boot() |
||
| 15 | { |
||
| 16 | $self = $this; |
||
| 17 | |||
| 18 | response()->macro('jsend', [$this, 'jsend']); |
||
| 19 | |||
| 20 | response()->macro('resource_fetched', function ( |
||
| 21 | $data = null, |
||
| 22 | $presenter = null, |
||
| 23 | $message = 'Resource Fetched Successfully', |
||
| 24 | $status = 'success', |
||
| 25 | $code = 200 |
||
| 26 | ) use ($self) { |
||
| 27 | return $self->jsend($data, $presenter, $status, $message, $code); |
||
| 28 | }); |
||
| 29 | |||
| 30 | response()->macro('resource_updated', function ( |
||
| 31 | $data = null, |
||
| 32 | $presenter = null, |
||
| 33 | $message = 'Resource Updated Successfully', |
||
| 34 | $status = 'success', |
||
| 35 | $code = 200 |
||
| 36 | ) use ($self) { |
||
| 37 | return $self->jsend($data, $presenter, $status, $message, $code); |
||
| 38 | }); |
||
| 39 | |||
| 40 | response()->macro('resource_created', function ( |
||
| 41 | $data = null, |
||
| 42 | $presenter = null, |
||
| 43 | $message = 'Resource Created Successfully', |
||
| 44 | $status = 'success', |
||
| 45 | $code = 201 |
||
| 46 | ) use ($self) { |
||
| 47 | return $self->jsend($data, $presenter, $status, $message, $code); |
||
| 48 | }); |
||
| 49 | |||
| 50 | response()->macro('resource_deleted', function ( |
||
| 51 | $data = null, |
||
| 52 | $presenter = null, |
||
| 53 | $message = null, |
||
| 54 | $status = null, |
||
| 55 | $code = 204 |
||
| 56 | ) use ($self) { |
||
| 57 | return $self->jsend($data, $presenter, $status, $message, $code); |
||
| 58 | }); |
||
| 59 | |||
| 60 | response()->macro('jsend_error', function ( |
||
| 61 | \Exception $e, |
||
| 62 | $message = null, |
||
| 63 | $code = null |
||
| 64 | ) use ($self) { |
||
| 65 | $message = $message ? $message : $e->getMessage(); |
||
| 66 | $code = $code ? $code : $e->getCode(); |
||
| 67 | $code = $code ? $code : 400; |
||
| 68 | return $self->jsend(null, null, 'error', $message, $code); |
||
| 69 | }); |
||
| 107 |