roelofjan-elsinga / aloia-cms

src/Models/Traits/Updatable.php

<?php

namespace AloiaCms\Models\Traits;

use Carbon\Carbon;

trait Updatable
{
    /**
     * Set the update date
     *
     * @param Carbon $update_date
     * @return $this
     */
    public function setUpdateDate(Carbon $update_date)
    {
        $this->matter['update_date'] = $update_date->toDateTimeString();

The property matter does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->has_changes = true;

The property has_changes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * Get the update date
     *
     * @return Carbon|null
     */
    public function getUpdateDate()
    {
        if (!isset($this->matter['update_date']) || empty($this->matter['update_date'])) {
            return null;
        }

        return Carbon::createFromFormat('Y-m-d H:i:s', $this->matter['update_date']);

The expression return Carbon\Carbon::createFromFormat('Y-m-d H:i:s', $this->matter['update_date']) could also return false which is incompatible with the documented return type Carbon\Carbon|null. Did you maybe forget to handle an error condition?

    }
}