roelofjan-elsinga / aloia-cms

src/Models/Traits/Postable.php

<?php

namespace AloiaCms\Models\Traits;

use Carbon\Carbon;

trait Postable
{
    /**
     * Set the post date
     *
     * @param Carbon $post_date
     * @return $this
     */
    public function setPostDate(Carbon $post_date)
    {
        $this->matter['post_date'] = $post_date->toDateString();

The property matter does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->has_changes = true;

The property has_changes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;
    }

    /**
     * Get the post date
     *
     * @return Carbon|null
     */
    public function getPostDate(): ?Carbon
    {
        if (!isset($this->matter['post_date']) || empty($this->matter['post_date'])) {
            return null;
        }

        return Carbon::createFromFormat('Y-m-d', $this->matter['post_date']);

The expression return Carbon\Carbon::createFromFormat('Y-m-d', $this->matter['post_date']) could return the type false which is incompatible with the type-hinted return Carbon\Carbon|null. Consider adding an additional type-check to rule them out.

    }
}