Issues in User.php (master) - Issues in master - roelofjan-elsinga/aloia-cms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

src/Auth/User.php (1 issue)

Labels

Severity

Major 1

<?php

namespace AloiaCms\Auth;

use AloiaCms\Models\Contracts\ModelInterface;
use AloiaCms\Models\Model;
use Illuminate\Contracts\Auth\Authenticatable;

class User extends Model implements Authenticatable
{
    protected $folder = 'users';

    protected $required_fields = [
        'identifier'
    ];

    public function findById(string $file_name): ModelInterface
    {
        $instance = new static();

        $instance->setFileName($file_name);
        $instance->set('identifier', $file_name);

        return $instance;
    }

    public static function find(string $file_name): ModelInterface
    {
        $instance = new static();
        $instance->setFileName($file_name);
        $instance->set('identifier', $file_name);

        return $instance;
    }

    public function getAuthIdentifierName()
    {
        return 'identifier';
    }

    public function getAuthIdentifier()
    {
        return $this->filename();
    }

    public function getAuthPassword()
    {
        return $this->get('password');
    }

    public function getRememberToken()
    {
        return $this->get('remember_token');
    }

    public function setRememberToken($value)
    {
        return $this->set('remember_token', $value);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    public function getRememberTokenName()
    {
        return 'remember_token';
    }

    public function getAuthPasswordName()
    {
        return 'password';
    }
}


1			<?php
2
3			namespace AloiaCms\Auth;
4
5			use AloiaCms\Models\Contracts\ModelInterface;
6			use AloiaCms\Models\Model;
7			use Illuminate\Contracts\Auth\Authenticatable;
8
9			class User extends Model implements Authenticatable
10			{
11			protected $folder = 'users';
12
13			protected $required_fields = [
14			'identifier'
15			];
16
17			public function findById(string $file_name): ModelInterface
18			{
19			$instance = new static();
20
21			$instance->setFileName($file_name);
22			$instance->set('identifier', $file_name);
23
24			return $instance;
25			}
26
27			public static function find(string $file_name): ModelInterface
28			{
29			$instance = new static();
30			$instance->setFileName($file_name);
31			$instance->set('identifier', $file_name);
32
33			return $instance;
34			}
35
36			public function getAuthIdentifierName()
37			{
38			return 'identifier';
39			}
40
41			public function getAuthIdentifier()
42			{
43			return $this->filename();
44			}
45
46			public function getAuthPassword()
47			{
48			return $this->get('password');
49			}
50
51			public function getRememberToken()
52			{
53			return $this->get('remember_token');
54			}
55
56			public function setRememberToken($value)
57			{
58			return $this->set('remember_token', $value);
			0 ignored issues – show Bug Best Practice introduced 2022-04-30 13:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->set('remember_token', $value)` returns the type `AloiaCms\Auth\User` which is incompatible with the return type mandated by `Illuminate\Contracts\Aut...ble::setRememberToken()` of `void`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
59			}
60
61			public function getRememberTokenName()
62			{
63			return 'remember_token';
64			}
65
66			public function getAuthPasswordName()
67			{
68			return 'password';
69			}
70			}
71

GitHub Access Token became invalid

Issues (32)

src/Auth/User.php (1 issue)

Labels

Severity

Introduced By

roelofjan-elsinga / aloia-cms

GitHub Access Token became invalid

Issues (32)

src/Auth/User.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like