robsonvleite / datalayer

src/CrudTrait.php

<?php

namespace CoffeeCode\DataLayer;

use DateTime;
use PDOException;

/**
 * Trait CrudTrait
 * @package CoffeeCode\DataLayer
 */
trait CrudTrait
{
    /**
     * @param array $data
     * @return int|null
     * @throws PDOException
     */
    protected function create(array $data): ?int
    {
        if ($this->timestamps) {
            $data["created_at"] = (new DateTime("now"))->format("Y-m-d H:i:s");
            $data["updated_at"] = $data["created_at"];
        }

        try {
            $columns = implode(", ", array_keys($data));
            $values = ":" . implode(", :", array_keys($data));

            $stmt = Connect::getInstance($this->database)->prepare("INSERT INTO {$this->entity} ({$columns}) VALUES ({$values})");
            $stmt->execute($this->filter($data));

            return Connect::getInstance($this->database)->lastInsertId();

The expression return CoffeeCode\DataLayer\Connect::getInstance($this->database)->lastInsertId() returns the type string which is incompatible with the type-hinted return integer|null.

        } catch (PDOException $exception) {
            $this->fail = $exception;

The property fail does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return null;
        }
    }

    /**
     * @param array $data
     * @param string $terms
     * @param string $params
     * @return int|null
     * @throws PDOException
     */
    protected function update(array $data, string $terms, string $params): ?int
    {
        if ($this->timestamps) {
            $data["updated_at"] = (new DateTime("now"))->format("Y-m-d H:i:s");
        }

        try {
            $dateSet = [];
            foreach ($data as $bind => $value) {
                $dateSet[] = "{$bind} = :{$bind}";
            }
            $dateSet = implode(", ", $dateSet);
            parse_str($params, $params);

$params of type string is incompatible with the type array expected by parameter $result of parse_str().

            $stmt = Connect::getInstance($this->database)->prepare("UPDATE {$this->entity} SET {$dateSet} WHERE {$terms}");
            $stmt->execute($this->filter(array_merge($data, $params)));
            return $stmt->rowCount();
        } catch (PDOException $exception) {
            $this->fail = $exception;

The property fail does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return null;
        }
    }

    /**
     * @param string $terms
     * @param string|null $params
     * @return bool
     */
    public function delete(string $terms, ?string $params): bool
    {
        try {
            $stmt = Connect::getInstance($this->database)->prepare("DELETE FROM {$this->entity} WHERE {$terms}");
            if ($params) {
                parse_str($params, $params);

$params of type string is incompatible with the type array expected by parameter $result of parse_str().

                $stmt->execute($params);
                return true;
            }

            $stmt->execute();
            return true;
        } catch (PDOException $exception) {
            $this->fail = $exception;

The property fail does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return false;
        }
    }

    /**
     * @param array $data
     * @return array|null
     */
    private function filter(array $data): ?array
    {
        $filter = [];
        foreach ($data as $key => $value) {
            $filter[$key] = (is_null($value) ? null : filter_var($value, FILTER_DEFAULT));
        }
        return $filter;
    }
}