Course::studentsWhoPrefer() - Code Metrics - Inspection of "Add Join feature to DataLayer for 1-N and N-N rela..." - robsonvleite/datalayer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#29)

unknown

created 2020-09-03 15:37 UTC

Course::studentsWhoPrefer() A

↳ Parent: Course

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	11
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	13
rs	9.9

<?php

namespace Example\Models;

use CoffeeCode\DataLayer\DataLayer;

class Course extends DataLayer
{
    /**
     * Course constructor.
     */
    public function __construct()
    {
        parent::__construct("courses", ["name"], "id", false);
    }

    /**
     * @return array|null
     */
    public function studentsWhoPrefer(): ?array
    {
        $students = new Student();
        return $this
            ->select("*, courses.name as course_name")
            ->join(
                $students, 
                'courses.id', '=', 'students.preferred_course')
            ->where(
                'courses.id = :id', 
                "id={$this->id}")

            ->limit(5)
            ->fetch(true);
    }

    /**
     * @return array|null
     */
    public function studentsThatFinished(): ?array
    {
        $students = new Student();
        $studentCourse = new StudentCourse();

        return $this
            ->select()
            ->join(
                $studentCourse,
                "courses.id", "=", "student_course.idcourse"
            )
            ->join(
                $students,
                "students.id", "=", "student_course.idstudent"
            )
            ->where(
                "courses.id = :id",
                "id={$this->id}"

            )
            ->fetch(true);
    }
}

1			<?php
2
3			namespace Example\Models;
4
5			use CoffeeCode\DataLayer\DataLayer;
6
7			class Course extends DataLayer
8			{
9			/**
10			* Course constructor.
11			*/
12			public function __construct()
13			{
14			parent::__construct("courses", ["name"], "id", false);
15			}
16
17			/**
18			* @return array\|null
19			*/
20			public function studentsWhoPrefer(): ?array
21			{
22			$students = new Student();
23			return $this
24			->select("*, courses.name as course_name")
25			->join(
26			$students,
27			'courses.id', '=', 'students.preferred_course')
28			->where(
29			'courses.id = :id',
30			"id={$this->id}")
			0 ignored issues – show Bug Best Practice introduced 2020-09-03 15:39 UTC by Report Bug Copy Issue Report The property `id` does not exist on `Example\Models\Course`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
31			->limit(5)
32			->fetch(true);
33			}
34
35			/**
36			* @return array\|null
37			*/
38			public function studentsThatFinished(): ?array
39			{
40			$students = new Student();
41			$studentCourse = new StudentCourse();
42
43			return $this
44			->select()
45			->join(
46			$studentCourse,
47			"courses.id", "=", "student_course.idcourse"
48			)
49			->join(
50			$students,
51			"students.id", "=", "student_course.idstudent"
52			)
53			->where(
54			"courses.id = :id",
55			"id={$this->id}"
			0 ignored issues – show Bug Best Practice introduced 2020-09-03 15:39 UTC by Report Bug Copy Issue Report The property `id` does not exist on `Example\Models\Course`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
56			)
57			->fetch(true);
58			}
59			}

robsonvleite / datalayer

Pull Request — master (#29)

Course::studentsWhoPrefer() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like