roboapp\crud\Move

Complexity

Total Complexity

8

Size/Duplication

Total Lines	85
Duplicated Lines	47.06 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	2	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	8	2
A	moveDown()	20	20	3
A	moveUp()	20	20	3

<?php
/**
 * @link https://github.com/roboapp
 * @copyright Copyright (c) 2016 Roboapp
 * @license [MIT License](https://opensource.org/licenses/MIT)
 */

namespace roboapp\crud;

/**
 * Action switches custom sorting position of the existing record.
 *
 * @author iRipVanWinkle <iripvanwinkle@gmail.com>
 * @since 1.0
 */
class Move extends BaseAction
{
    const UP = 1;
    const DOWN = 2;

    /**
     * Attribute in model
     * @var string
     */
    public $positionAttribute = 'position';

    /**
     * Direction to move
     * @var integer
     */
    public $direction;

    /**
     * Move model
     * @param mixed $id ID of the model to be moved
     * @return mixed
     */
    public function run($id)
    {
        if ((int)$this->direction === self::UP) {
            return $this->moveUp($id);
        } else {
            return $this->moveDown($id);
        }
    }

    /**
     * Move model to down
     * @param mixed $id ID of the model to be moved down
     * @return mixed
     * @throws \yii\web\NotFoundHttpException
     */
    protected function moveDown($id)

This method seems to be duplicated in your project.

    {
        $model = $this->getModel($id);
        $orderAttrName = $this->positionAttribute;
        $orderDir = SORT_ASC;

        $swapModel = $model::find()
            ->where(['>', $orderAttrName, $model->$orderAttrName])
            ->orderBy([$orderAttrName => $orderDir])
            ->one();

        if ($swapModel) {
            $newOrderNumeric = $swapModel->$orderAttrName;
            $swapModel->$orderAttrName = $model->$orderAttrName;
            $model->$orderAttrName = $newOrderNumeric;
            $swapModel->save() && $model->save();
        }

        return $this->redirect($model);
    }

    /**
     * Move model to up
     * @param mixed $id ID of the model to be moved up
     * @return mixed
     * @throws \yii\web\NotFoundHttpException
     */
    protected function moveUp($id)

This method seems to be duplicated in your project.

    {
        $model = $this->getModel($id);
        $orderAttrName = $this->positionAttribute;
        $orderDir = SORT_DESC;

        $swapModel = $model::find()
            ->where(['<', $orderAttrName, $model->$orderAttrName])
            ->orderBy([$orderAttrName => $orderDir])
            ->one();

        if ($swapModel) {
            $newOrderNumeric = $swapModel->$orderAttrName;
            $swapModel->$orderAttrName = $model->$orderAttrName;
            $model->$orderAttrName = $newOrderNumeric;
            $swapModel->save() && $model->save();
        }

        return $this->redirect($model);
    }
}