Issues in HttpResponseAdapter.php - New Issues - Inspection of "API Add fromPsr7 method, update tests and readme" - robbieaverill/psr7-adapters - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 704539...2a5253 )

by Robbie

created 2017-01-15 02:15 UTC

src/HttpResponseAdapter.php (4 issues)

Labels

Bug 4

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Robbie\Psr7;

use GuzzleHttp\Psr7\Response;
use Psr\Http\Message\ResponseInterface;
use Robbie\Psr7\AbstractHttpAdapter;
use SilverStripe\Control\HTTPResponse;

/**
 * @package psr7-adapters
 */
class HttpResponseAdapter extends AbstractHttpAdapter
{
    /**
     * {@inheritDoc}
     */
    public function toPsr7($input)
    {
        return new Response(
            $input->getStatusCode(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $input->getHeaders(),
            $input->getBody(),
            $this->getProtocolVersion(),
            $input->getStatusDescription()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        );
    }

    /**
     * {@inheritDoc}
     */
    public function fromPsr7($input)
    {
        $adapted = new HTTPResponse(
            (string) $input->getBody(),
            $input->getStatusCode(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $input->getReasonPhrase()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        $this->importHeaders($input, $adapted);

        return $adapted;
    }
}


Push — master ( 704539...2a5253 )

src/HttpResponseAdapter.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Robbie\Psr7;
4
5			use GuzzleHttp\Psr7\Response;
6			use Psr\Http\Message\ResponseInterface;
7			use Robbie\Psr7\AbstractHttpAdapter;
8			use SilverStripe\Control\HTTPResponse;
9
10			/**
11			* @package psr7-adapters
12			*/
13			class HttpResponseAdapter extends AbstractHttpAdapter
14			{
15			/**
16			* {@inheritDoc}
17			*/
18			public function toPsr7($input)
19			{
20			return new Response(
21			$input->getStatusCode(),
			0 ignored issues – show Bug introduced 2017-01-15 02:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getStatusCode` does only exist in `SilverStripe\Control\HTTPResponse`, but not in `SilverStripe\Control\HTTPRequest`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22			$input->getHeaders(),
23			$input->getBody(),
24			$this->getProtocolVersion(),
25			$input->getStatusDescription()
			0 ignored issues – show Bug introduced 2017-01-15 02:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getStatusDescription` does only exist in `SilverStripe\Control\HTTPResponse`, but not in `SilverStripe\Control\HTTPRequest`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26			);
27			}
28
29			/**
30			* {@inheritDoc}
31			*/
32			public function fromPsr7($input)
33			{
34			$adapted = new HTTPResponse(
35			(string) $input->getBody(),
36			$input->getStatusCode(),
			0 ignored issues – show Bug introduced 2017-01-15 02:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\MessageInterface` as the method `getStatusCode()` does only exist in the following implementations of said interface: `GuzzleHttp\Psr7\Response`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37			$input->getReasonPhrase()
			0 ignored issues – show Bug introduced 2017-01-15 02:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\MessageInterface` as the method `getReasonPhrase()` does only exist in the following implementations of said interface: `GuzzleHttp\Psr7\Response`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
38			);
39
40			$this->importHeaders($input, $adapted);
41
42			return $adapted;
43			}
44			}
45

robbieaverill / psr7-adapters

Push — master ( 704539...2a5253 )

src/HttpResponseAdapter.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like