rob006 /
yii2-dev
Complex classes like ActiveRelationTrait often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ActiveRelationTrait, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 24 | trait ActiveRelationTrait |
||
| 25 | { |
||
| 26 | /** |
||
| 27 | * @var bool whether this query represents a relation to more than one record. |
||
| 28 | * This property is only used in relational context. If true, this relation will |
||
| 29 | * populate all query results into AR instances using [[Query::all()|all()]]. |
||
| 30 | * If false, only the first row of the results will be retrieved using [[Query::one()|one()]]. |
||
| 31 | */ |
||
| 32 | public $multiple; |
||
| 33 | /** |
||
| 34 | * @var ActiveRecord the primary model of a relational query. |
||
| 35 | * This is used only in lazy loading with dynamic query options. |
||
| 36 | */ |
||
| 37 | public $primaryModel; |
||
| 38 | /** |
||
| 39 | * @var array the columns of the primary and foreign tables that establish a relation. |
||
| 40 | * The array keys must be columns of the table for this relation, and the array values |
||
| 41 | * must be the corresponding columns from the primary table. |
||
| 42 | * Do not prefix or quote the column names as this will be done automatically by Yii. |
||
| 43 | * This property is only used in relational context. |
||
| 44 | */ |
||
| 45 | public $link; |
||
| 46 | /** |
||
| 47 | * @var array|object the query associated with the junction table. Please call [[via()]] |
||
| 48 | * to set this property instead of directly setting it. |
||
| 49 | * This property is only used in relational context. |
||
| 50 | * @see via() |
||
| 51 | */ |
||
| 52 | public $via; |
||
| 53 | /** |
||
| 54 | * @var string the name of the relation that is the inverse of this relation. |
||
| 55 | * For example, an order has a customer, which means the inverse of the "customer" relation |
||
| 56 | * is the "orders", and the inverse of the "orders" relation is the "customer". |
||
| 57 | * If this property is set, the primary record(s) will be referenced through the specified relation. |
||
| 58 | * For example, `$customer->orders[0]->customer` and `$customer` will be the same object, |
||
| 59 | * and accessing the customer of an order will not trigger new DB query. |
||
| 60 | * This property is only used in relational context. |
||
| 61 | * @see inverseOf() |
||
| 62 | */ |
||
| 63 | public $inverseOf; |
||
| 64 | |||
| 65 | |||
| 66 | /** |
||
| 67 | * Clones internal objects. |
||
| 68 | */ |
||
| 69 | 12 | public function __clone() |
|
| 79 | |||
| 80 | /** |
||
| 81 | * Specifies the relation associated with the junction table. |
||
| 82 | * |
||
| 83 | * Use this method to specify a pivot record/table when declaring a relation in the [[ActiveRecord]] class: |
||
| 84 | * |
||
| 85 | * ```php |
||
| 86 | * class Order extends ActiveRecord |
||
| 87 | * { |
||
| 88 | * public function getOrderItems() { |
||
| 89 | * return $this->hasMany(OrderItem::className(), ['order_id' => 'id']); |
||
| 90 | * } |
||
| 91 | * |
||
| 92 | * public function getItems() { |
||
| 93 | * return $this->hasMany(Item::className(), ['id' => 'item_id']) |
||
| 94 | * ->via('orderItems'); |
||
| 95 | * } |
||
| 96 | * } |
||
| 97 | * ``` |
||
| 98 | * |
||
| 99 | * @param string $relationName the relation name. This refers to a relation declared in [[primaryModel]]. |
||
| 100 | * @param callable $callable a PHP callback for customizing the relation associated with the junction table. |
||
| 101 | * Its signature should be `function($query)`, where `$query` is the query to be customized. |
||
| 102 | * @return $this the relation object itself. |
||
| 103 | */ |
||
| 104 | 66 | public function via($relationName, callable $callable = null) |
|
| 114 | |||
| 115 | /** |
||
| 116 | * Sets the name of the relation that is the inverse of this relation. |
||
| 117 | * For example, an order has a customer, which means the inverse of the "customer" relation |
||
| 118 | * is the "orders", and the inverse of the "orders" relation is the "customer". |
||
| 119 | * If this property is set, the primary record(s) will be referenced through the specified relation. |
||
| 120 | * For example, `$customer->orders[0]->customer` and `$customer` will be the same object, |
||
| 121 | * and accessing the customer of an order will not trigger a new DB query. |
||
| 122 | * |
||
| 123 | * Use this method when declaring a relation in the [[ActiveRecord]] class: |
||
| 124 | * |
||
| 125 | * ```php |
||
| 126 | * public function getOrders() |
||
| 127 | * { |
||
| 128 | * return $this->hasMany(Order::className(), ['customer_id' => 'id'])->inverseOf('customer'); |
||
| 129 | * } |
||
| 130 | * ``` |
||
| 131 | * |
||
| 132 | * @param string $relationName the name of the relation that is the inverse of this relation. |
||
| 133 | * @return $this the relation object itself. |
||
| 134 | */ |
||
| 135 | 9 | public function inverseOf($relationName) |
|
| 140 | |||
| 141 | /** |
||
| 142 | * Finds the related records for the specified primary record. |
||
| 143 | * This method is invoked when a relation of an ActiveRecord is being accessed in a lazy fashion. |
||
| 144 | * @param string $name the relation name |
||
| 145 | * @param ActiveRecordInterface|BaseActiveRecord $model the primary model |
||
| 146 | * @return mixed the related record(s) |
||
| 147 | * @throws InvalidParamException if the relation is invalid |
||
| 148 | */ |
||
| 149 | 55 | public function findFor($name, $model) |
|
| 161 | |||
| 162 | /** |
||
| 163 | * If applicable, populate the query's primary model into the related records' inverse relationship. |
||
| 164 | * @param array $result the array of related records as generated by [[populate()]] |
||
| 165 | * @since 2.0.9 |
||
| 166 | */ |
||
| 167 | 9 | private function addInverseRelations(&$result) |
|
| 189 | |||
| 190 | /** |
||
| 191 | * Finds the related records and populates them into the primary models. |
||
| 192 | * @param string $name the relation name |
||
| 193 | * @param array $primaryModels primary models |
||
| 194 | * @return array the related models |
||
| 195 | * @throws InvalidConfigException if [[link]] is invalid |
||
| 196 | */ |
||
| 197 | 75 | public function populateRelation($name, &$primaryModels) |
|
| 289 | |||
| 290 | /** |
||
| 291 | * @param ActiveRecordInterface[] $primaryModels primary models |
||
| 292 | * @param ActiveRecordInterface[] $models models |
||
| 293 | * @param string $primaryName the primary relation name |
||
| 294 | * @param string $name the relation name |
||
| 295 | */ |
||
| 296 | 9 | private function populateInverseRelation(&$primaryModels, $models, $primaryName, $name) |
|
| 353 | |||
| 354 | /** |
||
| 355 | * @param array $models |
||
| 356 | * @param array $link |
||
| 357 | * @param array $viaModels |
||
| 358 | * @param array $viaLink |
||
| 359 | * @param bool $checkMultiple |
||
| 360 | * @return array |
||
| 361 | */ |
||
| 362 | 66 | private function buildBuckets($models, $link, $viaModels = null, $viaLink = null, $checkMultiple = true) |
|
| 402 | |||
| 403 | |||
| 404 | /** |
||
| 405 | * Indexes buckets by column name. |
||
| 406 | * |
||
| 407 | * @param array $buckets |
||
| 408 | * @param string|callable $indexBy the name of the column by which the query results should be indexed by. |
||
| 409 | * This can also be a callable (e.g. anonymous function) that returns the index value based on the given row data. |
||
| 410 | * @return array |
||
| 411 | */ |
||
| 412 | 15 | private function indexBuckets($buckets, $indexBy) |
|
| 425 | |||
| 426 | /** |
||
| 427 | * @param array $attributes the attributes to prefix |
||
| 428 | * @return array |
||
| 429 | */ |
||
| 430 | 136 | private function prefixKeyColumns($attributes) |
|
| 454 | |||
| 455 | /** |
||
| 456 | * @param array $models |
||
| 457 | */ |
||
| 458 | 136 | private function filterByModels($models) |
|
| 501 | |||
| 502 | /** |
||
| 503 | * @param ActiveRecordInterface|array $model |
||
| 504 | * @param array $attributes |
||
| 505 | * @return string |
||
| 506 | */ |
||
| 507 | 66 | private function getModelKey($model, $attributes) |
|
| 519 | |||
| 520 | /** |
||
| 521 | * @param mixed $value raw key value. |
||
| 522 | * @return string normalized key value. |
||
| 523 | */ |
||
| 524 | 66 | private function normalizeModelKey($value) |
|
| 533 | |||
| 534 | /** |
||
| 535 | * @param array $primaryModels either array of AR instances or arrays |
||
| 536 | * @return array |
||
| 537 | */ |
||
| 538 | 21 | private function findJunctionRows($primaryModels) |
|
| 553 | } |
||
| 554 |
Loading history...
If you access a property on an interface, you most likely code against a concrete implementation of the interface.
Available Fixes
Adding an additional type check:
Changing the type hint: