Complex classes like BaseStringHelper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BaseStringHelper, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
21 | class BaseStringHelper |
||
22 | { |
||
23 | /** |
||
24 | * Returns the number of bytes in the given string. |
||
25 | * This method ensures the string is treated as a byte array by using `mb_strlen()`. |
||
26 | * @param string $string the string being measured for length |
||
27 | * @return int the number of bytes in the given string. |
||
28 | */ |
||
29 | 229 | public static function byteLength($string) |
|
33 | |||
34 | /** |
||
35 | * Returns the portion of string specified by the start and length parameters. |
||
36 | * This method ensures the string is treated as a byte array by using `mb_substr()`. |
||
37 | * @param string $string the input string. Must be one character or longer. |
||
38 | * @param int $start the starting position |
||
39 | * @param int $length the desired portion length. If not specified or `null`, there will be |
||
40 | * no limit on length i.e. the output will be until the end of the string. |
||
41 | * @return string the extracted part of string, or FALSE on failure or an empty string. |
||
42 | * @see http://www.php.net/manual/en/function.substr.php |
||
43 | */ |
||
44 | 77 | public static function byteSubstr($string, $start, $length = null) |
|
48 | |||
49 | /** |
||
50 | * Returns the trailing name component of a path. |
||
51 | * This method is similar to the php function `basename()` except that it will |
||
52 | * treat both \ and / as directory separators, independent of the operating system. |
||
53 | * This method was mainly created to work on php namespaces. When working with real |
||
54 | * file paths, php's `basename()` should work fine for you. |
||
55 | * Note: this method is not aware of the actual filesystem, or path components such as "..". |
||
56 | * |
||
57 | * @param string $path A path string. |
||
58 | * @param string $suffix If the name component ends in suffix this will also be cut off. |
||
59 | * @return string the trailing name component of the given path. |
||
60 | * @see http://www.php.net/manual/en/function.basename.php |
||
61 | */ |
||
62 | 12 | public static function basename($path, $suffix = '') |
|
74 | |||
75 | /** |
||
76 | * Returns parent directory's path. |
||
77 | * This method is similar to `dirname()` except that it will treat |
||
78 | * both \ and / as directory separators, independent of the operating system. |
||
79 | * |
||
80 | * @param string $path A path string. |
||
81 | * @return string the parent directory's path. |
||
82 | * @see http://www.php.net/manual/en/function.basename.php |
||
83 | */ |
||
84 | 5 | public static function dirname($path) |
|
93 | |||
94 | /** |
||
95 | * Truncates a string to the number of characters specified. |
||
96 | * |
||
97 | * @param string $string The string to truncate. |
||
98 | * @param int $length How many characters from original string to include into truncated string. |
||
99 | * @param string $suffix String to append to the end of truncated string. |
||
100 | * @param string $encoding The charset to use, defaults to charset currently used by application. |
||
101 | * @param bool $asHtml Whether to treat the string being truncated as HTML and preserve proper HTML tags. |
||
102 | * This parameter is available since version 2.0.1. |
||
103 | * @return string the truncated string. |
||
104 | */ |
||
105 | 1 | public static function truncate($string, $length, $suffix = '...', $encoding = null, $asHtml = false) |
|
117 | |||
118 | /** |
||
119 | * Truncates a string to the number of words specified. |
||
120 | * |
||
121 | * @param string $string The string to truncate. |
||
122 | * @param int $count How many words from original string to include into truncated string. |
||
123 | * @param string $suffix String to append to the end of truncated string. |
||
124 | * @param bool $asHtml Whether to treat the string being truncated as HTML and preserve proper HTML tags. |
||
125 | * This parameter is available since version 2.0.1. |
||
126 | * @return string the truncated string. |
||
127 | */ |
||
128 | 1 | public static function truncateWords($string, $count, $suffix = '...', $asHtml = false) |
|
141 | |||
142 | /** |
||
143 | * Truncate a string while preserving the HTML. |
||
144 | * |
||
145 | * @param string $string The string to truncate |
||
146 | * @param int $count |
||
147 | * @param string $suffix String to append to the end of the truncated string. |
||
148 | * @param string|bool $encoding |
||
149 | * @return string |
||
150 | * @since 2.0.1 |
||
151 | */ |
||
152 | 2 | protected static function truncateHtml($string, $count, $suffix, $encoding = false) |
|
201 | |||
202 | /** |
||
203 | * Check if given string starts with specified substring. |
||
204 | * Binary and multibyte safe. |
||
205 | * |
||
206 | * @param string $string Input string |
||
207 | * @param string $with Part to search inside the $string |
||
208 | * @param bool $caseSensitive Case sensitive search. Default is true. When case sensitive is enabled, $with must exactly match the starting of the string in order to get a true value. |
||
209 | * @return bool Returns true if first input starts with second input, false otherwise |
||
210 | */ |
||
211 | 19 | public static function startsWith($string, $with, $caseSensitive = true) |
|
222 | |||
223 | /** |
||
224 | * Check if given string ends with specified substring. |
||
225 | * Binary and multibyte safe. |
||
226 | * |
||
227 | * @param string $string Input string to check |
||
228 | * @param string $with Part to search inside of the $string. |
||
229 | * @param bool $caseSensitive Case sensitive search. Default is true. When case sensitive is enabled, $with must exactly match the ending of the string in order to get a true value. |
||
230 | * @return bool Returns true if first input ends with second input, false otherwise |
||
231 | */ |
||
232 | 19 | public static function endsWith($string, $with, $caseSensitive = true) |
|
247 | |||
248 | /** |
||
249 | * Explodes string into array, optionally trims values and skips empty ones |
||
250 | * |
||
251 | * @param string $string String to be exploded. |
||
252 | * @param string $delimiter Delimiter. Default is ','. |
||
253 | * @param mixed $trim Whether to trim each element. Can be: |
||
254 | * - boolean - to trim normally; |
||
255 | * - string - custom characters to trim. Will be passed as a second argument to `trim()` function. |
||
256 | * - callable - will be called for each value instead of trim. Takes the only argument - value. |
||
257 | * @param bool $skipEmpty Whether to skip empty strings between delimiters. Default is false. |
||
258 | * @return array |
||
259 | * @since 2.0.4 |
||
260 | */ |
||
261 | 1 | public static function explode($string, $delimiter = ',', $trim = true, $skipEmpty = false) |
|
282 | |||
283 | /** |
||
284 | * Counts words in a string |
||
285 | * @since 2.0.8 |
||
286 | * |
||
287 | * @param string $string |
||
288 | * @return int |
||
289 | */ |
||
290 | 2 | public static function countWords($string) |
|
294 | |||
295 | /** |
||
296 | * Returns string represenation of number value with replaced commas to dots, if decimal point |
||
297 | * of current locale is comma |
||
298 | * @param int|float|string $value |
||
299 | * @return string |
||
300 | * @since 2.0.11 |
||
301 | */ |
||
302 | 14 | public static function normalizeNumber($value) |
|
315 | |||
316 | /** |
||
317 | * Encodes string into "Base 64 Encoding with URL and Filename Safe Alphabet" (RFC 4648) |
||
318 | * @see https://tools.ietf.org/html/rfc4648#page-7 |
||
319 | * |
||
320 | * @param string $input |
||
321 | * @return string |
||
322 | * @since 2.0.11 |
||
323 | */ |
||
324 | 49 | public static function base64UrlEncode($input) |
|
328 | |||
329 | /** |
||
330 | * Decodes "Base 64 Encoding with URL and Filename Safe Alphabet" (RFC 4648) |
||
331 | * @see https://tools.ietf.org/html/rfc4648#page-7 |
||
332 | * |
||
333 | * @param string $input |
||
334 | * @return string |
||
335 | * @since 2.0.11 |
||
336 | */ |
||
337 | 4 | public static function base64UrlDecode($input) |
|
341 | } |
||
342 |
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.