rob006 /
yii2-dev
| Conditions | 17 |
| Paths | 102 |
| Total Lines | 49 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 306 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | protected function renderException($exception) |
||
| 31 | { |
||
| 32 | $previous = $exception->getPrevious(); |
||
| 33 | if ($exception instanceof UnknownCommandException) { |
||
| 34 | // display message and suggest alternatives in case of unknown command |
||
| 35 | $message = $this->formatMessage($exception->getName() . ': ') . $exception->command; |
||
| 36 | $alternatives = $exception->getSuggestedAlternatives(); |
||
| 37 | if (count($alternatives) === 1) { |
||
| 38 | $message .= "\n\nDid you mean \"" . reset($alternatives) . '"?'; |
||
| 39 | } elseif (count($alternatives) > 1) { |
||
| 40 | $message .= "\n\nDid you mean one of these?\n - " . implode("\n - ", $alternatives); |
||
| 41 | } |
||
| 42 | } elseif ($exception instanceof UserException && ($exception instanceof Exception || !YII_DEBUG)) { |
||
| 43 | $message = $this->formatMessage($exception->getName() . ': ') . $exception->getMessage(); |
||
| 44 | } elseif (YII_DEBUG) { |
||
| 45 | if ($exception instanceof Exception) { |
||
| 46 | $message = $this->formatMessage("Exception ({$exception->getName()})"); |
||
| 47 | } elseif ($exception instanceof ErrorException) { |
||
| 48 | $message = $this->formatMessage($exception->getName()); |
||
| 49 | } else { |
||
| 50 | $message = $this->formatMessage('Exception'); |
||
| 51 | } |
||
| 52 | $message .= $this->formatMessage(" '" . get_class($exception) . "'", [Console::BOLD, Console::FG_BLUE]) |
||
| 53 | . ' with message ' . $this->formatMessage("'{$exception->getMessage()}'", [Console::BOLD]) //. "\n" |
||
| 54 | . "\n\nin " . dirname($exception->getFile()) . DIRECTORY_SEPARATOR . $this->formatMessage(basename($exception->getFile()), [Console::BOLD]) |
||
| 55 | . ':' . $this->formatMessage($exception->getLine(), [Console::BOLD, Console::FG_YELLOW]) . "\n"; |
||
| 56 | if ($exception instanceof \yii\db\Exception && !empty($exception->errorInfo)) { |
||
| 57 | $message .= "\n" . $this->formatMessage("Error Info:\n", [Console::BOLD]) . print_r($exception->errorInfo, true); |
||
|
Bug
introduced
by
|
|||
| 58 | } |
||
| 59 | if ($previous === null) { |
||
| 60 | $message .= "\n" . $this->formatMessage("Stack trace:\n", [Console::BOLD]) . $exception->getTraceAsString(); |
||
| 61 | } |
||
| 62 | } else { |
||
| 63 | $message = $this->formatMessage('Error: ') . $exception->getMessage(); |
||
| 64 | } |
||
| 65 | |||
| 66 | if (PHP_SAPI === 'cli') { |
||
| 67 | Console::stderr($message . "\n"); |
||
| 68 | } else { |
||
| 69 | echo $message . "\n"; |
||
| 70 | } |
||
| 71 | if (YII_DEBUG && $previous !== null) { |
||
| 72 | $causedBy = $this->formatMessage('Caused by: ', [Console::BOLD]); |
||
| 73 | if (PHP_SAPI === 'cli') { |
||
| 74 | Console::stderr($causedBy); |
||
| 75 | } else { |
||
| 76 | echo $causedBy; |
||
| 77 | } |
||
| 78 | $this->renderException($previous); |
||
| 79 | } |
||
| 103 |
Loading history...