View::_getSummaryFilesHash() - Code Metrics - Inspection of "Add `fileCheckAlgorithm` property." - rmrevin/yii2-minify-view - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66d378...2fd39c )

by Revin

created 2016-05-22 20:13 UTC

View::_getSummaryFilesHash() B

↳ Parent: View

Complexity

Conditions	6
Paths	5

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	6.1979

Importance

Changes	7
Bugs	2	Features	2

Metric	Value
c	7
b	2
f	2
dl	0
loc	21
ccs	14
cts	17
cp	0.8235
rs	8.7624
cc	6
eloc	14
nc	5
nop	1
crap	6.1979

<?php
/**
 * View.php
 * @author Revin Roman
 * @link https://rmrevin.ru
 */

namespace rmrevin\yii\minify;

use yii\helpers;

/**
 * Class View
 * @package rmrevin\yii\minify
 */
class View extends \yii\web\View
{

    /** @var bool */
    public $enableMinify = true;

    /** @var string filemtime or sha1 */
    public $fileCheckAlgorithm = 'filemtime';

    /** @var bool */
    public $minifyCss = true;

    /** @var bool */
    public $minifyJs = true;

    /** @var bool */
    public $removeComments = true;

    /** @var string path alias to web base (in url) */
    public $web_path = '@web';

    /** @var string path alias to web base (absolute) */
    public $base_path = '@webroot';

    /** @var string path alias to save minify result */
    public $minify_path = '@webroot/minify';

    /** @var array positions of js files to be minified */
    public $js_position = [self::POS_END, self::POS_HEAD];

    /** @var bool|string charset forcibly assign, otherwise will use all of the files found charset */
    public $force_charset = false;

    /** @var bool whether to change @import on content */
    public $expand_imports = true;

    /** @var int */
    public $css_linebreak_pos = 2048;

    /** @var int|bool chmod of minified file. If false chmod not set */
    public $file_mode = 0664;

    /** @var array schemes that will be ignored during normalization url */
    public $schemas = ['//', 'http://', 'https://', 'ftp://'];

    /** @var bool do I need to compress the result html page. */
    public $compress_output = false;

    /**
     * @var array options for compressing output result
     *   * extra - use more compact algorithm
     *   * no-comments - cut all the html comments
     */
    public $compress_options = ['extra' => true];

    /**
     * @throws \rmrevin\yii\minify\Exception
     */
    public function init()
    {
        parent::init();

        $minify_path = $this->minify_path = (string)\Yii::getAlias($this->minify_path);
        if (!file_exists($minify_path)) {
            helpers\FileHelper::createDirectory($minify_path);
        }

        if (!is_readable($minify_path)) {
            throw new Exception('Directory for compressed assets is not readable.');
        }

        if (!is_writable($minify_path)) {
            throw new Exception('Directory for compressed assets is not writable.');
        }

        if (true === $this->compress_output) {
            \Yii::$app->response->on(\yii\web\Response::EVENT_BEFORE_SEND, function (\yii\base\Event $Event) {
                /** @var \yii\web\Response $Response */
                $Response = $Event->sender;
                if ($Response->format === \yii\web\Response::FORMAT_HTML) {
                    if (!empty($Response->data)) {
                        $Response->data = HtmlCompressor::compress($Response->data, $this->compress_options);
                    }

                    if (!empty($Response->content)) {
                        $Response->content = HtmlCompressor::compress($Response->content, $this->compress_options);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                    }
                }
            });
        }
    }

    /**
     * @inheritdoc
     */
    public function endPage($ajaxMode = false)
    {
        $this->trigger(self::EVENT_END_PAGE);

        $content = ob_get_clean();
        foreach (array_keys($this->assetBundles) as $bundle) {
            $this->registerAssetFiles($bundle);
        }

        if (true === $this->enableMinify) {
            if (true === $this->minifyCss) {
                $this->minifyCSS();
            }

            if (true === $this->minifyJs) {
                $this->minifyJS();
            }
        }

        echo strtr(
            $content,
            [
                self::PH_HEAD => $this->renderHeadHtml(),
                self::PH_BODY_BEGIN => $this->renderBodyBeginHtml(),
                self::PH_BODY_END => $this->renderBodyEndHtml($ajaxMode),
            ]
        );

        $this->clear();
    }

    /**
     * @return self
     */
    protected function minifyCSS()
    {
        if (!empty($this->cssFiles)) {
            $cssFiles = $this->cssFiles;

            $this->cssFiles = [];

            $toMinify = [];

            foreach ($cssFiles as $file => $html) {

                if ($this->thisFileNeedMinify($file, $html)) {
                    $toMinify[$file] = $html;
                } else {
                    if (!empty($toMinify)) {
                        $this->processMinifyCss($toMinify);

                        $toMinify = [];
                    }

                    $this->cssFiles[$file] = $html;
                }
            }

            if (!empty($toMinify)) {
                $this->processMinifyCss($toMinify);
            }

            unset($toMinify);
        }

        return $this;
    }

    /**
     * @param array $files
     */
    protected function processMinifyCss($files)
    {
        $resultFile = $this->minify_path . '/' . $this->_getSummaryFilesHash($files) . '.css';

        if (!file_exists($resultFile)) {
            $css = '';

            foreach ($files as $file => $html) {
                $path = dirname($file);
                $file = $this->getAbsoluteFilePath($file);

                $content = file_get_contents($file);

                preg_match_all('|url\(([^)]+)\)|is', $content, $m);
                if (!empty($m[0])) {
                    $result = [];

                    foreach ($m[0] as $k => $v) {
                        if (in_array(strpos($m[1][$k], 'data:'), [0, 1], true)) {
                            continue;
                        }

                        $url = str_replace(['\'', '"'], '', $m[1][$k]);

                        if ($this->isUrl($url)) {
                            $result[$m[1][$k]] = '\'' . $url . '\'';
                        } else {
                            $result[$m[1][$k]] = '\'' . $path . '/' . $url . '\'';
                        }
                    }

                    $content = str_replace(array_keys($result), array_values($result), $content);
                }

                $css .= $content;
            }

            $this->expandImports($css);

            $this->removeCssComments($css);

            $css = (new \CSSmin())
                ->run($css, $this->css_linebreak_pos);

            if (false !== $this->force_charset) {
                $charsets = '@charset "' . (string)$this->force_charset . '";' . "\n";
            } else {
                $charsets = $this->collectCharsets($css);
            }

            $imports = $this->collectImports($css);
            $fonts = $this->collectFonts($css);

            file_put_contents($resultFile, $charsets . $imports . $fonts . $css);

            if (false !== $this->file_mode) {
                @chmod($resultFile, $this->file_mode);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }

        $file = sprintf('%s%s', \Yii::getAlias($this->web_path), str_replace(\Yii::getAlias($this->base_path), '', $resultFile));

        $this->cssFiles[$file] = helpers\Html::cssFile($file);
    }

    /**
     * @return self
     */
    protected function minifyJS()
    {
        if (!empty($this->jsFiles)) {
            $jsFiles = $this->jsFiles;

            foreach ($jsFiles as $position => $files) {
                if (false === in_array($position, $this->js_position, true)) {
                    $this->jsFiles[$position] = [];
                    foreach ($files as $file => $html) {
                        $this->jsFiles[$position][$file] = $html;
                    }
                } else {
                    $this->jsFiles[$position] = [];

                    $toMinify = [];

                    foreach ($files as $file => $html) {

                        if ($this->thisFileNeedMinify($file, $html)) {
                            $toMinify[$file] = $html;
                        } else {
                            if (!empty($toMinify)) {
                                $this->processMinifyJs($position, $toMinify);

                                $toMinify = [];
                            }

                            $this->jsFiles[$position][$file] = $html;
                        }
                    }

                    if (!empty($toMinify)) {
                        $this->processMinifyJs($position, $toMinify);
                    }

                    unset($toMinify);
                }
            }
        }

        return $this;
    }

    /**
     * @param integer $position
     * @param array $files
     */
    protected function processMinifyJs($position, $files)
    {
        $resultFile = sprintf('%s/%s.js', $this->minify_path, $this->_getSummaryFilesHash($files));
        if (!file_exists($resultFile)) {
            $js = '';
            foreach ($files as $file => $html) {
                $file = $this->getAbsoluteFilePath($file);
                $js .= file_get_contents($file) . ';' . PHP_EOL;
            }

            $this->removeJsComments($js);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

            $compressedJs = (new \JSMin($js))
                ->min();

            file_put_contents($resultFile, $compressedJs);

            if (false !== $this->file_mode) {
                @chmod($resultFile, $this->file_mode);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }

        $file = sprintf('%s%s', \Yii::getAlias($this->web_path), str_replace(\Yii::getAlias($this->base_path), '', $resultFile));

        $this->jsFiles[$position][$file] = helpers\Html::jsFile($file);
    }

    /**
     * @param string $url
     * @param boolean $checkSlash
     * @return bool
     */
    protected function isUrl($url, $checkSlash = true)
    {
        $regexp = '#^(' . implode('|', $this->schemas) . ')#is';
        if ($checkSlash) {
            $regexp = '#^(/|\\\\|' . implode('|', $this->schemas) . ')#is';
        }

        return (bool)preg_match($regexp, $url);
    }

    /**
     * @param string $string
     * @return bool
     */
    protected function isContainsConditionalComment($string)
    {
        return strpos($string, '<![endif]-->') !== false;
    }

    /**
     * @param string $file
     * @param string $html
     * @return bool
     */
    protected function thisFileNeedMinify($file, $html)
    {
        return !$this->isUrl($file, false) && !$this->isContainsConditionalComment($html);
    }

    /**
     * @param string $code
     * @return string
     */
    protected function collectCharsets(&$code)
    {
        return $this->_collect($code, '|\@charset[^;]+|is', function ($string) {
            return $string . ';';
        });
    }

    /**
     * @param string $code
     * @return string
     */
    protected function collectImports(&$code)
    {
        return $this->_collect($code, '|\@import[^;]+|is', function ($string) {
            return $string . ';';
        });
    }

    /**
     * @param string $code
     * @return string
     */
    protected function collectFonts(&$code)
    {
        return $this->_collect($code, '|\@font-face\{[^}]+\}|is', function ($string) {
            return $string;
        });
    }

    /**
     * @param string $code
     */
    protected function removeCssComments(&$code)
    {
        if (true === $this->removeComments) {
            $code = preg_replace('#/\*(?:[^*]*(?:\*(?!/))*)*\*/#', '', $code);
        }
    }

    /**
     * @param string $code
     */
    protected function removeJsComments(&$code)

    {
        // @todo
        if (true === $this->removeComments) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //$code = preg_replace('', '', $code);

        }
    }

    /**
     * @param string $code
     */
    protected function expandImports(&$code)
    {
        if (true === $this->expand_imports) {
            preg_match_all('|\@import\s([^;]+);|is', str_replace('&amp;', '&', $code), $m);
            if (!empty($m[0])) {
                foreach ($m[0] as $k => $v) {
                    $import_url = $m[1][$k];
                    if (!empty($import_url)) {
                        $import_content = $this->_getImportContent($import_url);
                        if (!empty($import_content)) {
                            $code = str_replace($m[0][$k], $import_content, $code);
                        }
                    }
                }
            }
        }
    }

    /**
     * @param string $url
     * @return null|string
     */
    protected function _getImportContent($url)
    {
        $result = null;

        if ('url(' === helpers\StringHelper::byteSubstr($url, 0, 4)) {
            $url = str_replace(['url(\'', 'url("', 'url(', '\')', '")', ')'], '', $url);

            if (helpers\StringHelper::byteSubstr($url, 0, 2) === '//') {
                $url = preg_replace('|^//|', 'http://', $url, 1);
            }

            if (!empty($url)) {
                $result = file_get_contents($url);
            }
        }

        return $result;
    }

    /**
     * @param string $code
     * @param string $pattern
     * @param callable $handler
     * @return string
     */
    protected function _collect(&$code, $pattern, $handler)
    {
        $result = '';

        preg_match_all($pattern, $code, $m);
        foreach ($m[0] as $string) {
            $string = $handler($string);
            $code = str_replace($string, '', $code);

            $result .= $string . PHP_EOL;
        }

        return $result;
    }

    /**
     * @param string $file
     * @return string
     */
    protected function cleanFileName($file)
    {
        return (strpos($file, '?')) ? parse_url($file, PHP_URL_PATH) : $file;
    }

    /**
     * @param string $file
     * @return string
     */
    protected function getAbsoluteFilePath($file)
    {
        return \Yii::getAlias($this->base_path) . str_replace(\Yii::getAlias($this->web_path), '', $this->cleanFileName($file));
    }

    /**
     * @param array $files
     * @return string
     */
    protected function _getSummaryFilesHash($files)
    {
        $result = '';
        foreach ($files as $file => $html) {
            $path = $this->getAbsoluteFilePath($file);

            if ($this->thisFileNeedMinify($file, $html) && file_exists($path)) {
                switch ($this->fileCheckAlgorithm) {
                    default:
                    case 'filemtime':
                        $result .= filemtime($path);
                        break;
                    case 'sha1':
                        $result .= sha1_file($path);
                        break;
                }
            }
        }

        return sha1($result);
    }
}

1			<?php
2			/**
3			* View.php
4			* @author Revin Roman
5			* @link https://rmrevin.ru
6			*/
7
8			namespace rmrevin\yii\minify;
9
10			use yii\helpers;
11
12			/**
13			* Class View
14			* @package rmrevin\yii\minify
15			*/
16			class View extends \yii\web\View
17			{
18
19			/** @var bool */
20			public $enableMinify = true;
21
22			/** @var string filemtime or sha1 */
23			public $fileCheckAlgorithm = 'filemtime';
24
25			/** @var bool */
26			public $minifyCss = true;
27
28			/** @var bool */
29			public $minifyJs = true;
30
31			/** @var bool */
32			public $removeComments = true;
33
34			/** @var string path alias to web base (in url) */
35			public $web_path = '@web';
36
37			/** @var string path alias to web base (absolute) */
38			public $base_path = '@webroot';
39
40			/** @var string path alias to save minify result */
41			public $minify_path = '@webroot/minify';
42
43			/** @var array positions of js files to be minified */
44			public $js_position = [self::POS_END, self::POS_HEAD];
45
46			/** @var bool\|string charset forcibly assign, otherwise will use all of the files found charset */
47			public $force_charset = false;
48
49			/** @var bool whether to change @import on content */
50			public $expand_imports = true;
51
52			/** @var int */
53			public $css_linebreak_pos = 2048;
54
55			/** @var int\|bool chmod of minified file. If false chmod not set */
56			public $file_mode = 0664;
57
58			/** @var array schemes that will be ignored during normalization url */
59			public $schemas = ['//', 'http://', 'https://', 'ftp://'];
60
61			/** @var bool do I need to compress the result html page. */
62			public $compress_output = false;
63
64			/**
65			* @var array options for compressing output result
66			* * extra - use more compact algorithm
67			* * no-comments - cut all the html comments
68			*/
69			public $compress_options = ['extra' => true];
70
71			/**
72			* @throws \rmrevin\yii\minify\Exception
73			*/
74	6		public function init()
75			{
76	6		parent::init();
77
78	6		$minify_path = $this->minify_path = (string)\Yii::getAlias($this->minify_path);
79	6		if (!file_exists($minify_path)) {
80	6		helpers\FileHelper::createDirectory($minify_path);
81	6		}
82
83	6		if (!is_readable($minify_path)) {
84			throw new Exception('Directory for compressed assets is not readable.');
85			}
86
87	6		if (!is_writable($minify_path)) {
88			throw new Exception('Directory for compressed assets is not writable.');
89			}
90
91	6		if (true === $this->compress_output) {
92			\Yii::$app->response->on(\yii\web\Response::EVENT_BEFORE_SEND, function (\yii\base\Event $Event) {
93			/** @var \yii\web\Response $Response */
94			$Response = $Event->sender;
95			if ($Response->format === \yii\web\Response::FORMAT_HTML) {
96			if (!empty($Response->data)) {
97			$Response->data = HtmlCompressor::compress($Response->data, $this->compress_options);
98			}
99
100			if (!empty($Response->content)) {
101			$Response->content = HtmlCompressor::compress($Response->content, $this->compress_options);
			0 ignored issues – show Documentation Bug introduced 2016-02-23 19:34 UTC by Report Bug Copy Issue Report It seems like `\rmrevin\yii\minify\Html...this->compress_options)` can also be of type `false`. However, the property `$content` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
102			}
103			}
104			});
105			}
106	6		}
107
108			/**
109			* @inheritdoc
110			*/
111	4		public function endPage($ajaxMode = false)
112			{
113	4		$this->trigger(self::EVENT_END_PAGE);
114
115	4		$content = ob_get_clean();
116	4		foreach (array_keys($this->assetBundles) as $bundle) {
117	4		$this->registerAssetFiles($bundle);
118	4		}
119
120	4		if (true === $this->enableMinify) {
121	4		if (true === $this->minifyCss) {
122	4		$this->minifyCSS();
123	4		}
124
125	4		if (true === $this->minifyJs) {
126	4		$this->minifyJS();
127	4		}
128	4		}
129
130	4		echo strtr(
131	4		$content,
132			[
133	4		self::PH_HEAD => $this->renderHeadHtml(),
134	4		self::PH_BODY_BEGIN => $this->renderBodyBeginHtml(),
135	4		self::PH_BODY_END => $this->renderBodyEndHtml($ajaxMode),
136			]
137	4		);
138
139	4		$this->clear();
140	4		}
141
142			/**
143			* @return self
144			*/
145	4		protected function minifyCSS()
146			{
147	4		if (!empty($this->cssFiles)) {
148	4		$cssFiles = $this->cssFiles;
149
150	4		$this->cssFiles = [];
151
152	4		$toMinify = [];
153
154	4	View Code Duplication	foreach ($cssFiles as $file => $html) {
			0 ignored issues – show Duplication introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
155	4		if ($this->thisFileNeedMinify($file, $html)) {
156	4		$toMinify[$file] = $html;
157	4		} else {
158			if (!empty($toMinify)) {
159			$this->processMinifyCss($toMinify);
160
161			$toMinify = [];
162			}
163
164			$this->cssFiles[$file] = $html;
165			}
166	4		}
167
168	4		if (!empty($toMinify)) {
169	4		$this->processMinifyCss($toMinify);
170	4		}
171
172	4		unset($toMinify);
173	4		}
174
175	4		return $this;
176			}
177
178			/**
179			* @param array $files
180			*/
181	4		protected function processMinifyCss($files)
182			{
183	4		$resultFile = $this->minify_path . '/' . $this->_getSummaryFilesHash($files) . '.css';
184
185	4		if (!file_exists($resultFile)) {
186	4		$css = '';
187
188	4		foreach ($files as $file => $html) {
189	4		$path = dirname($file);
190	4		$file = $this->getAbsoluteFilePath($file);
191
192	4		$content = file_get_contents($file);
193
194	4		preg_match_all('\|url\(([^)]+)\)\|is', $content, $m);
195	4		if (!empty($m[0])) {
196	4		$result = [];
197
198	4		foreach ($m[0] as $k => $v) {
199	4		if (in_array(strpos($m[1][$k], 'data:'), [0, 1], true)) {
200	4		continue;
201			}
202
203	4		$url = str_replace(['\'', '"'], '', $m[1][$k]);
204
205	4		if ($this->isUrl($url)) {
206	4		$result[$m[1][$k]] = '\'' . $url . '\'';
207	4		} else {
208	4		$result[$m[1][$k]] = '\'' . $path . '/' . $url . '\'';
209			}
210	4		}
211
212	4		$content = str_replace(array_keys($result), array_values($result), $content);
213	4		}
214
215	4		$css .= $content;
216	4		}
217
218	4		$this->expandImports($css);
219
220	4		$this->removeCssComments($css);
221
222	4		$css = (new \CSSmin())
223	4		->run($css, $this->css_linebreak_pos);
224
225	4		if (false !== $this->force_charset) {
226	2		$charsets = '@charset "' . (string)$this->force_charset . '";' . "\n";
227	2		} else {
228	2		$charsets = $this->collectCharsets($css);
229			}
230
231	4		$imports = $this->collectImports($css);
232	4		$fonts = $this->collectFonts($css);
233
234	4		file_put_contents($resultFile, $charsets . $imports . $fonts . $css);
235
236	4		if (false !== $this->file_mode) {
237	4		@chmod($resultFile, $this->file_mode);
			0 ignored issues – show Security Best Practice introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
238	4		}
239	4		}
240
241	4		$file = sprintf('%s%s', \Yii::getAlias($this->web_path), str_replace(\Yii::getAlias($this->base_path), '', $resultFile));
242
243	4		$this->cssFiles[$file] = helpers\Html::cssFile($file);
244	4		}
245
246			/**
247			* @return self
248			*/
249	4		protected function minifyJS()
250			{
251	4		if (!empty($this->jsFiles)) {
252	4		$jsFiles = $this->jsFiles;
253
254	4		foreach ($jsFiles as $position => $files) {
255	4		if (false === in_array($position, $this->js_position, true)) {
256	4		$this->jsFiles[$position] = [];
257	4		foreach ($files as $file => $html) {
258	4		$this->jsFiles[$position][$file] = $html;
259	4		}
260	4		} else {
261	4		$this->jsFiles[$position] = [];
262
263	4		$toMinify = [];
264
265	4	View Code Duplication	foreach ($files as $file => $html) {
			0 ignored issues – show Duplication introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
266	4		if ($this->thisFileNeedMinify($file, $html)) {
267	4		$toMinify[$file] = $html;
268	4		} else {
269	4		if (!empty($toMinify)) {
270			$this->processMinifyJs($position, $toMinify);
271
272			$toMinify = [];
273			}
274
275	4		$this->jsFiles[$position][$file] = $html;
276			}
277	4		}
278
279	4		if (!empty($toMinify)) {
280	4		$this->processMinifyJs($position, $toMinify);
281	4		}
282
283	4		unset($toMinify);
284			}
285	4		}
286	4		}
287
288	4		return $this;
289			}
290
291			/**
292			* @param integer $position
293			* @param array $files
294			*/
295	4		protected function processMinifyJs($position, $files)
296			{
297	4		$resultFile = sprintf('%s/%s.js', $this->minify_path, $this->_getSummaryFilesHash($files));
298	4		if (!file_exists($resultFile)) {
299	4		$js = '';
300	4		foreach ($files as $file => $html) {
301	4		$file = $this->getAbsoluteFilePath($file);
302	4		$js .= file_get_contents($file) . ';' . PHP_EOL;
303	4		}
304
305	4		$this->removeJsComments($js);
			0 ignored issues – show Unused Code introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report The call to the method `rmrevin\yii\minify\View::removeJsComments()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
306
307	4		$compressedJs = (new \JSMin($js))
308	4		->min();
309
310	4		file_put_contents($resultFile, $compressedJs);
311
312	4		if (false !== $this->file_mode) {
313	4		@chmod($resultFile, $this->file_mode);
			0 ignored issues – show Security Best Practice introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
314	4		}
315	4		}
316
317	4		$file = sprintf('%s%s', \Yii::getAlias($this->web_path), str_replace(\Yii::getAlias($this->base_path), '', $resultFile));
318
319	4		$this->jsFiles[$position][$file] = helpers\Html::jsFile($file);
320	4		}
321
322			/**
323			* @param string $url
324			* @param boolean $checkSlash
325			* @return bool
326			*/
327	4		protected function isUrl($url, $checkSlash = true)
328			{
329	4		$regexp = '#^(' . implode('\|', $this->schemas) . ')#is';
330	4		if ($checkSlash) {
331	4		$regexp = '#^(/\|\\\\\|' . implode('\|', $this->schemas) . ')#is';
332	4		}
333
334	4		return (bool)preg_match($regexp, $url);
335			}
336
337			/**
338			* @param string $string
339			* @return bool
340			*/
341	4		protected function isContainsConditionalComment($string)
342			{
343	4		return strpos($string, '<![endif]-->') !== false;
344			}
345
346			/**
347			* @param string $file
348			* @param string $html
349			* @return bool
350			*/
351	4		protected function thisFileNeedMinify($file, $html)
352			{
353	4		return !$this->isUrl($file, false) && !$this->isContainsConditionalComment($html);
354			}
355
356			/**
357			* @param string $code
358			* @return string
359			*/
360	2		protected function collectCharsets(&$code)
361			{
362			return $this->_collect($code, '\|\@charset[^;]+\|is', function ($string) {
363	2		return $string . ';';
364	2		});
365			}
366
367			/**
368			* @param string $code
369			* @return string
370			*/
371	4		protected function collectImports(&$code)
372			{
373			return $this->_collect($code, '\|\@import[^;]+\|is', function ($string) {
374	2		return $string . ';';
375	4		});
376			}
377
378			/**
379			* @param string $code
380			* @return string
381			*/
382			protected function collectFonts(&$code)
383			{
384	4		return $this->_collect($code, '\|\@font-face\{[^}]+\}\|is', function ($string) {
385	2		return $string;
386	4		});
387			}
388
389			/**
390			* @param string $code
391			*/
392	4		protected function removeCssComments(&$code)
393			{
394	4		if (true === $this->removeComments) {
395	4		$code = preg_replace('#/\(?:[^](?:\(?!/)))\*/#', '', $code);
396	4		}
397	4		}
398
399			/**
400			* @param string $code
401			*/
402	4		protected function removeJsComments(&$code)
			0 ignored issues – show Unused Code introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report The parameter `$code` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
403			{
404			// @todo
405	4		if (true === $this->removeComments) {
			0 ignored issues – show Unused Code introduced 2016-01-19 00:48 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
406			//$code = preg_replace('', '', $code);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-23 19:34 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
407	4		}
408	4		}
409
410			/**
411			* @param string $code
412			*/
413	4		protected function expandImports(&$code)
414			{
415	4		if (true === $this->expand_imports) {
416	2		preg_match_all('\|\@import\s([^;]+);\|is', str_replace('&', '&', $code), $m);
417	2		if (!empty($m[0])) {
418	2		foreach ($m[0] as $k => $v) {
419	2		$import_url = $m[1][$k];
420	2		if (!empty($import_url)) {
421	2		$import_content = $this->_getImportContent($import_url);
422	2		if (!empty($import_content)) {
423	2		$code = str_replace($m[0][$k], $import_content, $code);
424	2		}
425	2		}
426	2		}
427	2		}
428	2		}
429	4		}
430
431			/**
432			* @param string $url
433			* @return null\|string
434			*/
435	2		protected function _getImportContent($url)
436			{
437	2		$result = null;
438
439	2		if ('url(' === helpers\StringHelper::byteSubstr($url, 0, 4)) {
440	2		$url = str_replace(['url(\'', 'url("', 'url(', '\')', '")', ')'], '', $url);
441
442	2		if (helpers\StringHelper::byteSubstr($url, 0, 2) === '//') {
443	2		$url = preg_replace('\|^//\|', 'http://', $url, 1);
444	2		}
445
446	2		if (!empty($url)) {
447	2		$result = file_get_contents($url);
448	2		}
449	2		}
450
451	2		return $result;
452			}
453
454			/**
455			* @param string $code
456			* @param string $pattern
457			* @param callable $handler
458			* @return string
459			*/
460	4		protected function _collect(&$code, $pattern, $handler)
461			{
462	4		$result = '';
463
464	4		preg_match_all($pattern, $code, $m);
465	4		foreach ($m[0] as $string) {
466	4		$string = $handler($string);
467	4		$code = str_replace($string, '', $code);
468
469	4		$result .= $string . PHP_EOL;
470	4		}
471
472	4		return $result;
473			}
474
475			/**
476			* @param string $file
477			* @return string
478			*/
479	4		protected function cleanFileName($file)
480			{
481	4		return (strpos($file, '?')) ? parse_url($file, PHP_URL_PATH) : $file;
482			}
483
484			/**
485			* @param string $file
486			* @return string
487			*/
488	4		protected function getAbsoluteFilePath($file)
489			{
490	4		return \Yii::getAlias($this->base_path) . str_replace(\Yii::getAlias($this->web_path), '', $this->cleanFileName($file));
491			}
492
493			/**
494			* @param array $files
495			* @return string
496			*/
497	4		protected function _getSummaryFilesHash($files)
498			{
499	4		$result = '';
500	4		foreach ($files as $file => $html) {
501	4		$path = $this->getAbsoluteFilePath($file);
502
503	4		if ($this->thisFileNeedMinify($file, $html) && file_exists($path)) {
504	4		switch ($this->fileCheckAlgorithm) {
505	4		default:
506	4		case 'filemtime':
507	4		$result .= filemtime($path);
508	4		break;
509			case 'sha1':
510			$result .= sha1_file($path);
511			break;
512	4		}
513	4		}
514	4		}
515
516	4		return sha1($result);
517			}
518			}

rmrevin / yii2-minify-view

Push — master ( 66d378...2fd39c )

View::_getSummaryFilesHash() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like