Issues in ExternalResource.php (master) - Issues in master - rmrevin/yii2-file - Measure and Improve Code Quality continuously with Scrutinizer

Issues (25)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

resources/ExternalResource.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * ExternalResource.php
 * @author Revin Roman http://phptime.ru
 */

namespace rmrevin\yii\module\File\resources;

/**
 * Class ExternalResource
 * @package rmrevin\yii\module\File\resources
 */
class ExternalResource extends AbstractResource implements ResourceInterface
{

    /** @var string */
    private $temp;

    /** @var string */
    private $source;

    /**
     * @param string $source
     */
    public function setSource($source)
    {
        $this->source = $source;
        $this->temp = $this->copyTempResource();
    }

    /**
     * @return string
     */
    public function getName()
    {
        return basename($this->source);
    }

    /**
     * @return int
     */
    public function getSize()
    {
        return filesize($this->temp);
    }

    /**
     * @return string
     * @throws \yii\base\InvalidConfigException
     */
    public function getMime()
    {
        return \yii\helpers\FileHelper::getMimeType($this->temp);
    }

    /**
     * @return string
     */
    public function getTemp()
    {
        return $this->temp;
    }

    /**
     * @return string|false
     */
    private function copyTempResource()
    {
        if (false === $this->checkAvailable()) {
            throw new \RuntimeException('External resource not available');
        }

        $url = parse_url($this->source);
        $ext = pathinfo($url['path'], PATHINFO_EXTENSION);
        $temp = sys_get_temp_dir() . DIRECTORY_SEPARATOR . uniqid('file-') . '.' . $ext;

        $result = copy($this->source, $temp);
        @chmod($temp, 0664);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return true === $result ? $temp : false;
    }

    /**
     * @return bool
     */
    private function checkAvailable()
    {
        $result = false;

        $ch = curl_init($this->source);
        curl_setopt_array($ch, [
            CURLOPT_HEADER => true,
            CURLOPT_FOLLOWLOCATION => true,
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_NOBODY => true,
            CURLOPT_TIMEOUT => 30,
            CURLOPT_SSL_VERIFYHOST => false,
            CURLOPT_SSL_VERIFYPEER => false,
        ]);

        curl_exec($ch);

        if (!curl_errno($ch)) {
            $info = curl_getinfo($ch);

            if ($info['http_code'] === 200) {
                $result = true;
            }
        }

        curl_close($ch);

        return $result;
    }
}

1		<?php
2		/**
3		* ExternalResource.php
4		* @author Revin Roman http://phptime.ru
5		*/
6
7		namespace rmrevin\yii\module\File\resources;
8
9		/**
10		* Class ExternalResource
11		* @package rmrevin\yii\module\File\resources
12		*/
13		class ExternalResource extends AbstractResource implements ResourceInterface
14		{
15
16		/** @var string */
17		private $temp;
18
19		/** @var string */
20		private $source;
21
22		/**
23		* @param string $source
24		*/
25	2	public function setSource($source)
26		{
27	2	$this->source = $source;
28	2	$this->temp = $this->copyTempResource();
29	1	}
30
31		/**
32		* @return string
33		*/
34	1	public function getName()
35		{
36	1	return basename($this->source);
37		}
38
39		/**
40		* @return int
41		*/
42	1	public function getSize()
43		{
44	1	return filesize($this->temp);
45		}
46
47		/**
48		* @return string
49		* @throws \yii\base\InvalidConfigException
50		*/
51	1	public function getMime()
52		{
53	1	return \yii\helpers\FileHelper::getMimeType($this->temp);
54		}
55
56		/**
57		* @return string
58		*/
59	1	public function getTemp()
60		{
61	1	return $this->temp;
62		}
63
64		/**
65		* @return string\|false
66		*/
67	2	private function copyTempResource()
68		{
69	2	if (false === $this->checkAvailable()) {
70	1	throw new \RuntimeException('External resource not available');
71		}
72
73	1	$url = parse_url($this->source);
74	1	$ext = pathinfo($url['path'], PATHINFO_EXTENSION);
75	1	$temp = sys_get_temp_dir() . DIRECTORY_SEPARATOR . uniqid('file-') . '.' . $ext;
76
77	1	$result = copy($this->source, $temp);
78	1	@chmod($temp, 0664);
		0 ignored issues – show Security Best Practice introduced 2016-04-28 13:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
79
80	1	return true === $result ? $temp : false;
81		}
82
83		/**
84		* @return bool
85		*/
86	2	private function checkAvailable()
87		{
88	2	$result = false;
89
90	2	$ch = curl_init($this->source);
91	2	curl_setopt_array($ch, [
92	2	CURLOPT_HEADER => true,
93	2	CURLOPT_FOLLOWLOCATION => true,
94	2	CURLOPT_RETURNTRANSFER => true,
95	2	CURLOPT_NOBODY => true,
96	2	CURLOPT_TIMEOUT => 30,
97	2	CURLOPT_SSL_VERIFYHOST => false,
98	2	CURLOPT_SSL_VERIFYPEER => false,
99	2	]);
100
101	2	curl_exec($ch);
102
103	2	if (!curl_errno($ch)) {
104	1	$info = curl_getinfo($ch);
105
106	1	if ($info['http_code'] === 200) {
107	1	$result = true;
108	1	}
109	1	}
110
111	2	curl_close($ch);
112
113	2	return $result;
114		}
115		}

rmrevin / yii2-file

Issues (25)

Security Analysis no request data

resources/ExternalResource.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like